Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1b17d7d5-1181-5156-07fd-9c50ee7b1e5c@amazon.com>
Date:   Mon, 17 Apr 2023 15:05:02 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.10.0
Subject: Re: [PATCH RFC v8 45/56] KVM: SVM: Provide support for
 SNP_GUEST_REQUEST NAE event
Content-Language: en-US
To:     Michael Roth <michael.roth@amd.com>, <kvm@vger.kernel.org>
CC:     <linux-coco@lists.linux.dev>, <linux-mm@kvack.org>,
        <linux-crypto@vger.kernel.org>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>, <tglx@linutronix.de>,
        <mingo@redhat.com>, <jroedel@suse.de>, <thomas.lendacky@amd.com>,
        <hpa@zytor.com>, <ardb@kernel.org>, <pbonzini@redhat.com>,
        <seanjc@google.com>, <vkuznets@redhat.com>, <jmattson@google.com>,
        <luto@kernel.org>, <dave.hansen@linux.intel.com>, <slp@redhat.com>,
        <pgonda@google.com>, <peterz@infradead.org>,
        <srinivas.pandruvada@linux.intel.com>, <rientjes@google.com>,
        <dovmurik@linux.ibm.com>, <tobin@ibm.com>, <bp@alien8.de>,
        <vbabka@suse.cz>, <kirill@shutemov.name>, <ak@linux.intel.com>,
        <tony.luck@intel.com>, <marcorr@google.com>,
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        <alpergun@google.com>, <dgilbert@redhat.com>, <jarkko@kernel.org>,
        <ashish.kalra@amd.com>, <nikunj.dadhania@amd.com>,
        Brijesh Singh <brijesh.singh@amd.com>,
        "Rapan, Sabin" <sabrapan@amazon.com>
References: <20230220183847.59159-1-michael.roth@amd.com>
 <20230220183847.59159-46-michael.roth@amd.com>
From:   Alexander Graf <graf@amazon.com>
In-Reply-To: <20230220183847.59159-46-michael.roth@amd.com>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: base64
Precedence: bulk

Ck9uIDIwLjAyLjIzIDE5OjM4LCBNaWNoYWVsIFJvdGggd3JvdGU6Cgo+IEZyb206IEJyaWplc2gg
U2luZ2ggPGJyaWplc2guc2luZ2hAYW1kLmNvbT4KPgo+IFZlcnNpb24gMiBvZiBHSENCIHNwZWNp
ZmljYXRpb24gYWRkZWQgdGhlIHN1cHBvcnQgZm9yIHR3byBTTlAgR3Vlc3QKPiBSZXF1ZXN0IE1l
c3NhZ2UgTkFFIGV2ZW50cy4gVGhlIGV2ZW50cyBhbGxvd3MgZm9yIGFuIFNFVi1TTlAgZ3Vlc3Qg
dG8KPiBtYWtlIHJlcXVlc3QgdG8gdGhlIFNFVi1TTlAgZmlybXdhcmUgdGhyb3VnaCBoeXBlcnZp
c29yIHVzaW5nIHRoZQo+IFNOUF9HVUVTVF9SRVFVRVNUIEFQSSBkZWZpbmUgaW4gdGhlIFNFVi1T
TlAgZmlybXdhcmUgc3BlY2lmaWNhdGlvbi4KPgo+IFRoZSBTTlBfRVhUX0dVRVNUX1JFUVVFU1Qg
aXMgc2ltaWxhciB0byBTTlBfR1VFU1RfUkVRVUVTVCB3aXRoIHRoZQo+IGRpZmZlcmVuY2Ugb2Yg
YW4gYWRkaXRpb25hbCBjZXJ0aWZpY2F0ZSBibG9iIHRoYXQgY2FuIGJlIHBhc3NlZCB0aHJvdWdo
Cj4gdGhlIFNOUF9TRVRfQ09ORklHIGlvY3RsIGRlZmluZWQgaW4gdGhlIENDUCBkcml2ZXIuIFRo
ZSBDQ1AgZHJpdmVyCj4gcHJvdmlkZXMgc25wX2d1ZXN0X2V4dF9ndWVzdF9yZXF1ZXN0KCkgdGhh
dCBpcyB1c2VkIGJ5IHRoZSBLVk0gdG8gZ2V0Cj4gYm90aCB0aGUgcmVwb3J0IGFuZCBjZXJ0aWZp
Y2F0ZSBkYXRhIGF0IG9uY2UuCj4KPiBTaWduZWQtb2ZmLWJ5OiBCcmlqZXNoIFNpbmdoIDxicmlq
ZXNoLnNpbmdoQGFtZC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogQXNoaXNoIEthbHJhIDxhc2hpc2gu
a2FscmFAYW1kLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBNaWNoYWVsIFJvdGggPG1pY2hhZWwucm90
aEBhbWQuY29tPgo+IC0tLQo+ICAgYXJjaC94ODYva3ZtL3N2bS9zZXYuYyB8IDE4NSArKysrKysr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLQo+ICAgYXJjaC94ODYva3ZtL3N2bS9z
dm0uaCB8ICAgMiArCj4gICAyIGZpbGVzIGNoYW5nZWQsIDE4MSBpbnNlcnRpb25zKCspLCA2IGRl
bGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2FyY2gveDg2L2t2bS9zdm0vc2V2LmMgYi9hcmNo
L3g4Ni9rdm0vc3ZtL3Nldi5jCj4gaW5kZXggMTk3YjFmOTA0NTY3Li45MjE3OTYxNDEwMmUgMTAw
NjQ0Cj4gLS0tIGEvYXJjaC94ODYva3ZtL3N2bS9zZXYuYwo+ICsrKyBiL2FyY2gveDg2L2t2bS9z
dm0vc2V2LmMKPiBAQCAtMzI3LDYgKzMyNyw3IEBAIHN0YXRpYyBpbnQgc2V2X2d1ZXN0X2luaXQo
c3RydWN0IGt2bSAqa3ZtLCBzdHJ1Y3Qga3ZtX3Nldl9jbWQgKmFyZ3ApCj4gICAgICAgICAgICAg
ICAgICBpZiAocmV0KQo+ICAgICAgICAgICAgICAgICAgICAgICAgICBnb3RvIGVfZnJlZTsKPgo+
ICsgICAgICAgICAgICAgICBtdXRleF9pbml0KCZzZXYtPmd1ZXN0X3JlcV9sb2NrKTsKPiAgICAg
ICAgICAgICAgICAgIHJldCA9IHNldl9zbnBfaW5pdCgmYXJncC0+ZXJyb3IsIGZhbHNlKTsKPiAg
ICAgICAgICB9IGVsc2Ugewo+ICAgICAgICAgICAgICAgICAgcmV0ID0gc2V2X3BsYXRmb3JtX2lu
aXQoJmFyZ3AtPmVycm9yKTsKPiBAQCAtMjA1OSwyMyArMjA2MCwzNCBAQCBpbnQgc2V2X3ZtX21v
dmVfZW5jX2NvbnRleHRfZnJvbShzdHJ1Y3Qga3ZtICprdm0sIHVuc2lnbmVkIGludCBzb3VyY2Vf
ZmQpCj4gICAgKi8KPiAgIHN0YXRpYyB2b2lkICpzbnBfY29udGV4dF9jcmVhdGUoc3RydWN0IGt2
bSAqa3ZtLCBzdHJ1Y3Qga3ZtX3Nldl9jbWQgKmFyZ3ApCj4gICB7Cj4gKyAgICAgICBzdHJ1Y3Qg
a3ZtX3Nldl9pbmZvICpzZXYgPSAmdG9fa3ZtX3N2bShrdm0pLT5zZXZfaW5mbzsKPiAgICAgICAg
ICBzdHJ1Y3Qgc2V2X2RhdGFfc25wX2FkZHIgZGF0YSA9IHt9Owo+IC0gICAgICAgdm9pZCAqY29u
dGV4dDsKPiArICAgICAgIHZvaWQgKmNvbnRleHQsICpjZXJ0c19kYXRhOwo+ICAgICAgICAgIGlu
dCByYzsKPgo+ICsgICAgICAgLyogQWxsb2NhdGUgbWVtb3J5IHVzZWQgZm9yIHRoZSBjZXJ0cyBk
YXRhIGluIFNOUCBndWVzdCByZXF1ZXN0ICovCj4gKyAgICAgICBjZXJ0c19kYXRhID0ga3phbGxv
YyhTRVZfRldfQkxPQl9NQVhfU0laRSwgR0ZQX0tFUk5FTF9BQ0NPVU5UKTsKPiArICAgICAgIGlm
ICghY2VydHNfZGF0YSkKPiArICAgICAgICAgICAgICAgcmV0dXJuIE5VTEw7Cj4gKwo+ICAgICAg
ICAgIC8qIEFsbG9jYXRlIG1lbW9yeSBmb3IgY29udGV4dCBwYWdlICovCj4gICAgICAgICAgY29u
dGV4dCA9IHNucF9hbGxvY19maXJtd2FyZV9wYWdlKEdGUF9LRVJORUxfQUNDT1VOVCk7Cj4gICAg
ICAgICAgaWYgKCFjb250ZXh0KQo+IC0gICAgICAgICAgICAgICByZXR1cm4gTlVMTDsKPiArICAg
ICAgICAgICAgICAgZ290byBlX2ZyZWU7Cj4KPiAgICAgICAgICBkYXRhLmdjdHhfcGFkZHIgPSBf
X3BzcF9wYShjb250ZXh0KTsKPiAgICAgICAgICByYyA9IF9fc2V2X2lzc3VlX2NtZChhcmdwLT5z
ZXZfZmQsIFNFVl9DTURfU05QX0dDVFhfQ1JFQVRFLCAmZGF0YSwgJmFyZ3AtPmVycm9yKTsKPiAt
ICAgICAgIGlmIChyYykgewo+IC0gICAgICAgICAgICAgICBzbnBfZnJlZV9maXJtd2FyZV9wYWdl
KGNvbnRleHQpOwo+IC0gICAgICAgICAgICAgICByZXR1cm4gTlVMTDsKPiAtICAgICAgIH0KPiAr
ICAgICAgIGlmIChyYykKPiArICAgICAgICAgICAgICAgZ290byBlX2ZyZWU7Cj4gKwo+ICsgICAg
ICAgc2V2LT5zbnBfY2VydHNfZGF0YSA9IGNlcnRzX2RhdGE7Cj4KPiAgICAgICAgICByZXR1cm4g
Y29udGV4dDsKPiArCj4gK2VfZnJlZToKPiArICAgICAgIHNucF9mcmVlX2Zpcm13YXJlX3BhZ2Uo
Y29udGV4dCk7Cj4gKyAgICAgICBrZnJlZShjZXJ0c19kYXRhKTsKPiArICAgICAgIHJldHVybiBO
VUxMOwo+ICAgfQo+Cj4gICBzdGF0aWMgaW50IHNucF9iaW5kX2FzaWQoc3RydWN0IGt2bSAqa3Zt
LCBpbnQgKmVycm9yKQo+IEBAIC0yNjkzLDYgKzI3MDUsOCBAQCBzdGF0aWMgaW50IHNucF9kZWNv
bW1pc3Npb25fY29udGV4dChzdHJ1Y3Qga3ZtICprdm0pCj4gICAgICAgICAgc25wX2ZyZWVfZmly
bXdhcmVfcGFnZShzZXYtPnNucF9jb250ZXh0KTsKPiAgICAgICAgICBzZXYtPnNucF9jb250ZXh0
ID0gTlVMTDsKPgo+ICsgICAgICAga2ZyZWUoc2V2LT5zbnBfY2VydHNfZGF0YSk7Cj4gKwo+ICAg
ICAgICAgIHJldHVybiAwOwo+ICAgfQo+Cj4gQEAgLTMxNTMsNiArMzE2Nyw4IEBAIHN0YXRpYyBp
bnQgc2V2X2VzX3ZhbGlkYXRlX3ZtZ2V4aXQoc3RydWN0IHZjcHVfc3ZtICpzdm0pCj4gICAgICAg
ICAgY2FzZSBTVk1fVk1HRVhJVF9VTlNVUFBPUlRFRF9FVkVOVDoKPiAgICAgICAgICBjYXNlIFNW
TV9WTUdFWElUX0hWX0ZFQVRVUkVTOgo+ICAgICAgICAgIGNhc2UgU1ZNX1ZNR0VYSVRfUFNDOgo+
ICsgICAgICAgY2FzZSBTVk1fVk1HRVhJVF9HVUVTVF9SRVFVRVNUOgo+ICsgICAgICAgY2FzZSBT
Vk1fVk1HRVhJVF9FWFRfR1VFU1RfUkVRVUVTVDoKPiAgICAgICAgICAgICAgICAgIGJyZWFrOwo+
ICAgICAgICAgIGRlZmF1bHQ6Cj4gICAgICAgICAgICAgICAgICByZWFzb24gPSBHSENCX0VSUl9J
TlZBTElEX0VWRU5UOwo+IEBAIC0zMzg0LDYgKzM0MDAsMTQ5IEBAIHN0YXRpYyBpbnQgc25wX2Nv
bXBsZXRlX3BzYyhzdHJ1Y3Qga3ZtX3ZjcHUgKnZjcHUpCj4gICAgICAgICAgcmV0dXJuIDE7Cj4g
ICB9Cj4KPiArc3RhdGljIHVuc2lnbmVkIGxvbmcgc25wX3NldHVwX2d1ZXN0X2J1ZihzdHJ1Y3Qg
dmNwdV9zdm0gKnN2bSwKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IHN0cnVjdCBzZXZfZGF0YV9zbnBfZ3Vlc3RfcmVxdWVzdCAqZGF0YSwKPiArICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdwYV90IHJlcV9ncGEsIGdwYV90IHJlc3BfZ3Bh
KQo+ICt7Cj4gKyAgICAgICBzdHJ1Y3Qga3ZtX3ZjcHUgKnZjcHUgPSAmc3ZtLT52Y3B1Owo+ICsg
ICAgICAgc3RydWN0IGt2bSAqa3ZtID0gdmNwdS0+a3ZtOwo+ICsgICAgICAga3ZtX3Bmbl90IHJl
cV9wZm4sIHJlc3BfcGZuOwo+ICsgICAgICAgc3RydWN0IGt2bV9zZXZfaW5mbyAqc2V2Owo+ICsK
PiArICAgICAgIHNldiA9ICZ0b19rdm1fc3ZtKGt2bSktPnNldl9pbmZvOwo+ICsKPiArICAgICAg
IGlmICghSVNfQUxJR05FRChyZXFfZ3BhLCBQQUdFX1NJWkUpIHx8ICFJU19BTElHTkVEKHJlc3Bf
Z3BhLCBQQUdFX1NJWkUpKQo+ICsgICAgICAgICAgICAgICByZXR1cm4gU0VWX1JFVF9JTlZBTElE
X1BBUkFNOwo+ICsKPiArICAgICAgIHJlcV9wZm4gPSBnZm5fdG9fcGZuKGt2bSwgZ3BhX3RvX2dm
bihyZXFfZ3BhKSk7Cj4gKyAgICAgICBpZiAoaXNfZXJyb3Jfbm9zbG90X3BmbihyZXFfcGZuKSkK
PiArICAgICAgICAgICAgICAgcmV0dXJuIFNFVl9SRVRfSU5WQUxJRF9BRERSRVNTOwo+ICsKPiAr
ICAgICAgIHJlc3BfcGZuID0gZ2ZuX3RvX3Bmbihrdm0sIGdwYV90b19nZm4ocmVzcF9ncGEpKTsK
PiArICAgICAgIGlmIChpc19lcnJvcl9ub3Nsb3RfcGZuKHJlc3BfcGZuKSkKPiArICAgICAgICAg
ICAgICAgcmV0dXJuIFNFVl9SRVRfSU5WQUxJRF9BRERSRVNTOwo+ICsKPiArICAgICAgIGlmIChy
bXBfbWFrZV9wcml2YXRlKHJlc3BfcGZuLCAwLCBQR19MRVZFTF80SywgMCwgdHJ1ZSkpCj4gKyAg
ICAgICAgICAgICAgIHJldHVybiBTRVZfUkVUX0lOVkFMSURfQUREUkVTUzsKPiArCj4gKyAgICAg
ICBkYXRhLT5nY3R4X3BhZGRyID0gX19wc3BfcGEoc2V2LT5zbnBfY29udGV4dCk7Cj4gKyAgICAg
ICBkYXRhLT5yZXFfcGFkZHIgPSBfX3NtZV9zZXQocmVxX3BmbiA8PCBQQUdFX1NISUZUKTsKPiAr
ICAgICAgIGRhdGEtPnJlc19wYWRkciA9IF9fc21lX3NldChyZXNwX3BmbiA8PCBQQUdFX1NISUZU
KTsKPiArCj4gKyAgICAgICByZXR1cm4gMDsKPiArfQo+ICsKPiArc3RhdGljIHZvaWQgc25wX2Ns
ZWFudXBfZ3Vlc3RfYnVmKHN0cnVjdCBzZXZfZGF0YV9zbnBfZ3Vlc3RfcmVxdWVzdCAqZGF0YSwg
dW5zaWduZWQgbG9uZyAqcmMpCj4gK3sKPiArICAgICAgIHU2NCBwZm4gPSBfX3NtZV9jbHIoZGF0
YS0+cmVzX3BhZGRyKSA+PiBQQUdFX1NISUZUOwo+ICsgICAgICAgaW50IHJldDsKPiArCj4gKyAg
ICAgICByZXQgPSBzbnBfcGFnZV9yZWNsYWltKHBmbik7Cj4gKyAgICAgICBpZiAocmV0KQo+ICsg
ICAgICAgICAgICAgICAqcmMgPSBTRVZfUkVUX0lOVkFMSURfQUREUkVTUzsKPiArCj4gKyAgICAg
ICByZXQgPSBybXBfbWFrZV9zaGFyZWQocGZuLCBQR19MRVZFTF80Syk7Cj4gKyAgICAgICBpZiAo
cmV0KQo+ICsgICAgICAgICAgICAgICAqcmMgPSBTRVZfUkVUX0lOVkFMSURfQUREUkVTUzsKPiAr
fQo+ICsKPiArc3RhdGljIHZvaWQgc25wX2hhbmRsZV9ndWVzdF9yZXF1ZXN0KHN0cnVjdCB2Y3B1
X3N2bSAqc3ZtLCBncGFfdCByZXFfZ3BhLCBncGFfdCByZXNwX2dwYSkKPiArewo+ICsgICAgICAg
c3RydWN0IHNldl9kYXRhX3NucF9ndWVzdF9yZXF1ZXN0IGRhdGEgPSB7MH07Cj4gKyAgICAgICBz
dHJ1Y3Qga3ZtX3ZjcHUgKnZjcHUgPSAmc3ZtLT52Y3B1Owo+ICsgICAgICAgc3RydWN0IGt2bSAq
a3ZtID0gdmNwdS0+a3ZtOwo+ICsgICAgICAgc3RydWN0IGt2bV9zZXZfaW5mbyAqc2V2Owo+ICsg
ICAgICAgdW5zaWduZWQgbG9uZyByYzsKPiArICAgICAgIGludCBlcnI7Cj4gKwo+ICsgICAgICAg
aWYgKCFzZXZfc25wX2d1ZXN0KHZjcHUtPmt2bSkpIHsKPiArICAgICAgICAgICAgICAgcmMgPSBT
RVZfUkVUX0lOVkFMSURfR1VFU1Q7Cj4gKyAgICAgICAgICAgICAgIGdvdG8gZV9mYWlsOwo+ICsg
ICAgICAgfQo+ICsKPiArICAgICAgIHNldiA9ICZ0b19rdm1fc3ZtKGt2bSktPnNldl9pbmZvOwo+
ICsKPiArICAgICAgIG11dGV4X2xvY2soJnNldi0+Z3Vlc3RfcmVxX2xvY2spOwo+ICsKPiArICAg
ICAgIHJjID0gc25wX3NldHVwX2d1ZXN0X2J1Zihzdm0sICZkYXRhLCByZXFfZ3BhLCByZXNwX2dw
YSk7Cj4gKyAgICAgICBpZiAocmMpCj4gKyAgICAgICAgICAgICAgIGdvdG8gdW5sb2NrOwo+ICsK
PiArICAgICAgIHJjID0gc2V2X2lzc3VlX2NtZChrdm0sIFNFVl9DTURfU05QX0dVRVNUX1JFUVVF
U1QsICZkYXRhLCAmZXJyKTsKPiArICAgICAgIGlmIChyYykKPiArICAgICAgICAgICAgICAgLyog
dXNlIHRoZSBmaXJtd2FyZSBlcnJvciBjb2RlICovCj4gKyAgICAgICAgICAgICAgIHJjID0gZXJy
OwoKClRoZXJlIGFyZSBjYXNlcyB3aGVyZSBzZXZfaXNzdWVfY21kIGNhbiBmYWlsLCBidXQgbm90
IHNldCBlcnIuIEZvciAKZXhhbXBsZSwgd2hlbiB0aGUgZmlsZSBkZXNjcmlwdG9yIGlzIGluY29y
cmVjdC4gSW4gdGhhdCBjYXNlLCB0aGlzIGNvZGUgCnBhdGggbGVha3MgdW5pbml0aWFsaXplZCBz
dGF0ZSBmcm9tIHRoZSBob3N0IHN0YWNrIChlcnIpIGFsbCB0aGUgd2F5IAppbnRvIGEgZ3Vlc3Qu
CgoKQWxleAoKCgoKQW1hem9uIERldmVsb3BtZW50IENlbnRlciBHZXJtYW55IEdtYkgKS3JhdXNl
bnN0ci4gMzgKMTAxMTcgQmVybGluCkdlc2NoYWVmdHNmdWVocnVuZzogQ2hyaXN0aWFuIFNjaGxh
ZWdlciwgSm9uYXRoYW4gV2Vpc3MKRWluZ2V0cmFnZW4gYW0gQW10c2dlcmljaHQgQ2hhcmxvdHRl
bmJ1cmcgdW50ZXIgSFJCIDE0OTE3MyBCClNpdHo6IEJlcmxpbgpVc3QtSUQ6IERFIDI4OSAyMzcg
ODc5CgoK