Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp3966136rwe; Mon, 17 Apr 2023 06:16:36 -0700 (PDT) X-Google-Smtp-Source: AKy350YL/lX5zs/6JoCXqgf5J5YQrjK8oAxd4H9PAUMH1diHlrP+mvfRlVsIVDDknOmnnW+us02u X-Received: by 2002:a05:6a20:431a:b0:ef:e240:b559 with SMTP id h26-20020a056a20431a00b000efe240b559mr3386285pzk.46.1681737396457; Mon, 17 Apr 2023 06:16:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681737396; cv=none; d=google.com; s=arc-20160816; b=xirOAlw7D8T9di8o6UjjHfs7+i8+aKePXSedKjNIEXcSGYSttflZ3yXkyb/lyVrul2 jg9lxuDPAbnWlI8880vbIu5gPhPQyv2jV9Zgni0I0Qbrq98JJusoMBu4O717P+W/Fhu9 jAp/8/oGFVspYTejCmdKAboB+mEtT1E0WGSJZGiSg/3CMVdI8dtdlTtZrJgktaACFZQr pjcyIQnCSDOjOldLK91Ap31Z++8zLIwuBs/URzmWdPKRMui7WIL0sm2GN0up1WlfFsfX e7VxBxHNsvyDwOXZL0QR8pDay2qMEqZ4A0gi+wSfxs1Cwkr4/nQMLN1z8L8FodlKnmJi YSoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:cc:to:from :subject:message-id; bh=qP3FFZLzyifIt57tt56MF6t4ReH4WRcFy5qw6/U03oM=; b=TQRWrnJq2hn3Hwk9AyMsMf7Ejs/mTQZm4eERyFna8VMgb2zgzHXHxQUm7SJLjddFDc WYKdJUV4NcVt4DndhWn1KjmaDq3nPwj2Fz7rOVIma+c7kCAwCTafbOe0l4TBODmPRFKZ H2OQS3GELpCX0WdF4vvxRu6XQXHQEmecpQBMhPv5tnqPkXjL/WOleifqlJl6rd595YSq BHZx20qCIxs/rgsQ7zXgpaP3y32ZkLRulnv0n8ZdEAaelaM7XmdKhpI3NrqZqYrkp86K oZNa1H9A3NRnlF/A9t71AON6APGrezJTNNY+T8eYhPPq97KfrJxWh1KryfhWM3D7oTpR yVig== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m1-20020a654381000000b00502ea14e6ecsi11137840pgp.712.2023.04.17.06.16.25; Mon, 17 Apr 2023 06:16:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231162AbjDQNMe convert rfc822-to-8bit (ORCPT + 99 others); Mon, 17 Apr 2023 09:12:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231466AbjDQNLz (ORCPT ); Mon, 17 Apr 2023 09:11:55 -0400 Received: from outpost1.zedat.fu-berlin.de (outpost1.zedat.fu-berlin.de [130.133.4.66]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B63011BD7; Mon, 17 Apr 2023 06:11:23 -0700 (PDT) Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost.zedat.fu-berlin.de (Exim 4.95) with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1poOUm-001XyT-HU; Mon, 17 Apr 2023 15:02:12 +0200 Received: from p5b13a017.dip0.t-ipconnect.de ([91.19.160.23] helo=[192.168.178.81]) by inpost2.zedat.fu-berlin.de (Exim 4.95) with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1poOUm-003hGd-9V; Mon, 17 Apr 2023 15:02:12 +0200 Message-ID: <3c188e948506dc97112dcc070cf16e36209c6cc5.camel@physik.fu-berlin.de> Subject: Re: [PATCH v3 16/19] arch/sh: Implement with generic helpers From: John Paul Adrian Glaubitz To: Thomas Zimmermann , arnd@arndb.de, daniel.vetter@ffwll.ch, deller@gmx.de, javierm@redhat.com, gregkh@linuxfoundation.org Cc: linux-arch@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org, Yoshinori Sato , Rich Felker Date: Mon, 17 Apr 2023 15:02:11 +0200 In-Reply-To: <20230417125651.25126-17-tzimmermann@suse.de> References: <20230417125651.25126-1-tzimmermann@suse.de> <20230417125651.25126-17-tzimmermann@suse.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.48.0 MIME-Version: 1.0 X-Original-Sender: glaubitz@physik.fu-berlin.de X-Originating-IP: 91.19.160.23 X-ZEDAT-Hint: PO X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Thomas! On Mon, 2023-04-17 at 14:56 +0200, Thomas Zimmermann wrote: > Replace the architecture's fbdev helpers with the generic > ones from . No functional changes. > > v2: > * use default implementation for fb_pgprotect() (Arnd) > > Signed-off-by: Thomas Zimmermann > Cc: Yoshinori Sato > Cc: Rich Felker > Cc: John Paul Adrian Glaubitz > --- > arch/sh/include/asm/fb.h | 15 +-------------- > 1 file changed, 1 insertion(+), 14 deletions(-) > > diff --git a/arch/sh/include/asm/fb.h b/arch/sh/include/asm/fb.h > index 9a0bca2686fd..19df13ee9ca7 100644 > --- a/arch/sh/include/asm/fb.h > +++ b/arch/sh/include/asm/fb.h > @@ -2,19 +2,6 @@ > #ifndef _ASM_FB_H_ > #define _ASM_FB_H_ > > -#include > -#include > -#include > - > -static inline void fb_pgprotect(struct file *file, struct vm_area_struct *vma, > - unsigned long off) > -{ > - vma->vm_page_prot = pgprot_writecombine(vma->vm_page_prot); > -} Looking at the macro in asm-generic/fb.h, fb_pgprotect() is being replaced with a no-op function. Is that intentional? Can you briefly explain the background for this change? > -static inline int fb_is_primary_device(struct fb_info *info) > -{ > - return 0; > -} > +#include > > #endif /* _ASM_FB_H_ */ Thanks, Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913