Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 17 Apr 2023 10:27:47 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Lorenzo Stoakes <lstoakes@gmail.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Matthew Wilcox <willy@infradead.org>,
        David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH 4/7] mm/gup: introduce the FOLL_SAME_FILE GUP flag
Message-ID: <ZD1JUzCJ7kz46hWX@nvidia.com>
References: <cover.1681508038.git.lstoakes@gmail.com>
 <7ed66bd5243f7535030e0fa6a8a94b76dc5033f1.1681508038.git.lstoakes@gmail.com>
 <ZD1GGiHBOj1mRDu4@nvidia.com>
 <7f9c3ec7-ea79-4f2f-bc23-acc4c11c9620@lucifer.local>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7f9c3ec7-ea79-4f2f-bc23-acc4c11c9620@lucifer.local>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ttSUGaruV005PNbtl26pSYMOxZ6IWtxDoioH8s5MnR4mTKfG4gh2b/bnK1za?=
 =?us-ascii?Q?/8lAVUszccaLGV1U213GrzxeF/nDfrwboq56muEy26veN3mpP4har98xGcWt?=
 =?us-ascii?Q?U/2v+ld0iqKy+AbH7GZWV8sF34H4Kf43VwTih7JTFptpU16RHaQ3v+8qbDPs?=
 =?us-ascii?Q?IGYsicv0tuBKzhCYrrdjyxugNLA81V4UB3yILl3BoRMeqk+Ze40D8ytUqziV?=
 =?us-ascii?Q?tTlCriYmU7VDikpVAV/yCjNx07JuaKw/k9B900lf867ium8AWGZdefp2DKWd?=
 =?us-ascii?Q?que656AlFZzJqDhmn71X5PAmX3FUbu3bnavD84gk9bBi7Sdk+Hcb8D8wfVN9?=
 =?us-ascii?Q?uB25nsbNlG8Bf2sZ531EREXiK48kL6o3uv26aMHk4tlRp+OE+XIzjCvSJlua?=
 =?us-ascii?Q?QrT1p2IE8Jlw9m2Un+45M35YGKAie9bP4SvhGzdAT29h/uTP0mfwYgOj86H8?=
 =?us-ascii?Q?osLD32e8qCeS34ri5rhJFM4eGhKFRCn3ybZS4k6VsLYElOYb9VaMKDny4Jkz?=
 =?us-ascii?Q?Qw8fP1RVaenFPf2mj2y1wFabitqhxziM/vzRHIlxaoqJ5fjZW9iCtHnsP5Fx?=
 =?us-ascii?Q?Kl8mHJ4682KIGXfKTaLSwbPcQVSQ12tnALoK8fAjgLNXnN/E2KrUFzSo+PKy?=
 =?us-ascii?Q?Uhlv1DUbeAoMaDMOOVY4dQD8TcA4HTqTOH4iFZrr4Qrslp15xss6rVQwPWd3?=
 =?us-ascii?Q?py5nmD1xWrHUhvxPJ0neP8rXxZKKknB0MYvzb9hL/Xx1t3j0kvAJwZ1NV20U?=
 =?us-ascii?Q?5xEZ5GaHEyI8PKpczvUjcnMbYOdh6YJzSAywFsF7Gbj147zVzw3TBQMJethY?=
 =?us-ascii?Q?K5ZFIz31BVHSV3IRAmeO9yvE89KgeMT4rUuPyhs3wMoZ5xcMCoVx7985/mws?=
 =?us-ascii?Q?W0+4QbOcT3Sp9nWQZT+Kpl/LwFYy/uhYN6d7UoPMgaxqlBZlQJNKZXUi2SAI?=
 =?us-ascii?Q?ZKEqt2rcRDIttq30XkhauFlUmSz7IGQSC2royHV9uSkil9l9f0TjIxXS7oaX?=
 =?us-ascii?Q?wVe0qsXIAs2b5EyYxaiDZmume10Ycv2u0yKD1VX4TWfhEMwzFfPkku8LPESx?=
 =?us-ascii?Q?ZuSctZ5DisXYHHVkmaSCU3PqIMsw5tthw1VHGsfckB158Iy9vQEVlsMfk4qe?=
 =?us-ascii?Q?s7a7IW0QrsK2QNcTlSk4JknXgo65tdIRjzPunMuEzbpMQNS1LjR8OZ2qGmQu?=
 =?us-ascii?Q?UFGNgasJWDV3O6qJ+HvYMMYw0WUD1KOBSNLpoxA60Hdih6kGWMTBqX5TQ0bk?=
 =?us-ascii?Q?MW8gGX9BEmg6CC7I3D6ndr93Qf3FHnz3qFaJM8PGMRUgMV5aWzPor+Ap9SO0?=
 =?us-ascii?Q?Etjfm7IIJ/ctpeVYOV660GSdOMWzOvvRwIQvCo+NzyR/K4afFs19QSWZc91C?=
 =?us-ascii?Q?NkjB7heFfuLomwzziUpPlzUSybBiAxTEC7TWE9i8HF2rn1sMJHBd6mxoa73Q?=
 =?us-ascii?Q?XPG3TXY3w5OxKcO3oWz0N4/DDcvmx3Me31TQW7MFaf2o7q09qqDS+ztZbD68?=
 =?us-ascii?Q?ndRUbrnsHvERt1FtFpXNjfcAvw1YD+hUSowd6BauiPvQwYgbx/LJaOtNgm1m?=
 =?us-ascii?Q?dBVUhSQoBGdMq78HYI9L8zMoUa40PnXqSDuRR0mQ?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: edcba3bf-8eb1-46a9-5423-08db3f478a70
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2023 13:27:50.2225
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7uNp1exTu+II6N39SthGAYQVeI/HYYa9pAlINMEEyImxAHXmDldID/4OMEU3NPO0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8352
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Apr 17, 2023 at 02:25:54PM +0100, Lorenzo Stoakes wrote:
> On Mon, Apr 17, 2023 at 10:14:02AM -0300, Jason Gunthorpe wrote:
> > On Sat, Apr 15, 2023 at 12:27:40AM +0100, Lorenzo Stoakes wrote:
> > > This flag causes GUP to assert that all VMAs within the input range possess
> > > the same vma->vm_file. If not, the operation fails.
> > >
> > > This is part of a patch series which eliminates the vmas parameter from the
> > > GUP API, implementing the one remaining assertion within the entire kernel
> > > that requires access to the VMAs associated with a GUP range.
> > >
> > > Signed-off-by: Lorenzo Stoakes <lstoakes@gmail.com>
> > > ---
> > >  include/linux/mm_types.h |  2 ++
> > >  mm/gup.c                 | 16 ++++++++++++----
> > >  2 files changed, 14 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h
> > > index 3fc9e680f174..84d1aec9dbab 100644
> > > --- a/include/linux/mm_types.h
> > > +++ b/include/linux/mm_types.h
> > > @@ -1185,6 +1185,8 @@ enum {
> > >  	FOLL_PCI_P2PDMA = 1 << 10,
> > >  	/* allow interrupts from generic signals */
> > >  	FOLL_INTERRUPTIBLE = 1 << 11,
> > > +	/* assert that the range spans VMAs with the same vma->vm_file */
> > > +	FOLL_SAME_FILE = 1 << 12,
> >
> > I hope we don't add this flag, but it needs to be rejected in
> > internal_get_user_pages_fast()
> >
> 
> intenal_get_user_pages_fast() checks against the complement of accepted
> masks, therefore it will reject this as-is unless I'm missing
> something.

Hmm, yes, that looks OK

> As for not adding the flag (an entirely understandable sentiment), it would
> be good to get an insight into the semantics of what you feel would be more
> suitable!

I'm hoping there is not a solid justification for why io_uring is
doing this check so we just delete it.

Jason