Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From:   David Howells <dhowells@redhat.com>
In-Reply-To: <1551344.1681739138@warthog.procyon.org.uk>
References: <1551344.1681739138@warthog.procyon.org.uk> <e8bc6158-86b2-18e5-efea-c165e2a3f196@kernel.dk> <20230413182542.1133335-1-broonie@kernel.org> <0c6b661c-f7ff-cf12-b7f0-00b6b2f1317b@amd.com> <3c4b9025-2667-ca8c-7427-502068b8168e@amd.com>
Cc:     dhowells@redhat.com, Jens Axboe <axboe@kernel.dk>,
        Ayush Jain <ayush.jain3@amd.com>, broonie@kernel.org,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Santosh.Shukla@amd.com, Kalpana.Shetty@amd.com,
        Narasimhan V <Narasimhan.V@amd.com>, sfr@canb.auug.org.au
Subject: Re: linux-next: Tree for Apr 13
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1558439.1681740407.1@warthog.procyon.org.uk>
Content-Transfer-Encoding: quoted-printable
Date:   Mon, 17 Apr 2023 15:06:47 +0100
Message-ID: <1558440.1681740407@warthog.procyon.org.uk>
To:     unlisted-recipients:; (no To-header on input)
Precedence: bulk

David Howells <dhowells@redhat.com> wrote:

> The problem might be summed up by the following snippet:
> =

> 	openat(AT_FDCWD, "/dev/loop0", O_RDONLY) =3D 3
> 	newfstatat(3, "", {st_mode=3DS_IFBLK|0660, st_rdev=3Dmakedev(0x7, 0), .=
..}, AT_EMPTY_PATH) =3D 0
> 	splice(3, NULL, 1, NULL, 1048576, 0)    =3D 0

Ah.  In filemap_splice_read():

	do {
		cond_resched();

		if (*ppos >=3D i_size_read(file_inode(in)))
			break;

but i_size_read(file_inode(in)) for a blockdev returns 0, it would seem.  =
What
should I use instead?

David