Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <quic_kvalo@quicinc.com>
To:     Dan Carpenter <error27@gmail.com>
CC:     <oe-kbuild@lists.linux.dev>,
        Manikanta Pubbisetty <quic_mpubbise@quicinc.com>,
        <lkp@intel.com>, <oe-kbuild-all@lists.linux.dev>,
        <linux-kernel@vger.kernel.org>, <ath11k@lists.infradead.org>
Subject: Re: drivers/net/wireless/ath/ath11k/core.c:1309
 ath11k_core_qmi_firmware_ready() warn: missing unwind goto?
References: <b559bd3c-c7c2-409e-ab36-455236572fe5@kili.mountain>
Date:   Mon, 17 Apr 2023 17:40:35 +0300
In-Reply-To: <b559bd3c-c7c2-409e-ab36-455236572fe5@kili.mountain> (Dan
        Carpenter's message of "Sat, 15 Apr 2023 14:37:42 +0300")
Message-ID: <87sfcy4lng.fsf@kvalo10.eu.qualcomm.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

+ ath11k list

Including the full report below.

Kalle

Dan Carpenter <error27@gmail.com> writes:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   7a934f4bd7d6f9da84c8812da3ba42ee10f5778e
> commit: 33b67a4b4e64275b6f2cbc4318f1596c70659111 ath11k: Update WBM idle ring HP after FW mode on
> config: openrisc-randconfig-m041-20230414
> (https://download.01.org/0day-ci/archive/20230415/202304151955.oqAetVFd-lkp@intel.com/config)
> compiler: or1k-linux-gcc (GCC) 12.1.0
>
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
> | Reported-by: Dan Carpenter <error27@gmail.com>
> | Link: https://lore.kernel.org/r/202304151955.oqAetVFd-lkp@intel.com/
>
> smatch warnings:
> drivers/net/wireless/ath/ath11k/core.c:1309 ath11k_core_qmi_firmware_ready() warn: missing unwind goto?
>
> vim +1309 drivers/net/wireless/ath/ath11k/core.c
>
> d5c65159f28953 Kalle Valo 2019-11-23 1276 int
> ath11k_core_qmi_firmware_ready(struct ath11k_base *ab)
> d5c65159f28953 Kalle Valo                2019-11-23  1277  {
> d5c65159f28953 Kalle Valo                2019-11-23  1278  	int ret;
> d5c65159f28953 Kalle Valo                2019-11-23  1279  
> 33b67a4b4e6427 Manikanta Pubbisetty 2022-04-06 1280 ret =
> ath11k_core_start_firmware(ab, ATH11K_FIRMWARE_MODE_NORMAL);
> 33b67a4b4e6427 Manikanta Pubbisetty      2022-04-06  1281  	if (ret) {
> 33b67a4b4e6427 Manikanta Pubbisetty 2022-04-06 1282 ath11k_err(ab,
> "failed to start firmware: %d\n", ret);
> 33b67a4b4e6427 Manikanta Pubbisetty      2022-04-06  1283  		return ret;
> 33b67a4b4e6427 Manikanta Pubbisetty      2022-04-06  1284  	}
> 33b67a4b4e6427 Manikanta Pubbisetty      2022-04-06  1285  
> d5c65159f28953 Kalle Valo                2019-11-23  1286  	ret = ath11k_ce_init_pipes(ab);
> d5c65159f28953 Kalle Valo                2019-11-23  1287  	if (ret) {
> d5c65159f28953 Kalle Valo 2019-11-23 1288 ath11k_err(ab, "failed to
> initialize CE: %d\n", ret);
> 33b67a4b4e6427 Manikanta Pubbisetty      2022-04-06  1289  		goto err_firmware_stop;
> d5c65159f28953 Kalle Valo                2019-11-23  1290  	}
> d5c65159f28953 Kalle Valo                2019-11-23  1291  
> d5c65159f28953 Kalle Valo                2019-11-23  1292  	ret = ath11k_dp_alloc(ab);
> d5c65159f28953 Kalle Valo                2019-11-23  1293  	if (ret) {
> d5c65159f28953 Kalle Valo 2019-11-23 1294 ath11k_err(ab, "failed to
> init DP: %d\n", ret);
> 33b67a4b4e6427 Manikanta Pubbisetty      2022-04-06  1295  		goto err_firmware_stop;
> d5c65159f28953 Kalle Valo                2019-11-23  1296  	}
> d5c65159f28953 Kalle Valo                2019-11-23  1297  
> aa2092a9bab3f8 Venkateswara Naralasetty  2020-09-08  1298  	switch (ath11k_crypto_mode) {
> aa2092a9bab3f8 Venkateswara Naralasetty  2020-09-08  1299  	case ATH11K_CRYPT_MODE_SW:
> aa2092a9bab3f8 Venkateswara Naralasetty 2020-09-08 1300
> set_bit(ATH11K_FLAG_HW_CRYPTO_DISABLED, &ab->dev_flags);
> aa2092a9bab3f8 Venkateswara Naralasetty 2020-09-08 1301
> set_bit(ATH11K_FLAG_RAW_MODE, &ab->dev_flags);
> aa2092a9bab3f8 Venkateswara Naralasetty  2020-09-08  1302  		break;
> aa2092a9bab3f8 Venkateswara Naralasetty  2020-09-08  1303  	case ATH11K_CRYPT_MODE_HW:
> aa2092a9bab3f8 Venkateswara Naralasetty 2020-09-08 1304
> clear_bit(ATH11K_FLAG_HW_CRYPTO_DISABLED, &ab->dev_flags);
> aa2092a9bab3f8 Venkateswara Naralasetty 2020-09-08 1305
> clear_bit(ATH11K_FLAG_RAW_MODE, &ab->dev_flags);
> aa2092a9bab3f8 Venkateswara Naralasetty  2020-09-08  1306  		break;
> aa2092a9bab3f8 Venkateswara Naralasetty  2020-09-08  1307  	default:
> aa2092a9bab3f8 Venkateswara Naralasetty 2020-09-08 1308
> ath11k_info(ab, "invalid crypto_mode: %d\n", ath11k_crypto_mode);
> aa2092a9bab3f8 Venkateswara Naralasetty  2020-09-08 @1309  		return -EINVAL;
>
> 	ret = -EINVAL;
> 	goto err_dp_free;
>
> aa2092a9bab3f8 Venkateswara Naralasetty  2020-09-08  1310  	}
> aa2092a9bab3f8 Venkateswara Naralasetty  2020-09-08  1311  
> aa2092a9bab3f8 Venkateswara Naralasetty  2020-09-08  1312  	if (ath11k_frame_mode == ATH11K_HW_TXRX_RAW)
> aa2092a9bab3f8 Venkateswara Naralasetty 2020-09-08 1313
> set_bit(ATH11K_FLAG_RAW_MODE, &ab->dev_flags);
> aa2092a9bab3f8 Venkateswara Naralasetty  2020-09-08  1314  
> d5c65159f28953 Kalle Valo                2019-11-23  1315  	mutex_lock(&ab->core_lock);
> 33b67a4b4e6427 Manikanta Pubbisetty      2022-04-06  1316  	ret = ath11k_core_start(ab);
> d5c65159f28953 Kalle Valo                2019-11-23  1317  	if (ret) {
> d5c65159f28953 Kalle Valo 2019-11-23 1318 ath11k_err(ab, "failed to
> start core: %d\n", ret);
> d5c65159f28953 Kalle Valo                2019-11-23  1319  		goto err_dp_free;
> d5c65159f28953 Kalle Valo                2019-11-23  1320  	}
> d5c65159f28953 Kalle Valo                2019-11-23  1321  
> d5c65159f28953 Kalle Valo                2019-11-23  1322  	ret = ath11k_core_pdev_create(ab);
> d5c65159f28953 Kalle Valo                2019-11-23  1323  	if (ret) {
> d5c65159f28953 Kalle Valo 2019-11-23 1324 ath11k_err(ab, "failed to
> create pdev core: %d\n", ret);
> d5c65159f28953 Kalle Valo                2019-11-23  1325  		goto err_core_stop;
> d5c65159f28953 Kalle Valo                2019-11-23  1326  	}
> 31858805f91ac7 Govind Singh              2020-05-08  1327  	ath11k_hif_irq_enable(ab);
> ec038c6127fa77 Wen Gong                  2021-12-20  1328  
> ec038c6127fa77 Wen Gong                  2021-12-20  1329  	ret = ath11k_core_rfkill_config(ab);
> ec038c6127fa77 Wen Gong                  2021-12-20  1330  	if (ret && ret != -EOPNOTSUPP) {
> ec038c6127fa77 Wen Gong 2021-12-20 1331 ath11k_err(ab, "failed to
> config rfkill: %d\n", ret);
> ec038c6127fa77 Wen Gong                  2021-12-20  1332  		goto err_core_stop;
> ec038c6127fa77 Wen Gong                  2021-12-20  1333  	}
> ec038c6127fa77 Wen Gong                  2021-12-20  1334  
> d5c65159f28953 Kalle Valo                2019-11-23  1335  	mutex_unlock(&ab->core_lock);
> d5c65159f28953 Kalle Valo                2019-11-23  1336  
> d5c65159f28953 Kalle Valo                2019-11-23  1337  	return 0;
> d5c65159f28953 Kalle Valo                2019-11-23  1338  
> d5c65159f28953 Kalle Valo                2019-11-23  1339  err_core_stop:
> d5c65159f28953 Kalle Valo                2019-11-23  1340  	ath11k_core_stop(ab);
> 0366f42640a410 Vasanthakumar Thiagarajan 2019-11-28  1341  	ath11k_mac_destroy(ab);
> d5c65159f28953 Kalle Valo                2019-11-23  1342  err_dp_free:
> d5c65159f28953 Kalle Valo                2019-11-23  1343  	ath11k_dp_free(ab);
> ba47923974fb67 Govindaraj Saminathan     2019-11-27  1344  	mutex_unlock(&ab->core_lock);
> 33b67a4b4e6427 Manikanta Pubbisetty      2022-04-06  1345  err_firmware_stop:
> 33b67a4b4e6427 Manikanta Pubbisetty      2022-04-06  1346  	ath11k_qmi_firmware_stop(ab);
> 33b67a4b4e6427 Manikanta Pubbisetty      2022-04-06  1347  
> d5c65159f28953 Kalle Valo                2019-11-23  1348  	return ret;
> d5c65159f28953 Kalle Valo                2019-11-23  1349  }
> d5c65159f28953 Kalle Valo                2019-11-23  1350