Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 17 Apr 2023 10:58:20 -0400
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     David Binderman <dcb314@hotmail.com>
Cc:     Peng Zhang <zhangpeng.00@bytedance.com>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>
Subject: Re: linux-6.3-rc6/lib/maple_tree.c: Two style issues
Message-ID: <20230417145820.nzmxs42m67pyxpnd@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
        David Binderman <dcb314@hotmail.com>,
        Peng Zhang <zhangpeng.00@bytedance.com>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>
References: <DB6P189MB0568CB290411B23A176511239C959@DB6P189MB0568.EURP189.PROD.OUTLOOK.COM>
 <cd5b6ce1-3c2f-97f5-64c5-4c4c90c40627@bytedance.com>
 <DB6P189MB0568A487A016FBA45DF108A89C959@DB6P189MB0568.EURP189.PROD.OUTLOOK.COM>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <DB6P189MB0568A487A016FBA45DF108A89C959@DB6P189MB0568.EURP189.PROD.OUTLOOK.COM>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?LfAFRrhto3xTYAv3zbawmtNlniQx2YyrkkRgGRyPqfONwEcyHsuSNdj+Ki?=
 =?iso-8859-1?Q?G3iVm7AiA8KGhiCgsWMw7HbmrFaVfFBnua4GKILUnQRtS2VGJD2zghaJdJ?=
 =?iso-8859-1?Q?oXAJU7gY8eD9tu4KMMCWc4NfrEeltDnra7Yec2tzqEFIvxyBs3xU8dAYMS?=
 =?iso-8859-1?Q?JYdQVqyP12NHI24H7m6z4mMZMznSqCJMs0/f/rLqKgrqzQPsha0NxrkAxX?=
 =?iso-8859-1?Q?ya0/eThGrr53a+gQGe1PZkKVBPDgTUelpc1a6yP0m8ZGZ0dH2cYBP4euFC?=
 =?iso-8859-1?Q?kBH0jIQ9PnXTzj3YFcc8+le9sqWMBseB3dsLtY2dnDxBVy4nx8ont+t2jA?=
 =?iso-8859-1?Q?FF2wUUsnnlwU73Aym6hnFIxcBa1T71/0jFm8uuLT8dbqCRrileFvtXtu0a?=
 =?iso-8859-1?Q?2Mz6qZ70Xi0334n9WFzYG7gQAraAQe/H5Gs2+I57mKmFY0qJTzZv/0Taxn?=
 =?iso-8859-1?Q?smWoRPrcF1Zb076i02milzXBktp6IyjB4sRlCqNCCdY5A/FU10qwFH5I6m?=
 =?iso-8859-1?Q?yLBzdoMjTIll5mENjdR+mV5IbX9bXMVB2ox9zxoM9aqrgj1EHYS34BJ9m6?=
 =?iso-8859-1?Q?pvDXGjqBdWuPxHolNpyW1NqPKQLy3qLeyxF2PchRzuHnMzk90jucZBbNIr?=
 =?iso-8859-1?Q?aI+6T+RJHaVv9DmBnou7hql/tbjO+V2ZLAYqh3/vvykISr4xUzJGnzips7?=
 =?iso-8859-1?Q?PNZQhG5JNs1+foTrlbIXh44tspwLEzRUl58GBd/3dE7AULg/xy8lEEYCI/?=
 =?iso-8859-1?Q?m4csOLZhMhuu18kxvHRkBmlD7G9lRo9sLcM6bLr/0QTACyxR/rRumMjAZn?=
 =?iso-8859-1?Q?JMjg/j6XGNB0VFgwYKYTavn6dcap7cpARAp91Yt/AUR0eyNMPJM50tF+o7?=
 =?iso-8859-1?Q?isZ76NyF2HV1OajsS1fsq5r+s55cFm1XexLq8QH4yVLn3MVOgPMzHWX0FS?=
 =?iso-8859-1?Q?CVQDQz9pAR6DCpOsS48UIDr7maC9GGNWQ9T30CEIT3EfEDsVDN03Ki4J45?=
 =?iso-8859-1?Q?r5jhnLlNCDP/OVYBMH1b3eozw9I5Z8D8dBwRWOUzjrJRaF2XND60XLZ/fL?=
 =?iso-8859-1?Q?DpbrD60OSV9LOjNAmvlMVn7kzh0mE3zAShrkSN4HfDuZqsslzp6d+qOeGK?=
 =?iso-8859-1?Q?XLbPMS6Ml1Y6hlKswzjI/L2swZ3YljSzB0FfcprJxZpl2MvYdKJ9hTzOnm?=
 =?iso-8859-1?Q?0e/ZWAV33AMIO0Ad4sWj0SXvbvnUFNifJ/yFfkOStt+qGcKeOc+X2IYqch?=
 =?iso-8859-1?Q?BDpfYqhIBvsPIHA72Riby+Y1KBVdLs4Q+RG5Qq2T/F8SLDZysEyLE+tr0d?=
 =?iso-8859-1?Q?JLwoZotUfOywFm/p+RgiyZQvR/LUlnncTAFmhZqJtIYcrLkVq0rWULVzjq?=
 =?iso-8859-1?Q?zKVtiFNlhHToa0iLi8/tTJ177ZI6JS0K5p84YMceDcjed3rILzRJ1yvird?=
 =?iso-8859-1?Q?Y0n5L0ybpDmTNDwbphe+Bcq5wIe06U5dVJvYUmNuPnnUQ+FrB0d4xuvgzH?=
 =?iso-8859-1?Q?R+Bqn9tkr1pDaHOIMEKhXBcmWN1CS32T6oWjN+efprCpguMcqMI27Hn+Ud?=
 =?iso-8859-1?Q?PxsHuTgsV/07/e9AO8luSeYnwQ18T/Xj2Q3+eUao5HyMzWlYE6N/xC5akp?=
 =?iso-8859-1?Q?sNlWRIU+f5mA/U/4EaKqExlc6Z8QWFZQ6w?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Coh05Vp4PSqzVZGM/k4FNZkL9DZ320XNXbXi7irOt+D3b/vZMCy4BFcYQdKqwqv3LsbqOrH1Ve4TFiTU2SO2p1ggnofBY/uilmkKXUd12sGcYLOtgUWZmMgvzMejqYPVE+1y9wYueORLro49DY/PwiR0ad6ejLDmJ2JjbNJ01eOWL1SEAtud3j4FZXOg/M1jtzN3Uf0ZrYDQMyVpOk+VMSwSxNve++n6wIh5B4c9ySHb4L13gTRccovctnTsnDvfYHJhU6J7wZDE+85nN6X4w2yu4n3Z/bGwpNfPju27AqKlrfs1A9wciFHxAx8CKGfBSm0jvFVpCYO47yrtLW05K77hVyeGknGCVZcdIxFYHhiNZygkRRIF65nyhpW0FFJnXCxsdtn6Tp2LKaZECijmIWFecCLI74JBgJfoNLvGb52zCHAf307DDD4qxrlfRG168VX7bh2/GkDS9H9v6ffjReoDP96HfO6RSHwmhCOU7SiIaKHPoWG/oKpIyVs+f4+dng2PKgLDXO+QByuWJgMjUedPGdUi7reO5I6mgkR3iKi5xVAIL13rmSBsthrznwxUahgpRCwJ0lcf6ouAN2SZSJttZ4JUyOltr0JoQbQizMGOKAL7zns7VcR7Ocu9EzC3pKH+KBFff4P5/3Kwl4NeLXXdocvUeNS0AEzQUzONqFemnGLkbYZGURYTT4B/FCJ2n4VLrP5ledM0Mk3cKOA8z9OGLQIawo1bYIBr7SVN+PeRHtdYXBIUDJqQ8liZmspU/bxrIs77eaAlvWv9v2+vqxzF9/Fn1SoFnyWbogWgJLS55gAcB4rTQPHKKsoBevrCbYUQ1Ghag03taIpnyYN4JXpoYOC9zyYE8uaQ5t9gX7CLIBshmSSwAIj4YJQwR0SqNr+WoB1rrjgv5lqE/riRqms3rm6trlbgVpHkK60O30k=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 783d316e-adf7-4bc4-885e-08db3f543097
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2023 14:58:22.9183
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bcXMlUC8WEn9N/XcXKm8X2fXjcDWWN5D2s0WUb5iKAVFGoCIaH81hejuZcqrEgHx/dzU2v8Lv8OrEvGOI3Xzxw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB5810
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-17_10,2023-04-17_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=506 adultscore=0
 phishscore=0 malwarescore=0 spamscore=0 bulkscore=0 suspectscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2303200000 definitions=main-2304170135
X-Proofpoint-GUID: _i77lhnFp-0YUboG-JVDlU0Ql_NJ_bg9
X-Proofpoint-ORIG-GUID: _i77lhnFp-0YUboG-JVDlU0Ql_NJ_bg9
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* David Binderman <dcb314@hotmail.com> [230417 10:23]:
> Hello there,
>=20
> >It should be fine here.=20
>=20
> Perhaps I have been slightly less than clear. The discussion is about the=
 *style*
> of the code, *not* whether it works or not. My apologies for the lack of =
clarity.=20
>=20
> Expression is
>=20
>     while (A &&
>         B && C)
>=20
> The static analyser notices it is poor style to have B do a limit check, =
but have A use it.
> Sure its working code, but suggest new code
>=20
>     while (B && A && C)
>=20
> It won't make much difference to the code, it will merely be better style=
.
>=20
> 2.
>=20
> >> Source code is
> >>
> >>=A0 =A0 =A0 =A0 =A0 =A0 =A0memset(pivs + tmp, 0,
> >>=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0sizeof(unsigned long *) * (m=
ax_p - tmp));
>=20
> >It's not good here, I can fix it.
>=20
> sizeof( pivs[ 0]) is a better thing to say than sizeof( unsigned long).=20
> There is reduced future maintenance burden, when the type of *pivs change=
s.
>=20

If you want to make the code better, then send a patch.  It is very
frustrating to try and decode a compilers output over email and be told
it wasn't decoded to your liking.

This is far more of a maintenance burden than the code you are trying to ch=
ange.