Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp4121203rwe; Mon, 17 Apr 2023 08:13:47 -0700 (PDT) X-Google-Smtp-Source: AKy350Z8NueoOAzS2/DaAZ5v9ViQEIIARP1YoH2iCJ8ZdACjx2gpXhzYxVFg5iViZ0MaoCyYAlq8 X-Received: by 2002:a17:902:c246:b0:1a1:b137:4975 with SMTP id 6-20020a170902c24600b001a1b1374975mr12749531plg.49.1681744427409; Mon, 17 Apr 2023 08:13:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681744427; cv=none; d=google.com; s=arc-20160816; b=a7jkdz6huYmZJjHr/Jv0OtHIMkadFRIA48qeBJFwTb2QfbthfWCBEE+m4gXN5jEyLZ BdH6IjRS3gJCvGtAAwEuPpJESndr/VTykPksEkGJeKl/InegaUx/Y+Q+X2cNsK5pqTvC hVGg9P4nfHiR644GoLtKPgOOhag1LiTwafCNlWyVGRibo8KrnS4n08Y5WFqriC8g9hgN LCn+RBgIKE7ghMRmvCm1vEqQdGNEaanYa3W1y/PVP+kKAJ8olJAOACfwx+laX66mDs6u HvPakwPjN74sTxb0M5mse7nA/+1VgshdCxd2GQStfu6IQJsSSkuNLYAYu6XRx5rSJQLF gn9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:content-transfer-encoding:mime-version :message-id:date:subject:from:dkim-signature; bh=a+xLyO8qvgWw2ePZz1YlhZXXFp5nOZ6JgIcQf/Zm/pY=; b=ebKgBpT/m1c6VdBUoaKlZA1S2EYJsXzR589ht0q4Hi6j/JmnOiF56TkD0344QisbC6 T0Cs5rmsqOjyVYxI4cPYtvK5hrmIQ0yXI5vQa9oXc/V6ddJUWFZGPNaRFemorT/yR85k fJW6usN2KwAJkWFlukEuUx+JwsB+TP5sYayVfhBzuYKFhesDygr/lZl2nZct+kLMn81K x+MRUYB+OzCO1nKLHsTZNQfkp+w8Brv8HOwJ6In36SC4iKGSb13kVIlX+56GBoFn9vuc xfk3SYlZTWcjnoaujYnCHE26I18PUKVaLdVjRh/ypjRWjaib7oJvxwQ/ad7kU0gN+0ky m6XA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FJPp7X4z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u4-20020a17090282c400b001a6d77dc6adsi2988652plz.371.2023.04.17.08.13.35; Mon, 17 Apr 2023 08:13:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FJPp7X4z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230168AbjDQPLl (ORCPT + 99 others); Mon, 17 Apr 2023 11:11:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231288AbjDQPL1 (ORCPT ); Mon, 17 Apr 2023 11:11:27 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADBA57ED8; Mon, 17 Apr 2023 08:11:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 37958621FB; Mon, 17 Apr 2023 15:11:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2375C433EF; Mon, 17 Apr 2023 15:11:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681744279; bh=P/QoeHAKZ55pby10GX/9bO6MW7hatN7F+qitfvgXnRE=; h=From:Subject:Date:To:Cc:From; b=FJPp7X4zdL6Va3+6pJ4YZPL7NSqwB631FyG24irKLeOIieUVWibRtdAGxhf4A+pF0 IRTNFSXMp0qeEroftwH601Z7yOYJoqIutvYYZNi+Ou1wEEC+pQwC9jBGDj6r3meO1x JfqudXjZtQ5DKLmTnu6reDsGf2w3H1YpRniLFV6b+GE3kJzoNos1qbABVISUFYskNy XZTuysiPKUV5GfBC0Z448JmJe5xswnctbPLFenRMxJeGTgqvq74uO2gWEo+JHEOIA8 ulq9i1clgvzfl+FEUfEPxP5AlO4F8Wo3NHWimpP+hBz30YZHz2LeBK4wf1d+But4UA gLhQzFWnHFUSA== From: Simon Horman Subject: [PATCH nf-next v3 0/4] ipvs: Cleanups for v6.4 Date: Mon, 17 Apr 2023 17:10:44 +0200 Message-Id: <20230409-ipvs-cleanup-v3-0-5149ea34b0b9@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAHRhPWQC/32Nyw6CMBREf4V0bU25oIAr/8O46OMCjc2FtNBgC P9u052JcTkzOXN2FtBbDOxW7MxjtMFOlEJ1KpgeJQ3IrUmZgYBK1KLjdo6Ba4eS1pkr3ckLSGg quLKEKBmQKy9Jjwmi1blUzh57u2XHg1HPCbeFPdMw2rBM/p3dsczzb00sueBdq42GGnpU4v5CT +jOkx/yU4R/NCQaRK1N2RjZiPaLPo7jAywovkcFAQAA To: Julian Anastasov Cc: Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , netdev@vger.kernel.org, "David S. Miller" , David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni , lvs-devel@vger.kernel.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, Horatiu Vultur X-Mailer: b4 0.12.2 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Julian, this series aims to clean up IPVS in several ways without implementing any functional changes, aside from removing some debugging output. Patch 1/4: Update width of source for ip_vs_sync_conn_options The operation is safe, use an annotation to describe it properly. Patch 2/4: Consistently use array_size() in ip_vs_conn_init() It seems better to use helpers consistently. Patch 3/4: Remove {Enter,Leave}Function These seem to be well past their use-by date. Patch 4/4: Correct spelling in comments I can't spell. But codespell helps me these days. All changes: compile tested only! --- Changes in v3: - Patch 2/4: Correct division by 1024. It was applied to the wrong variable in v2. - Add Horatiu's Reviewed-by tag. Changes in v2: - Patch 1/4: Correct spelling of 'conn' in subject. - Patch 2/4: Restore division by 1024. It was lost on v1. --- Simon Horman (4): ipvs: Update width of source for ip_vs_sync_conn_options ipvs: Consistently use array_size() in ip_vs_conn_init() ipvs: Remove {Enter,Leave}Function ipvs: Correct spelling in comments include/net/ip_vs.h | 32 +++++---------------- net/netfilter/ipvs/ip_vs_conn.c | 12 ++++---- net/netfilter/ipvs/ip_vs_core.c | 8 ------ net/netfilter/ipvs/ip_vs_ctl.c | 26 +---------------- net/netfilter/ipvs/ip_vs_sync.c | 7 +---- net/netfilter/ipvs/ip_vs_xmit.c | 62 ++++++----------------------------------- 6 files changed, 23 insertions(+), 124 deletions(-) base-commit: 99676a5766412f3936c55b9d18565d248e5463ee