Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 17 Apr 2023 20:14:17 +0200
From:   Borislav Petkov <bp@alien8.de>
To:     Willy Tarreau <w@1wt.eu>
Cc:     Jingbo Xu <jefflexu@linux.alibaba.com>, tglx@linutronix.de,
        mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org,
        hpa@zytor.com,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [BUG REPORT] arch/x86/include/asm/uaccess_64.h:119: Error: junk
 at end of line
Message-ID: <20230417181417.GHZD2MeRSuMWUPEU3V@fat_crate.local>
References: <a9aae568-3046-306c-bd71-92c1fc8eeddc@linux.alibaba.com>
 <20230314102316.GAZBBLFHKqQr9RSeM+@fat_crate.local>
 <ZDrlMfy+OcDjXwvn@1wt.eu>
 <E8CB02C5-E18C-42F6-93D8-2CC7CB4CB3FF@alien8.de>
 <ZDuzlNOmIT0Gd7fF@1wt.eu>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <ZDuzlNOmIT0Gd7fF@1wt.eu>
Precedence: bulk

On Sun, Apr 16, 2023 at 10:36:36AM +0200, Willy Tarreau wrote:
> ...
> So it just means that the support for the "U" suffix on numbers was
> added in binutils 2.27 and the "L" suffix on numbers was added somewhere
> between 2.27 and 2.29.

Thanks for that - I'd like to document this once I've hashed out with
the toolchain person the proper binutils versions which got this
support. But that'll come later.

> And given that there's a single occurrence of all this in the whole tree,
> that's why I'm proposing to just get back to the good old (1 << 0) instead
> of BIT(0).

Yeah, we have those UC() macro things but they don't work in inline asm
in C code. So yeah, pls do the thing you're suggesting.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette