Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <202304171611545861530@zte.com.cn>
In-Reply-To: <202304171611545861530@zte.com.cn>
From:   Suren Baghdasaryan <surenb@google.com>
Date:   Mon, 17 Apr 2023 12:04:08 -0700
Message-ID: <CAJuCfpFiW7z01FTC2q3hR+h=MhWLwKj96U+MF3s_FjX-9JEqfw@mail.gmail.com>
Subject: Re: [PATCH linux-next] sched/psi: avoid unnecessary resetting min
 update period when destroy trigger
To:     yang.yang29@zte.com.cn
Cc:     hannes@cmpxchg.org, mingo@redhat.com, linux-kernel@vger.kernel.org,
        juri.lelli@redhat.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Apr 17, 2023 at 1:12=E2=80=AFAM <yang.yang29@zte.com.cn> wrote:
>
> From: Yang Yang <yang.yang19@zte.com.cn>
>
> Psi_group's poll_min_period is determined by the min window size of
> psi_trigger when creating new triggers. While destroying a psi_trigger,
> there is no need to reset poll_min_period if the destroying psi_trigger
> not had the min windows size, since in this condition poll_min_period
> will keep the same as before.

Nice optimization.

>
> Signed-off-by: Yang Yang <yang.yang29@zte.com.cn>

Acked-by: Suren Baghdasaryan <surenb@google.com>

> ---
>  kernel/sched/psi.c | 15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
> index 02e011cabe91..12869585cf89 100644
> --- a/kernel/sched/psi.c
> +++ b/kernel/sched/psi.c
> @@ -1359,11 +1359,16 @@ void psi_trigger_destroy(struct psi_trigger *t)
>                 group->nr_triggers[t->state]--;
>                 if (!group->nr_triggers[t->state])
>                         group->poll_states &=3D ~(1 << t->state);
> -               /* reset min update period for the remaining triggers */
> -               list_for_each_entry(tmp, &group->triggers, node)
> -                       period =3D min(period, div_u64(tmp->win.size,
> -                                       UPDATES_PER_WINDOW));
> -               group->poll_min_period =3D period;
> +               /*
> +                * Reset min update period for the remaining triggers iff=
 the destroying
> +                * trigger had the min window size.
> +                */
> +               if (group->poll_min_period =3D=3D div_u64(t->win.size, UP=
DATES_PER_WINDOW)) {
> +                       list_for_each_entry(tmp, &group->triggers, node)
> +                               period =3D min(period, div_u64(tmp->win.s=
ize,
> +                                               UPDATES_PER_WINDOW));
> +                       group->poll_min_period =3D period;
> +               }
>                 /* Destroy poll_task when the last trigger is destroyed *=
/
>                 if (group->poll_states =3D=3D 0) {
>                         group->polling_until =3D 0;
> --
> 2.25.1