Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <17bbab58-3cde-e980-bdeb-b9de65848b2e@suse.cz>
Date:   Mon, 17 Apr 2023 21:02:22 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v2 2/2] mm/slab: break up RCU readers on
 SLAB_TYPESAFE_BY_RCU example code
Content-Language: en-US
To:     SeongJae Park <sj@kernel.org>, Matthew Wilcox <willy@infradead.org>
Cc:     akpm@linux-foundation.org, paulmck@kernel.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <20230417190129.1454-1-sj@kernel.org>
From:   Vlastimil Babka <vbabka@suse.cz>
In-Reply-To: <20230417190129.1454-1-sj@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/17/23 21:01, SeongJae Park wrote:
> On Mon, 17 Apr 2023 18:53:24 +0100 Matthew Wilcox <willy@infradead.org> wrote:
> 
>> On Mon, Apr 17, 2023 at 05:26:57PM +0000, SeongJae Park wrote:
>> > Hi Vlastimil,
>> > 
>> > On Mon, 17 Apr 2023 13:05:40 +0200 Vlastimil Babka <vbabka@suse.cz> wrote:
>> > 
>> > > On 4/15/23 05:31, SeongJae Park wrote:
>> > > > The SLAB_TYPESAFE_BY_RCU example code snippet is having not tiny RCU
>> > > 
>> > > Since "tiny RCU" means something quite specific in the RCU world, it can be
>> > > confusing to read it in this sense. We could say e.g. "... snippet uses a
>> > > single RCU read-side critical section for retries"?
>> > 
>> > Looks much better, thank you for this suggestion!
>> > 
>> > > 
>> > > > read-side critical section.  'Documentation/RCU/rculist_nulls.rst' has
>> > > > similar example code snippet, and commit da82af04352b ("doc: Update and
>> > > > wordsmith rculist_nulls.rst") has broken it.
>> > > 
>> > > "has broken it" has quite different meaning than "has broken it up" :) I
>> > > guess we could just add the "up", unless someone has an even better wording.
>> > 
>> > Good point, thank you for your suggestion!
>> > 
>> > I will apply above suggestion on the next spin.
>> 
>> For the last one, perhaps changing the tense would have more clarity:
>> 
>> similar example code snippet, and commit da82af04352b ("doc: Update and
>> wordsmith rculist_nulls.rst") broke it up.
> 
> Thank you for this suggestion, Matthew!  Will send a new version.

It's ok, I can just use that when picking the patches up without a new resend.

> Thanks,
> SJ