Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 17 Apr 2023 16:24:04 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Lorenzo Stoakes <lstoakes@gmail.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Matthew Wilcox <willy@infradead.org>,
        David Hildenbrand <david@redhat.com>,
        Jens Axboe <axboe@kernel.dk>,
        Pavel Begunkov <asml.silence@gmail.com>,
        io-uring@vger.kernel.org
Subject: Re: [PATCH 5/7] io_uring: rsrc: use FOLL_SAME_FILE on
 pin_user_pages()
Message-ID: <ZD2c1CB4FmUVuMln@nvidia.com>
References: <cover.1681508038.git.lstoakes@gmail.com>
 <17357dec04b32593b71e4fdf3c30a346020acf98.1681508038.git.lstoakes@gmail.com>
 <ZD1CAvXee5E5456e@nvidia.com>
 <b1f125c8-05ec-4b41-9b3d-165bf7694e5a@lucifer.local>
 <ZD1I8XlSBIYET9A+@nvidia.com>
 <b661ca21-b436-44cf-b70d-0b126989ab33@lucifer.local>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b661ca21-b436-44cf-b70d-0b126989ab33@lucifer.local>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FVLDNCu7PxCeS9/Ru1RxSAYoQPDUrFJyuPyaR9sRVV4lt+tDt9/xPbggspyn?=
 =?us-ascii?Q?9ZsoowfU5mgaMLw1lWZLbyUsyDxR3MSFP5xLF+Bz4+TQeywl3hRuidHjNSvd?=
 =?us-ascii?Q?INzDgV0svSSbT1AjTmctQ8cI5spiHmMx5iioxHNfsxAEUSvk7BeLTF+x3ZnQ?=
 =?us-ascii?Q?VhiorlxOXviwEKb+i4vB9qpact9nA8KFt6qqvzr6IqSDcHjAnTJS3wnb3GGz?=
 =?us-ascii?Q?7oJZXXHd1rO2P+92DIdws8dMJmWqWa72MgwhJaVm5iigqQshFx5SDPbx5cyH?=
 =?us-ascii?Q?59w8eSmjWShIlXepNzN0t8t1Sbb/BgCWIuZcwVIw/PGHlBwnBAHmtFiLmv7g?=
 =?us-ascii?Q?uXoV2m6gTq3emVMFeHIoFhC0KVBGILkg1md7CU6b0661exdq4i7WuZ5l2J4R?=
 =?us-ascii?Q?xMpccFdtcxveqEAbiTxLPj+XolrMPBe+z+zUQHqSkls5wIXhkCir8e5lnATJ?=
 =?us-ascii?Q?GU9GrJOTfIukH5cxKzjlxfG7ZiKR+yW6DMv8tfxryuwCPA2nKdl4CU+YCqpi?=
 =?us-ascii?Q?G2rap3xA+H1rA3tHMU7k0YMrD94Bl1mtOPPHtN2Wu7UPWZ05d2nOsO77Irfu?=
 =?us-ascii?Q?yEbt9ejXDpDn6cTNhGLQiUMfa5eyRdwfAKRLxS66MJiBuXrfMoBKUsfkihxx?=
 =?us-ascii?Q?n0DHgLlsBziK25aBQWdw3+8Vxm9iE8xOsrKYwTC6lUD2i2YPcHy1OCCMwPap?=
 =?us-ascii?Q?yfmF+y82cue3CRoLAH9ktpYztNKuvADNrF256xR0m7G2+SJTctJSj3cDWzO3?=
 =?us-ascii?Q?MieTpwFvBv4Vxd+R2NSInde9B3I/ulrOlx42mDE1L8d+HskcOPBefqgb2BaQ?=
 =?us-ascii?Q?BT/paHCO1ZPLV8y5z+7cXzqLD3xjqMjFlJVBdR2ohVor8gSpkSkaS2ftFaMO?=
 =?us-ascii?Q?2Xka5Ccz88UBcIECBOutdZYRx0auzey7cUzagulAbjpnbK5jz0CvJz4c3uNd?=
 =?us-ascii?Q?ozHDnltnitt+mpQ9SdVqNMyUDW5sqgkFdIxFcEUqARIkWzt/QFD7bXzqyThJ?=
 =?us-ascii?Q?WUX3DJlhCwj/J1XO+UGS93uQ42jwMYY4gUi1y0f2g1xFtNMSZC0beH8edkZX?=
 =?us-ascii?Q?ljREukp3kZEDzdziGihuleQjJF2D2HTfE6renOkFcYEr2Knfu31uz6oapbkk?=
 =?us-ascii?Q?OWsP4DdM1nvm/tcYcAWKgh6WncYQJEgqJDJ8f7ovy6a3hTXbhPuF1+5GeHFx?=
 =?us-ascii?Q?eo9kyFZnwFkVq32sam1qOeCt88z8WaPSclAg46KNLqxmyRRgMarUcEjI7R7J?=
 =?us-ascii?Q?o+T3sN5Dw5fiOE/KEHElepcGCAd09n+DN3G6EtSIO6EKgg398HCkUjNsnOud?=
 =?us-ascii?Q?cGgWVvELAH+wrXtA3EAz1FOkIRGvxco/jxzoBUNIttsog+20Bn7iVEvGafQl?=
 =?us-ascii?Q?Gzle7odkHoBssremzJ2lt1A5kSBePGlsJtLHW9r6RFtt3eIu5VqGMESY0Ol4?=
 =?us-ascii?Q?nIROZyK3/gaPgSlnBlyEcEzMMvfkuXdedCAoLX8bSjUa1ovojI5N+lLQg3EY?=
 =?us-ascii?Q?Q6UwmMpB9VI37Ov1x7ibVZ+lMtLWFH1gOCD9k74iQFd11yLBHMu6d7oDEsyy?=
 =?us-ascii?Q?wWFNFls1MDHNLSFgDmKKM5sCrwajmHP1DSAhV2K5?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dce73cb4-b230-4d9d-bc8d-08db3f794fcf
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2023 19:24:06.6792
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qHGvlgUTksPZCjSQmMlWeKTO2RtxRIHVK6tNqaKOkOi4RvV6Xwh7eJrAGMCspR6X
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7252
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Apr 17, 2023 at 08:00:48PM +0100, Lorenzo Stoakes wrote:

> So I don't think this route is plausible unless you were thinking of
> somehow offloading to a thread?

ah, fair enough
 
> In any case, if we institute the FOLL_ALLOW_BROKEN_FILE_MAPPINGS flag we
> can just drop FOLL_ANON altogether right, as this will be implied and
> hugetlb should work here too?

Well.. no, as I said read-only access to the pages works fine, so GUP
should not block that. It is only write that has issues

> Separately, I find the semantics of access_remote_vm() kind of weird, and
> with a possible mmap_lock-free future it does make me wonder whether
> something better could be done there.

Yes, it is very weird, kthread_use_mm is much nicer.
 
> (Section where I sound like I might be going mad) Perhaps having some means
> of context switching into the kernel portion of the remote process as if
> were a system call or soft interrupt handler and having that actually do
> the uaccess operation could be useful here?

This is the kthread_use_mm() approach, that is basically what it
does. You are suggesting to extend it to kthreads that already have a
process attached...

access_remote_vm is basically copy_to/from_user built using kmap and
GUP.

even a simple step of localizing FOLL_ANON to __access_remote_vm,
since it must have the VMA nyhow, would be an improvement.

Jason