Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230410161654.1660757-1-quic_eberman@quicinc.com>
In-Reply-To: <20230410161654.1660757-1-quic_eberman@quicinc.com>
From:   Jassi Brar <jassisinghbrar@gmail.com>
Date:   Mon, 17 Apr 2023 14:08:45 -0500
Message-ID: <CABb+yY0iO3FPMi6WHaHio+vsjXWiN-x85kCXyjPZ6EWZgmnwgg@mail.gmail.com>
Subject: Re: [PATCH v3 0/3] mailbox: Allow direct registration to a channel
To:     Elliot Berman <quic_eberman@quicinc.com>
Cc:     Sudeep Holla <sudeep.holla@arm.com>, linux-kernel@vger.kernel.org,
        linux-acpi@vger.kernel.org, linux-arm-msm@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Apr 10, 2023 at 11:17=E2=80=AFAM Elliot Berman <quic_eberman@quicin=
c.com> wrote:
>
> Two mailbox controllers have channel/client binding mechanisms that are
> controller-specific and not using the devicetree binding mechanisms. Mail=
box
> channel/client is conceptually done in two steps: selecting the channel
> and binding the selected to channel to a client. Channel selection is som=
etimes
> controller specific (pcc and omap are examples). The channel/client bindi=
ng
> code is all the same.
>
> This small series de-duplicates and refactors the channel/client binding
> into a common framework function: "mbox_bind_client" which all of the
> channel selection mechanisms can use.
>
> I found this duplicate code while working on the support for Gunyah hyper=
visor
> message queues [1]. I've only been able to compile-test omap-mailbox and =
pcc,
> however it is a straightforward conversion here.
>
> [1]: https://lore.kernel.org/all/20230120224627.4053418-9-quic_eberman@qu=
icinc.com/
>
> Chagnes since v2:
>  - Fix warnings in drivers/mailbox/pcc.c reported by lkp@intel.com
>
> Changes since v1:
>  - Rebase to https://git.linaro.org/landing-teams/working/fujitsu/integra=
tion.git/log/?h=3Dmailbox-for-next
>  - Add Tested-By from Sudeep (thanks!)
>
> Elliot Berman (3):
>   mailbox: Allow direct registration to a channel
>   mailbox: omap: Use mbox_bind_client
>   mailbox: pcc: Use mbox_bind_client
>
>  drivers/mailbox/mailbox.c      | 96 ++++++++++++++++++++++++----------
>  drivers/mailbox/omap-mailbox.c | 22 ++------
>  drivers/mailbox/pcc.c          | 84 +++++++++++++++--------------
>  include/linux/mailbox_client.h |  1 +
>  4 files changed, 118 insertions(+), 85 deletions(-)
>
Seems fine. Will pick these up for the coming merge window.

Thanks.