Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230414150830.3173504-1-trix@redhat.com>
In-Reply-To: <20230414150830.3173504-1-trix@redhat.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Mon, 17 Apr 2023 15:28:21 -0400
Message-ID: <CADnq5_OHu7kJGvTVg_oDMadqQFBrhFAZBM9H76y6tiYNsWT+4Q@mail.gmail.com>
Subject: Re: [PATCH] drm/amd/display: remove unused variable oldest_index
To:     Tom Rix <trix@redhat.com>
Cc:     harry.wentland@amd.com, sunpeng.li@amd.com,
        Rodrigo.Siqueira@amd.com, alexander.deucher@amd.com,
        christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com,
        daniel@ffwll.ch, HaoPing.Liu@amd.com, aric.cyr@amd.com,
        qingqing.zhuo@amd.com, hanghong.ma@amd.com, felipe.clark@amd.com,
        Dillon.Varone@amd.com, Mike.Hsieh@amd.com,
        dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

On Fri, Apr 14, 2023 at 11:08=E2=80=AFAM Tom Rix <trix@redhat.com> wrote:
>
> cpp_check reports
> drivers/gpu/drm/amd/display/modules/freesync/freesync.c:1143:17: style: V=
ariable
>   'oldest_index' is assigned a value that is never used. [unreadVariable]
>    oldest_index =3D 0;
>                 ^
>
> This variable is not used so remove.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/gpu/drm/amd/display/modules/freesync/freesync.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c b/dr=
ivers/gpu/drm/amd/display/modules/freesync/freesync.c
> index 5c41a4751db4..5798c0eafa1f 100644
> --- a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
> +++ b/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
> @@ -1137,10 +1137,6 @@ void mod_freesync_handle_preflip(struct mod_freesy=
nc *mod_freesync,
>
>         if (in_out_vrr->supported &&
>                         in_out_vrr->state =3D=3D VRR_STATE_ACTIVE_VARIABL=
E) {
> -               unsigned int oldest_index =3D plane->time.index + 1;
> -
> -               if (oldest_index >=3D DC_PLANE_UPDATE_TIMES_MAX)
> -                       oldest_index =3D 0;
>
>                 last_render_time_in_us =3D curr_time_stamp_in_us -
>                                 plane->time.prev_update_time_in_us;
> --
> 2.27.0
>