Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Rahul Rameshbabu <rrameshbabu@nvidia.com>
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/1] HID: shield: Initial driver implementation with
 Thunderstrike support
References: <20230417182909.33833-1-rrameshbabu@nvidia.com>
        <20230417182909.33833-2-rrameshbabu@nvidia.com>
        <1a754a3e-2a2b-07d5-c94a-0373a1677e4e@infradead.org>
Date:   Mon, 17 Apr 2023 12:33:29 -0700
In-Reply-To: <1a754a3e-2a2b-07d5-c94a-0373a1677e4e@infradead.org> (Randy
        Dunlap's message of "Mon, 17 Apr 2023 12:20:51 -0700")
Message-ID: <87leiqb8xi.fsf@nvidia.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vJkJ8/aS3rOQYWkftDEmQA46dYwGRMIOTaocqvmygqA0EEfZWX0Ez8IIS4Vv?=
 =?us-ascii?Q?WBDaollysoL+WCJqh0wHwiuS7XqtuxAR0lvdDEiCDjdZe5vz/CHIzeuXBOAn?=
 =?us-ascii?Q?Q1jHOOkHSo/jwdbPO8J3cMobII7mDfNdbO/gnzGrcww1oc4IjIYUWORCsVYi?=
 =?us-ascii?Q?yhpparZp0k/iTd54j0W2Z5M8z6tMfwsMmNLImxHeI9Ac5L1Gm7HsMxZG02a0?=
 =?us-ascii?Q?uPPsa/hivR9fwwf3iF2IY546eIOu7Slb0AdHykl3967mihJ4ximBZvNTcd6f?=
 =?us-ascii?Q?Eg+Cae7dc++JZjxtmb5j6RABZQoJvDJC6vnMcIwiMGZMEQc8Gb0YFgd9lfuA?=
 =?us-ascii?Q?72DABhfITh67rTESOsWq3Hv2lXcqGE2i20vpYtzwG40qJZCuAZ4WERJWD/gq?=
 =?us-ascii?Q?DBN0uD/asl8ZFyMVZ9OR9N+JItqydi3b4TwFc+l4dOH0TZ5gM8cIBXvLsFKi?=
 =?us-ascii?Q?hZ6GDd38RTlbUWBTOQdByWas3+ZUj1Fi7B8nZrKWIV/Pkck6THw1qPvJ8OoQ?=
 =?us-ascii?Q?4yFCHJRIMvThacwuDygZ8eCi3G0GMs4vhWapAehls4QffpeRyy9t2aEoQlvJ?=
 =?us-ascii?Q?EMkw7I9z/qtyL9QDAq/wdxkU4GInjx6DboOS/rRrTJL89LHP80FsW9QiskNE?=
 =?us-ascii?Q?iw2h/1ATdDr9lbvc0jVIDX9nx0kPsXIPaF7mxX/6ewuRinlziQojLcyAp6tT?=
 =?us-ascii?Q?3VpOzLylZSysAqu5n42G8hY12wuu05YGDFv2gbGwIF5HgBhgRn+IH72tBplO?=
 =?us-ascii?Q?fgd2zzszQtuSLD0kg9vZE4bsXuxZHgjebWperEyDAnV5OujgAWIA2PN57CFS?=
 =?us-ascii?Q?1Z6neB2rpKFhDFemye61+/dJnjMLaWQwSUu+4YP2nCJRKOQ+JyGbQHDzCBEU?=
 =?us-ascii?Q?XS4pRJ+DooM/8VIkp29UFCx2Sfliy87GjRrXhpc+ybxEb0oWwv6ihOq9URid?=
 =?us-ascii?Q?CpnTPhApM0lQncjK4GhsmHk5tGl4qSBw3OzRNrzJMVUBmHO7/QBMv918bEWQ?=
 =?us-ascii?Q?cSlV311ag012gBq7d9zahMWghEYxuF/lQRp1S0enLkInMETgrbN05NIhcNze?=
 =?us-ascii?Q?RAADBS9s3v3JAjWozkrv1gH62Za4Eo/Pfops+shILBSKuhUFw7+F0tQKvDfj?=
 =?us-ascii?Q?kNkQ7OAjwrHFHtcA1e1DopKhZy6y3StyqRphwQfAfGEo/33e2Izgu8F7fkAI?=
 =?us-ascii?Q?C7WzbKfpL04u5iqdsWt5MSdGzBpjzn761b6ZBf+6VLcn21Za9EYBXHP57Ks3?=
 =?us-ascii?Q?PY59QdzhRDnXGVZR5yVU7PRCsswpzMXi6eJKUk/ilGF2ctSVzAJbWKRO7YRr?=
 =?us-ascii?Q?GeNOQvVOHKlC71kRigWvd5QZfAp9scAGgFwbz/O5j2Gj81TjybxShnlTBZns?=
 =?us-ascii?Q?BWD8r1XDgbAO+ZbOnCmhYhdBuTyqY8nVH/KOHAWEs4iaOyh7Q7ti/hSkAkXI?=
 =?us-ascii?Q?UTz34ZMmNRMzeN2H9POB00KMN0lK1O3ibY4j1rgZl5jAxyT7+3nJhJ0tbNWc?=
 =?us-ascii?Q?rMzYXhOOj+iJdT/VXlwtDqFd6NT8u5JVG99yRVpjbwjTRRaluP5fnEOYio5t?=
 =?us-ascii?Q?lFQVTBSTG+Yn3wL28s5VscRjjy/WScPhmT6GQnQgN2omjhgT23YW4eVUfrsL?=
 =?us-ascii?Q?yg=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 71df493e-9b26-47a7-dac1-08db3f7aa4be
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2743.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2023 19:33:38.7077
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kIW5KhFJ2PkGSeYanIVEzc7P2qk5AIp2yWmTTk9E7HZmzcAc9fGurNWapSPq9WDd94n5f3T2f+dVaMDmEbinBw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8188
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Randy,

Thanks for the feedback. You are correct about the styling issue in my
patch. I will fix this. I do want to bring to attention that there seem
to be a couple of kernel config options in the Kconfig file for the hid
subsystem that currently violate the styling rules.

It probably would make sense to have a clean-up patch for this issue
overall (separate from this patch, which I will correct in my next
version).

-- Rahul Rameshbabu

On Mon, 17 Apr, 2023 12:20:51 -0700 Randy Dunlap <rdunlap@infradead.org> wrote:
> According to Documentation/process/coding-style.rst, Kconfig help text should
> be indented by 2 spaces after the "help" line:
>
> 10) Kconfig configuration files
> -------------------------------
>
> For all of the Kconfig* configuration files throughout the source tree,
> the indentation is somewhat different.  Lines under a ``config`` definition
> are indented with one tab, while help text is indented an additional two
> spaces.  Example::
>
>   config AUDIT
> 	bool "Auditing support"
> 	depends on NET
> 	help
> 	  Enable auditing infrastructure that can be used with another
> 	  kernel subsystem, such as SELinux (which requires this for
> 	  logging of avc messages output).  Does not do system-call
> 	  auditing without CONFIG_AUDITSYSCALL.