Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-372-g43825cb665-fm-20230411.003-g43825cb6
Mime-Version: 1.0
Message-Id: <0d966637-6074-4d54-a299-41d063e05310@app.fastmail.com>
In-Reply-To: <de29b7ac-910c-8d4b-50ff-47ba4134d16a@amd.com>
References: <20230417210602.2614198-1-arnd@kernel.org>
 <de29b7ac-910c-8d4b-50ff-47ba4134d16a@amd.com>
Date:   Mon, 17 Apr 2023 23:14:28 +0200
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Hamza Mahfooz" <hamza.mahfooz@amd.com>,
        "Arnd Bergmann" <arnd@kernel.org>,
        "Harry Wentland" <harry.wentland@amd.com>,
        "Leo Li" <sunpeng.li@amd.com>,
        "Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
        "Alex Deucher" <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        "Dave Airlie" <airlied@gmail.com>,
        "Daniel Vetter" <daniel@ffwll.ch>
Cc:     "Nicholas Kazlauskas" <nicholas.kazlauskas@amd.com>,
        "Taimur Hassan" <Syed.Hassan@amd.com>,
        "Jasdeep Dhillon" <jdhillon@amd.com>,
        "Alex Hung" <alex.hung@amd.com>,
        "Michael Strauss" <michael.strauss@amd.com>,
        "Aurabindo Pillai" <aurabindo.pillai@amd.com>,
        "Qingqing Zhuo" <qingqing.zhuo@amd.com>,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] drm/amd/display: mark dccg314_init() static
Content-Type: text/plain
Precedence: bulk

On Mon, Apr 17, 2023, at 23:12, Hamza Mahfooz wrote:
> On 4/17/23 17:05, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>> 
>> The newly introduced global function is not declared in a header or
>> called from another file, causing a harmless warning with sparse
>> or W=1 builds:
>> 
>> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_dccg.c:277:6: error: no previous prototype for 'dccg314_init' [-Werror=missing-prototypes]
>> 
>> Mark it static instead.
>> 
>> Fixes: 6f6869dcf415 ("drm/amd/display: prep work for root clock optimization enablement for DCN314")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> This has already been fixed as of commit 669f4ac40947 ("drm/amd/display:
> set variable dccg314_init storage-class-specifier to static") in
> amd-staging-drm-next.

Ok, thanks. I waited for a rebase on today's linux-next before posting
mine to make sure it's not already fixed, it must have just missed the
cut-off.

      Arnd