Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <de29b7ac-910c-8d4b-50ff-47ba4134d16a@amd.com>
Date:   Mon, 17 Apr 2023 17:12:15 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH 1/2] drm/amd/display: mark dccg314_init() static
Content-Language: en-US
To:     Arnd Bergmann <arnd@kernel.org>,
        Harry Wentland <harry.wentland@amd.com>,
        Leo Li <sunpeng.li@amd.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>,
        Taimur Hassan <Syed.Hassan@amd.com>,
        Jasdeep Dhillon <jdhillon@amd.com>,
        Alex Hung <alex.hung@amd.com>,
        Michael Strauss <michael.strauss@amd.com>,
        Aurabindo Pillai <aurabindo.pillai@amd.com>,
        Qingqing Zhuo <qingqing.zhuo@amd.com>,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20230417210602.2614198-1-arnd@kernel.org>
From:   Hamza Mahfooz <hamza.mahfooz@amd.com>
In-Reply-To: <20230417210602.2614198-1-arnd@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Rk5FU3p5UU8rSHlOemxNcVc2Mk9mRGFtdk5NVmpMTUwvWTM2d2NlZzR0Z01n?=
 =?utf-8?B?UEIwVmNidFlkVGtUdFBKRlZDTGo3bUVIUGw3TUh0aU8weXlyRkN1SHpuRkw4?=
 =?utf-8?B?MHY4a0hrbUJDRkdFRTcraVl3OHQ4MmtlczdKWEVXMWdEOEtmWmZTSGtJSE03?=
 =?utf-8?B?eGdiMW4yYkdIQi80aG1QTVAvUXVDMVVTVWNsNUUrVUk3dno3ZnlEMy94NGdv?=
 =?utf-8?B?NWU4QTRqcGw1L2JqZFFoN2JVWG40ekFOWHMycktZeGE0WUoxc1d5SXJOckV4?=
 =?utf-8?B?UWJUOGJXWmtXQ1krSC95UWw3Ui9DMHpGd1VYOGM3NjR5KzNqNk5sc1JoSm00?=
 =?utf-8?B?Z1pndVNrVmNZaktDOEJGSVpXUTBsNlNXd0tISG5xSmp6eGlPcWtPN2srcGpX?=
 =?utf-8?B?a1ZraVVTMGxib2Z0OHUvSTNvaVEwUTBtK2VuWFJsVFB4YTlLa2hudERuaDZl?=
 =?utf-8?B?K09MMVVaT2N2MUJVdXZtYzN0K0pjaEhVTmRBMnc3eE9nU2NreUxIZmp1amlS?=
 =?utf-8?B?MHRib29MeTRlazcrZVFLdjhSKzRhVTZsRmtlUHRxeURqRmtaeWpxR2MwODg2?=
 =?utf-8?B?MmkrejNncmhhVDRUZkVWYmQ2MG9tZWVmeU9jcG9vbWIxdy9Nc2xRNkk3bHNV?=
 =?utf-8?B?SHNmYjlZZitkRSsxRWtSR2ZZb1NGTVpVMTdiQWQrekVDb0pZZVdaRStGVjFj?=
 =?utf-8?B?Nk1zalkxeXhCdzB0NUlvbXRuSFd3WGExb1E4ZEc0Mk10OHpIWnMzam9yQlJU?=
 =?utf-8?B?emhtZFg0T2x0QUdnYnE1NzZjeTNVRTJIeVVQRlJrUnNNVlNVL21aOXhjSFdR?=
 =?utf-8?B?UFB2cnZMd2NYcUxIcWwwZUZpcVlEWTZYNE12OWh4ODNqczNGbTFOdGdRREMv?=
 =?utf-8?B?dlNjWlBEQWRIU0xMTlA3L2ZydVAzdjZTK2VUUVRmSTZjNjBYM1gzZ2dad3d6?=
 =?utf-8?B?QVd5VVphZVhvTFRDQVZFbm1BL21SRG1ZRDc2RGZJK2UrUkdIWWJYZmcvOE5K?=
 =?utf-8?B?Tm5pWHhPV2RmbVRWRW5uNFpacTVVNlJpY3ovREVkNlFxb2o0eExpQ25TZG43?=
 =?utf-8?B?SEVuNTB6bkFHYU5tbXZmMmdGRjBUKzk3OHdnemh6SVBTcnRJcnlOSERWcUxI?=
 =?utf-8?B?bmVLYndsWXRGMDR3dndGbTFIRmY0bW94OGFVQWdha0hNVGdIU1RmWC9RaTk4?=
 =?utf-8?B?VFlSQ2hiWnRSMldxM3RZMkZ1NWJ2Zkg3NWxGZEs4U004M2xXUjJPOGNRaEl6?=
 =?utf-8?B?azU5ejhrQUY4TDZJMGxBOVoxOU8xd2VGMExKR1RKWS9ZdjFVN3RHbDkwZXFJ?=
 =?utf-8?B?ejBhR0owaXA3VkdoZGdoQlI1SEE5Rzg2VmM3WDVIcXowazR0SlJHOFI1RTFr?=
 =?utf-8?B?WW1TWDMxdzZzd2FWaE5HTmR3QUd6cDRCVUxVbzBlbHRRNVVJamZ4L3dwMmdn?=
 =?utf-8?B?aVZ6RVpiallUNlVkUTBXV2x3LzVqVDZoeGpDSVo2MTVZaUZKckhMVGduSTh6?=
 =?utf-8?B?VFJaMVNZem9qcFp4V2VhSEZFSGtibzdpMTc2Z2NCMVN5ZnMwSEhRQVVSWStr?=
 =?utf-8?B?dHd0aTZJT21uQWF5am9uWEpySENhNmFGUGZaNlpOR3ZZVC9YZnlvVW9hWCsw?=
 =?utf-8?B?RzB3Smc4TnZJNHIvUU51N3VJNEUzTjJkcDRLcjdDVHZMTWM1SnI3MjdlbGY5?=
 =?utf-8?B?K25MY2cyU2I2Nk4yWFhSaXpoVDJsV01uaUNUWGdxcXVxd0QyWnNmNGhTME9l?=
 =?utf-8?B?SFBkZ1Z6SmdtS29MNWhiYm1DaE9pR2RoQ3JBWnJtRGxBQlJsaWlRVnVqcWFh?=
 =?utf-8?B?eHE4aUo3eE1hQzdXQ3NqU0lnbHVTS2FZZHh3cjhUK3NvOGk3cXQyUGZMZXdE?=
 =?utf-8?B?NG5iTW1laTFMZkNaZFJVa0ZYVmFyRmFxZ3lZK1pieEpsV0FacENxSitNaGM2?=
 =?utf-8?B?ZDhhNElIdVNsSWNZR3J3TmdKaXdncGMxUzNSOFNyUE5RQmlBeWVBMXpMV21O?=
 =?utf-8?B?OE5CcGExS3RHekI1RkU4VUswTEx3M2E0WUtFQ3JKaUxmSnQ2ZDFkZk1SSDZD?=
 =?utf-8?B?eWkvTE1VMUorZ2dJTkovOVFUK0VXdWQ3d2J6OHFUNEdOa3dhVXdUeExqSFpm?=
 =?utf-8?Q?8W6vAgQ46Vl9WwLMUWjrpy+sh?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8540b53a-eaf8-492c-642f-08db3f8839b1
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6280.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2023 21:10:52.1565
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5UcoB7S+HOmQQQwHMyUuV6mFcVYBMO9rRhjvFmAHXujjcIyvfGY2ryqT4YW19nMU698BspJ43jYbxog+Y2atew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6214
X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/17/23 17:05, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The newly introduced global function is not declared in a header or
> called from another file, causing a harmless warning with sparse
> or W=1 builds:
> 
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_dccg.c:277:6: error: no previous prototype for 'dccg314_init' [-Werror=missing-prototypes]
> 
> Mark it static instead.
> 
> Fixes: 6f6869dcf415 ("drm/amd/display: prep work for root clock optimization enablement for DCN314")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

This has already been fixed as of commit 669f4ac40947 ("drm/amd/display:
set variable dccg314_init storage-class-specifier to static") in
amd-staging-drm-next.

> ---
>   drivers/gpu/drm/amd/display/dc/dcn314/dcn314_dccg.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_dccg.c b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_dccg.c
> index 6f879265ad9c..de7bfba2c179 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_dccg.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_dccg.c
> @@ -274,7 +274,7 @@ static void dccg314_set_dpstreamclk(
>   	}
>   }
>   
> -void dccg314_init(struct dccg *dccg)
> +static void dccg314_init(struct dccg *dccg)
>   {
>   	int otg_inst;
>   
-- 
Hamza