Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 17 Apr 2023 23:20:59 +0200 (CEST)
From:   Richard Weinberger <richard@nod.at>
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     Miquel Raynal <miquel.raynal@bootlin.com>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        =?utf-8?B?TWljaGHFgiBLxJlwaWXFhA==?= <kernel@kempniu.pl>,
        Arnd Bergmann <arnd@arndb.de>,
        linux-mtd <linux-mtd@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Message-ID: <645805930.114012.1681766459273.JavaMail.zimbra@nod.at>
In-Reply-To: <20230417205654.1982368-1-arnd@kernel.org>
References: <20230417205654.1982368-1-arnd@kernel.org>
Subject: Re: [PATCH] mtdchar: mark bits of ioctl handler noinline
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
Thread-Topic: mtdchar: mark bits of ioctl handler noinline
Thread-Index: nwC/Hc1rDi+z5tkPO5cWLU+7DfHq+w==
Precedence: bulk

----- Ursprüngliche Mail -----
> Von: "Arnd Bergmann" <arnd@kernel.org>
> The addition of the mtdchar_read_ioctl() function caused the stack usage
> of mtdchar_ioctl() to grow beyond the warning limit on 32-bit architectures
> with gcc-13:
> 
> drivers/mtd/mtdchar.c: In function 'mtdchar_ioctl':
> drivers/mtd/mtdchar.c:1229:1: error: the frame size of 1488 bytes is larger than
> 1024 bytes [-Werror=frame-larger-than=]
> 
> Mark both the read and write portions as noinline_for_stack to ensure
> they don't get inlined and use separate stack slots to reduce the
> maximum usage, both in the mtdchar_ioctl() and combined with any
> of its callees.
> 
> Fixes: 095bb6e44eb1 ("mtdchar: add MEMREAD ioctl")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Richard Weinberger <richard@nod.at>

Thanks,
//richard