Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 17 Apr 2023 16:11:20 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Terry Bowman <terry.bowman@amd.com>, <alison.schofield@intel.com>,
        <vishal.l.verma@intel.com>, <ira.weiny@intel.com>,
        <bwidawsk@kernel.org>, <dan.j.williams@intel.com>,
        <dave.jiang@intel.com>, <Jonathan.Cameron@huawei.com>,
        <linux-cxl@vger.kernel.org>
CC:     <terry.bowman@amd.com>, <rrichter@amd.com>,
        <linux-kernel@vger.kernel.org>, <bhelgaas@google.com>,
        Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
        Oliver O'Halloran <oohall@gmail.com>,
        <linux-pci@vger.kernel.org>
Subject: RE: [PATCH v3 3/6] PCI/AER: Export cper_print_aer() for use by
 modules
Message-ID: <643dd21856099_1b6629482@dwillia2-xfh.jf.intel.com.notmuch>
References: <20230411180302.2678736-1-terry.bowman@amd.com>
 <20230411180302.2678736-4-terry.bowman@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230411180302.2678736-4-terry.bowman@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fbCyyoJR32ExtnuvuQ/TBD01dG0ZJdxUwT0Zi/DJSlFcxHZMaJKFnfTfvlHP?=
 =?us-ascii?Q?E/1ftRUV2sc5O0SK2q3+0GBphs2ukkWlvmZ3ECtK1Kp0ywO/t1C0GcONsxer?=
 =?us-ascii?Q?vpNpYbMiG18PejzdCJwdIA8HfFibc1n3rWmfY1MHwuQEf6qTQB8O/kEAaK/F?=
 =?us-ascii?Q?ScG+uaBr2RjyxgstQPiOiBUWdvfz9TDf+pa/NpH5XutEMCSV75LgQHjCbIrU?=
 =?us-ascii?Q?akR+hxux8i8X8qH1fitWgC99x6RIlVKmprMYGC1bz4QgpE8qE9M77hLIM68S?=
 =?us-ascii?Q?0WiFlV+GYfvOoRrTnoV0XeFEnXEOv5XGcAnBBRzI+gTuUCPms7tpGiWcoz4c?=
 =?us-ascii?Q?P6/AIYRye6pn3CEN3uCzusYIeXI8WMOS3a/SWy45TGNqPzlDOud1JtqaSdI/?=
 =?us-ascii?Q?AtTcD+6HnlJ8J3iA5k6ZATYrkc3kCkeYY7AuhpdScVqD/Hct0aKVwlDSoi48?=
 =?us-ascii?Q?pdsCxyj+NBqdNHLYSkkKl3hOAqTHuQO9PPd77prWmUxMToxXWfzLVyi9RoVi?=
 =?us-ascii?Q?ISn5ygy1VVX8N4wjIgCmisMqQg/aHEqKDImS7FkFzU38rq7d8ToCf/3HzQDV?=
 =?us-ascii?Q?z/+LqAqI/A+OveR2J+1Dp5aSB8zkPPo6a15JB2re9++20nQvAv0uTXdW6k6Z?=
 =?us-ascii?Q?UZ2a6fMwuBqTZvj54uNOv7/4ZiqeG4Os7E/SBKUm9GJUF6YuGJYXshykFVPO?=
 =?us-ascii?Q?rVGuJPMdv09N0U6kyXS391X/OkH2HQrNPtGQk+z9ZNzDgxzYizfAD7BP9eS/?=
 =?us-ascii?Q?CmFMswFH8z6gCx76OB7xBhXPvUsvvgaoVRjfQLNOFyJHtfes8GmRelFHaDzh?=
 =?us-ascii?Q?5ChEEfBIEpuyg1wik8giLpwxo23yHoYefEO/qaugIkzPiu9nuWt7zswkAC+V?=
 =?us-ascii?Q?nxbfIkCm74RZRVxIPUfAL6S0HSIPZBeXmt2m9dVQvAk8d5PNBAd18Y/lisMc?=
 =?us-ascii?Q?HcLsYN9HfG/xUe7gOUmoW1Vvv7CsiNs2dyHAT4+Tx0URTEGwAVIgkvFgzUUi?=
 =?us-ascii?Q?T1g0sFYiEfDSzsi/Wkc9eyTpx93SRCQZ2PDsTXB36fFXUBjNDcNEKsIIkCm3?=
 =?us-ascii?Q?rcX2dixyC+84Oz1cxYc3CQNzCszP4GNEZXwrOUf1i9uSnTMhZ6Pk3SBWzLBL?=
 =?us-ascii?Q?v+BjROzDoLltvO+S7/4VSKSmRqewWG9DKdNEcLfEVWe9CRoHAoy7QWmHeV5J?=
 =?us-ascii?Q?IBIsShS+pOCJ8F+jpWdBjZGwfPZNQhLn6Fo/Ugos5sEBSyF5ESMZm6BswPxe?=
 =?us-ascii?Q?63x9wu1S+a8SQ5AtsfIhctD5Yl7CHGE3BpfKbA01UBzV9bQqpY37HdTZiWWy?=
 =?us-ascii?Q?mFfGR4DuspIJq4NErOpjdr31uSyLjFlQAf0iNgGcdsmeRrtLBPFgzvqpinBM?=
 =?us-ascii?Q?9riEUWa7MqkmmhAoWXf1HUI1d+gcH5OUQGcPtvHK2GTVyehFybIrwUKJqAXE?=
 =?us-ascii?Q?6wuhvjNtvSYo5u/hBTjJXFv+BiOjkdyJkQ5Y3w9Wxwtoi6G989jfxmbl4P0v?=
 =?us-ascii?Q?zYlLR5sddxu4dPiD/fngDjXh7pW4520zbeF5SxrWZ9/o+e2pXqCGXlQ9Uy1T?=
 =?us-ascii?Q?eGM5ZO4paUNFQeQH2wiBePCOU+DzSbM2UF4u9eZ37nvW9XcTg05vfLONAAgp?=
 =?us-ascii?Q?2w=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 58115eb5-3d3b-448c-44e1-08db3f990f86
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2023 23:11:22.8303
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fD8RFyKeBr9+nmM+r4xSX7CbW7G3KLo2Eq5kMTNFQtNKCkuAb4K4C1365cd48+6luYkx7d0zndnI328nQEmSCVdAWcEra9BrPQFGQBcxLwM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6723
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Terry Bowman wrote:
> The CXL driver plans to use cper_print_aer() for restricted CXL host
> (RCH) logging. cper_print_aer() is not exported and as a result is not
> available to the CXL driver or other loadable modules. Export
> cper_print_aer() making it available to CXL and other loadable modules.
> 
> Signed-off-by: Terry Bowman <terry.bowman@amd.com>
> Cc: Mahesh J Salgaonkar <mahesh@linux.ibm.com>
> Cc: "Oliver O'Halloran" <oohall@gmail.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: linux-pci@vger.kernel.org
> ---
>  drivers/pci/pcie/aer.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
> index f6c24ded134c..7a25b62d9e01 100644
> --- a/drivers/pci/pcie/aer.c
> +++ b/drivers/pci/pcie/aer.c
> @@ -812,6 +812,7 @@ void cper_print_aer(struct pci_dev *dev, int aer_severity,
>  	trace_aer_event(dev_name(&dev->dev), (status & ~mask),
>  			aer_severity, tlp_header_valid, &aer->header_log);
>  }
> +EXPORT_SYMBOL_GPL(cper_print_aer);

Same EXPORT_SYMBOL_NS_GPL() as the last patch, I can't imagine another
scenario where this symbol needs exporting.

Does this not need a stub in the CONFIG_PCIEAER=n case? Maybe that's
handled in the CXL code, I'll keep reading...