Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 17 Apr 2023 16:08:14 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Terry Bowman <terry.bowman@amd.com>, <alison.schofield@intel.com>,
        <vishal.l.verma@intel.com>, <ira.weiny@intel.com>,
        <bwidawsk@kernel.org>, <dan.j.williams@intel.com>,
        <dave.jiang@intel.com>, <Jonathan.Cameron@huawei.com>,
        <linux-cxl@vger.kernel.org>
CC:     <terry.bowman@amd.com>, <rrichter@amd.com>,
        <linux-kernel@vger.kernel.org>, <bhelgaas@google.com>,
        Ard Biesheuvel <ardb@kernel.org>, <linux-efi@vger.kernel.org>
Subject: RE: [PATCH v3 2/6] efi/cper: Export cper_mem_err_unpack() for use by
 modules
Message-ID: <643dd15e9bb8_1b662943c@dwillia2-xfh.jf.intel.com.notmuch>
References: <20230411180302.2678736-1-terry.bowman@amd.com>
 <20230411180302.2678736-3-terry.bowman@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230411180302.2678736-3-terry.bowman@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OeUZVCF4gkajZiDcku7PIH1wAV9sEppQBnzWNI/uv1hMmR6BPjL3N2VkFHn7?=
 =?us-ascii?Q?C3pnQjSS+hT0TLYLts49UEclXWyYj//1LszOUmyDnnJ7CCf2eb4nmHtXtQX6?=
 =?us-ascii?Q?pIZcqVWvPic6JNCrp09WEnbtKPmDJN0D6awZJ+pjozytI4iwXtTDJ/Yj2NnV?=
 =?us-ascii?Q?RW+wa4p4o2E0oWOjCP8vLVBY6jTxkpo4d4q5girupzR4izQUqwzSO5msME36?=
 =?us-ascii?Q?RsLagWJfQ4QTVAqDqeINEjGdtSdYi+valOK6U8cX4U7zOAtn5ILLVNwlINKM?=
 =?us-ascii?Q?CKZdTxqx9WwxE1kwBfBBfsPMXcfNohY8uZwn0fc95xxzSt0yoEOOnUOFltxU?=
 =?us-ascii?Q?DuRJtNWQZbpd2LVJNGw/LSjwyDpV98skbWgWmH+M6RHnzqaVgS98c4sV+V9h?=
 =?us-ascii?Q?k3RAgl7s50jhx2fdWB6559ewYIzgeKwFT+22Llb0y1pkV5jeUNQxyrYKuv51?=
 =?us-ascii?Q?E3Lbt7aLSA6fRYfWWWXzL/sgKaDkMmXxJl8D4j5ggr4VFP46f5WQ6HO7Pxks?=
 =?us-ascii?Q?L9k7svjMkndcHJXjLdpZxzGyBvnFMdGkEnxa6qZ1XQ8cY1MnjCPvHYFxMnUu?=
 =?us-ascii?Q?+aRvK816ti42mcnQIxuv2rxLDBHAP+wRpEhvgkEEQRIEIDrlqSVMwz4kcYR2?=
 =?us-ascii?Q?i8gk/mrnqZpQS/F5JzJVbW3sp6fZxnD0SvxOigiGv93CI7go5Km26lQg2lxw?=
 =?us-ascii?Q?WQeaYiF6II+8RUPmpLV4ZxGKzjI2ZYOscoYOdx3OatwXSnG1bdxq/kq5+Xm+?=
 =?us-ascii?Q?KSvzhzDthgfUGswpB9n266gVqlsPjwOl49yMHUcv7q/oJZSf3nH5R76AhM/o?=
 =?us-ascii?Q?zZ2OpLKidUVEsVSl/1T8/oZQBHrzra4q6CiBNevIqk42QmrMc8+RXy4NSN3u?=
 =?us-ascii?Q?WtkC2St3UPJQqTa3XRDqDx99ntp9Xy9DNNMEUnGwEO2bB9WUECTkuDXaz9h9?=
 =?us-ascii?Q?LsnQJMx76FD39cnYjPgy7sUSIPGTM+w+lbMBfHNdHsRAjPBIUKJD51fcgEj0?=
 =?us-ascii?Q?b4Yer49F0pMwL1I9UH18D3wCxOZxQvHOmow5e50C7kgvRdtOuc7WA8pH1tl/?=
 =?us-ascii?Q?8zOVwILjjP7guZ5RAzrmDxyk6DLWgV2wof2xZ6dVpDq2j1M6eHef5DgF1+ck?=
 =?us-ascii?Q?el9Hot7eghfnjWgJ7KcII5iYDfqVHgNwXHNnP4W9MyGzV4JS/X8GKBAxxe2+?=
 =?us-ascii?Q?31va8OFim/Q/VHRm7Zwjl0pZMQhtaLRNuF9h9wqX3YLAq4hfCmDpO8+aK1rf?=
 =?us-ascii?Q?53Ldd3MYvqjAgvLLs0/Zl9B4wUTFtSLCH4NX+ienArQY1xzRItuUIf9k9cJE?=
 =?us-ascii?Q?o64sFH+dd35oEs31LUdbmpQTFnPXu4MPM+1I5h0UU2JVh9tAz9W5khL/T2Ho?=
 =?us-ascii?Q?DC4BJzc/EIlvaMQZSi6sCyyF6BbfP5SrFlgak0KKr+jUTCM5uMXrFZfdH1em?=
 =?us-ascii?Q?taq1XGIg2N4rPw/Rb+ze10MP9o2f8AMfHysjQT8N7wl4egl9LxLvzR3ZOBWk?=
 =?us-ascii?Q?h8N8efV6fPQ80awvTCiyuL4+ZeQ2GtYVpxUJ09lg8cqIg4x4w053Ef4i1tYE?=
 =?us-ascii?Q?RwR6eIhUeARmsQAzZm69UXVtuaaEsIJXXbuAJ52LyU4dk4kbzUiY3+M5pLkU?=
 =?us-ascii?Q?cQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3a96a417-ae18-4a0e-c381-08db3f98a09a
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2023 23:08:16.8697
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tofIBWR6c4PNixwJIg3lzA3n7jxF8IqWgAeOsUqkcM8JPIuQrNFi0CtVhC+K5V5NGxOF9IbqYRz2wcBb9aZuvaSUZK+NT21kxJURHgICDHo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6723
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Terry Bowman wrote:
> The CXL driver plans to use cper_print_aer() for restricted CXL host (RCH)
> logging. This is not currently possible if CXL is built as a loadable
> module because cper_print_aer() depends on cper_mem_err_unpack() which
> is not exported.
> 
> Export cper_mem_err_unpack() to enable cper_print_aer() usage in
> CXL and other loadable modules.
> 
> Signed-off-by: Terry Bowman <terry.bowman@amd.com>
> Cc: Ard Biesheuvel <ardb@kernel.org>
> Cc: linux-efi@vger.kernel.org
> ---
>  drivers/firmware/efi/cper.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/firmware/efi/cper.c b/drivers/firmware/efi/cper.c
> index 35c37f667781..ff15e12160ae 100644
> --- a/drivers/firmware/efi/cper.c
> +++ b/drivers/firmware/efi/cper.c
> @@ -350,6 +350,7 @@ const char *cper_mem_err_unpack(struct trace_seq *p,
>  
>  	return ret;
>  }
> +EXPORT_SYMBOL_GPL(cper_mem_err_unpack);

Looks ok to me. You could make it:

EXPORT_SYMBOL_NS_GPL(cper_mem_err_unpack, CXL)

...to make it clear that this is really only meant to be consumed by the
CXL subsystem. That was also the approach taken with the otherwise
internal-only insert_resource_expand_to_fit() symbol.