Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp4650593rwe; Mon, 17 Apr 2023 16:34:38 -0700 (PDT) X-Google-Smtp-Source: AKy350bGYSbOTp42RhLQgMid53La8UIKrRMbAZapVVKKlpbwDMCG/eozY6y5jJ3lJ9/aeKKFn6Dl X-Received: by 2002:a05:6a20:304a:b0:ec:22ab:ba51 with SMTP id 10-20020a056a20304a00b000ec22abba51mr15461970pzx.51.1681774478213; Mon, 17 Apr 2023 16:34:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681774478; cv=none; d=google.com; s=arc-20160816; b=xsN+x2kwVuR9XNnrHMPwvVS7EGxbVETbJ1YOhQZUzHNoJCdJQz5K2kOvDgKkb6ujur vU2PpY8u7eLC0JvghO9zp0HqYBOL2pegiH935CmjrNTvoMQ2mQvu9rLFyWZb29PEW1M8 hKenQPR13ugk3RA2WW9YSsztx2A+d6CXL0FrlADve5u3ofkRdI1jb2WZOb0GzxsAigal JWVZ0k4YQxbYqn4LHb2yvjwUJqcI8tYCIxqH00U6DIkLdZ2qLJd6ZUvfH73RFN8moAcB xG5GYbx7e5/X9vddK54SELOsQQia9d3c6+Iiuq5TsRBrTynmJc2Q6GcE5bgxGE3s5E2D VMDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:reply-to:message-id:subject:cc:to:from:date :dkim-signature:dkim-signature; bh=leTQL18F1Tn2ybzMbvoVO+R6xEzsqFDUeQlVzIbDOTg=; b=Hzdc5jBaosS18fXsj6qqoWddjvyCS6AaKPI1bhq8rk3X3nyqW5r99Wi0/3xke7zZuC F1HVYO7rJjhbSb/l7vciblmq+Lib9NhSP6yO+VZzCHUj6NRYDnUzYubOHtKuQxq0N/lq SsLKvESwUQHRjVlYCX2HBP+/wedhziTtiia2qpA4ErdFAYRGIwA7i05p9aRHsayz54CO tsYtqFHUN5XPqEBQv8BYUX8S41O0f/w4LAU9VtozbRfzY4aSj6r+J6LUtog1J2GS2rXe 1pvYN6Prry2OVs1yRToH+unNWafTDk6dSbqVJjEZe4aXNnk9nHy6AyEQpDwMB0TnZyQU D5Ng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b="I/dTBagn"; dkim=neutral (no key) header.i=@suse.cz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u64-20020a638543000000b005023dfa3c68si13351847pgd.145.2023.04.17.16.34.24; Mon, 17 Apr 2023 16:34:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b="I/dTBagn"; dkim=neutral (no key) header.i=@suse.cz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230232AbjDQXeR (ORCPT + 99 others); Mon, 17 Apr 2023 19:34:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229585AbjDQXeN (ORCPT ); Mon, 17 Apr 2023 19:34:13 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72AF64C1C; Mon, 17 Apr 2023 16:34:05 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 250B61F8AE; Mon, 17 Apr 2023 23:34:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1681774444; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=leTQL18F1Tn2ybzMbvoVO+R6xEzsqFDUeQlVzIbDOTg=; b=I/dTBagnPt5dvYY8IN+XEdaKVuAcq1XnqegniPo4wSRgHotkAmBgmh2XlN5HYBXy00JtQ+ efEzemBcqwHFFmPUC61RmZX/KCvBSko9j2pSliPxUIYBeU+UOKRdQpXlwvAy940LOLhNNZ ZEDDlW1dlh/lePpRhPUwOMlyWGI2H0c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1681774444; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=leTQL18F1Tn2ybzMbvoVO+R6xEzsqFDUeQlVzIbDOTg=; b=vcGbpc6uunKg/9hLcHU96HOVIcM/9nSncirZ8AIEw7Wmr2FM3eG15axCdVfRVkAepJsVlF cN+7Z19xl1CNr5Bw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DFF4713319; Mon, 17 Apr 2023 23:34:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id CsbZNWvXPWQRGAAAMHmgww (envelope-from ); Mon, 17 Apr 2023 23:34:03 +0000 Date: Tue, 18 Apr 2023 01:33:55 +0200 From: David Sterba To: xiaoshoukui Cc: clm@fb.com, josef@toxicpanda.com, dsterba@suse.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, xiaoshoukui Subject: Re: [PATCH v2] btrfs: ioctl: ASSERT in btrfs_exclop_balance should also check for NONE and BALANCE PAUSED status. Message-ID: <20230417233355.GQ19619@twin.jikos.cz> Reply-To: dsterba@suse.cz References: <20230413095507.10620-1-xiaoshoukui@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230413095507.10620-1-xiaoshoukui@gmail.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 13, 2023 at 05:55:07AM -0400, xiaoshoukui wrote: > Cocurrently issue add device requests, btrfs_exclop_balance in > btrfs_ioctl_add_dev can race to btrfs_exclop_finish or itself. > > Link: https://lore.kernel.org/linux-btrfs/20230324031611.98986-1-xiaoshoukui@gmail.com/ I've combined both patches into one and updated the changelog. > > --- If you write the above --- then 'git am' drops the rest until the diff, this part is meant for version-to-version changelog as you did it but it also has information that should have been in the changelog. Added to misc-next, thanks.