Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3251d8e89d5f047784149419c5bff7c0.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <ce6c952b-2e2b-67d9-5023-e740ed798758@quicinc.com>
References: <20230303092859.22094-1-quic_tdas@quicinc.com> <20230303092859.22094-2-quic_tdas@quicinc.com> <CAA8EJpq5xBF=Wt-1_hGR-7qZHREcALurmR4ucmMmZaC-R_7Ttg@mail.gmail.com> <ce6c952b-2e2b-67d9-5023-e740ed798758@quicinc.com>
Subject: Re: [PATCH 1/2] clk: qcom: common: Handle invalid index error
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     Andy Gross <agross@kernel.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org
To:     Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        Taniya Das <quic_tdas@quicinc.com>
Date:   Mon, 17 Apr 2023 16:40:16 -0700
User-Agent: alot/0.10
Precedence: bulk

Quoting Taniya Das (2023-04-16 21:40:48)
> Hi Dmitry,
>=20
> Thanks for the comments.
>=20
>=20
> On 3/3/2023 4:14 PM, Dmitry Baryshkov wrote:
> > On Fri, 3 Mar 2023 at 11:30, Taniya Das <quic_tdas@quicinc.com> wrote:
> >>
> >> Introduce start_index to handle invalid index error
> >> seen when there are two clock descriptors assigned
> >> to the same clock controller.
> >=20
> > Please provide details of the exact case that you are trying to solve
> > (this might go to the cover letter). I think the commit message is
> > slightly misleading here. Are you trying to add error messages or to
> > prevent them from showing up?
> >=20
>=20
> We are trying to avoid error messages from showing up.
>=20
> > I'm asking because error messages do not seem to correspond to patch
> > 2. You add start_index to make the kernel warn for the clock indices
> > less than LPASS_AUDIO_CC_CDIV_RX_MCLK_DIV_CLK_SRC =3D 4, while quoted
> > messages show indices 5,6,7.
> >=20
>=20
> Right, we want the kernel to warn if the clock index is less than=20
> start_index, along with that we also want to handle the case where=20
> num_rclks is uninitialized because of same clock descriptor being=20
> assigned to two clock controllers.

The start_index should be 0.