Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
Subject: [PATCH v4 7/7] x86/resctrl: Add debug files when mounted with debug
 option
From:   Babu Moger <babu.moger@amd.com>
To:     <corbet@lwn.net>, <reinette.chatre@intel.com>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>, <babu.moger@amd.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>, <christophe.leroy@csgroup.eu>,
        <pawan.kumar.gupta@linux.intel.com>, <jarkko@kernel.org>,
        <adrian.hunter@intel.com>, <quic_jiles@quicinc.com>,
        <peternewman@google.com>, <babu.moger@amd.com>
Date:   Mon, 17 Apr 2023 18:35:10 -0500
Message-ID: <168177451010.1758847.568218491528297451.stgit@bmoger-ubuntu>
In-Reply-To: <168177435378.1758847.8317743523931859131.stgit@bmoger-ubuntu>
References: <168177435378.1758847.8317743523931859131.stgit@bmoger-ubuntu>
User-Agent: StGit/1.1.dev103+g5369f4c
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2023 23:35:14.3024
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 8b602508-6733-48a4-b8d8-08db3f9c64ed
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT027.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8239
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Add the debug files to the resctrl hierarchy.=0A=
=0A=
Signed-off-by: Babu Moger <babu.moger@amd.com>=0A=
---=0A=
 arch/x86/kernel/cpu/resctrl/internal.h |    1 +=0A=
 arch/x86/kernel/cpu/resctrl/rdtgroup.c |   54 ++++++++++++++++++++++++++++=
+++-=0A=
 2 files changed, 54 insertions(+), 1 deletion(-)=0A=
=0A=
diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/r=
esctrl/internal.h=0A=
index 1eac07ebc31b..855109abb480 100644=0A=
--- a/arch/x86/kernel/cpu/resctrl/internal.h=0A=
+++ b/arch/x86/kernel/cpu/resctrl/internal.h=0A=
@@ -288,6 +288,7 @@ struct rdtgroup {=0A=
 #define RFTYPE_TOP			BIT(4)=0A=
 #define RFTYPE_RES_CACHE		BIT(5)=0A=
 #define RFTYPE_RES_MB			BIT(6)=0A=
+#define RFTYPE_DEBUG			BIT(7)=0A=
 #define RFTYPE_CTRL_INFO		(RFTYPE_INFO | RFTYPE_CTRL)=0A=
 #define RFTYPE_MON_INFO			(RFTYPE_INFO | RFTYPE_MON)=0A=
 #define RFTYPE_TOP_INFO			(RFTYPE_INFO | RFTYPE_TOP)=0A=
diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/r=
esctrl/rdtgroup.c=0A=
index 15ded0dd5b09..1ec4359348c2 100644=0A=
--- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c=0A=
+++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c=0A=
@@ -1880,6 +1880,7 @@ static struct rftype res_common_files[] =3D {=0A=
 		.mode		=3D 0444,=0A=
 		.kf_ops		=3D &rdtgroup_kf_single_ops,=0A=
 		.seq_show	=3D rdtgroup_rmid_show,=0A=
+		.fflags		=3D RFTYPE_BASE | RFTYPE_DEBUG,=0A=
 	},=0A=
 	{=0A=
 		.name		=3D "schemata",=0A=
@@ -1909,6 +1910,7 @@ static struct rftype res_common_files[] =3D {=0A=
 		.mode		=3D 0444,=0A=
 		.kf_ops		=3D &rdtgroup_kf_single_ops,=0A=
 		.seq_show	=3D rdtgroup_closid_show,=0A=
+		.fflags		=3D RFTYPE_CTRL_BASE | RFTYPE_DEBUG,=0A=
 	},=0A=
 =0A=
 };=0A=
@@ -2420,6 +2422,49 @@ static int mkdir_mondata_all(struct kernfs_node *par=
ent_kn,=0A=
 			     struct rdtgroup *prgrp,=0A=
 			     struct kernfs_node **mon_data_kn);=0A=
 =0A=
+static void resctrl_add_debug_files(void)=0A=
+{=0A=
+	struct rftype *rfts, *rft;=0A=
+	int len;=0A=
+=0A=
+	rfts =3D res_common_files;=0A=
+	len =3D ARRAY_SIZE(res_common_files);=0A=
+=0A=
+	lockdep_assert_held(&rdtgroup_mutex);=0A=
+=0A=
+	for (rft =3D rfts; rft < rfts + len; rft++) {=0A=
+		if (rft->fflags & RFTYPE_DEBUG) {=0A=
+			rft->fflags &=3D ~RFTYPE_DEBUG;=0A=
+			rdtgroup_add_file(rdtgroup_default.kn, rft);=0A=
+		}=0A=
+	}=0A=
+=0A=
+	kernfs_activate(rdtgroup_default.kn);=0A=
+}=0A=
+=0A=
+static void resctrl_remove_debug_files(void)=0A=
+{=0A=
+	struct rftype *rfts, *rft;=0A=
+	int len;=0A=
+=0A=
+	rfts =3D res_common_files;=0A=
+	len =3D ARRAY_SIZE(res_common_files);=0A=
+=0A=
+	lockdep_assert_held(&rdtgroup_mutex);=0A=
+=0A=
+	for (rft =3D rfts; rft < rfts + len; rft++) {=0A=
+		if (!strcmp(rft->name, "mon_hw_id")) {=0A=
+			rft->fflags |=3D RFTYPE_DEBUG;=0A=
+			kernfs_remove_by_name(rdtgroup_default.kn, rft->name);=0A=
+		} else if (!strcmp(rft->name, "ctrl_hw_id")) {=0A=
+			rft->fflags |=3D RFTYPE_DEBUG;=0A=
+			kernfs_remove_by_name(rdtgroup_default.kn, rft->name);=0A=
+		}=0A=
+	}=0A=
+=0A=
+	kernfs_activate(rdtgroup_default.kn);=0A=
+}=0A=
+=0A=
 static int rdt_enable_ctx(struct rdt_fs_context *ctx)=0A=
 {=0A=
 	int ret =3D 0;=0A=
@@ -2433,8 +2478,10 @@ static int rdt_enable_ctx(struct rdt_fs_context *ctx=
)=0A=
 	if (!ret && ctx->enable_mba_mbps)=0A=
 		ret =3D set_mba_sc(true);=0A=
 =0A=
-	if (!ret && ctx->enable_debug)=0A=
+	if (!ret && ctx->enable_debug) {=0A=
 		resctrl_debug =3D true;=0A=
+		resctrl_add_debug_files();=0A=
+	}=0A=
 =0A=
 	return ret;=0A=
 }=0A=
@@ -2851,6 +2898,11 @@ static void rdt_kill_sb(struct super_block *sb)=0A=
 =0A=
 	set_mba_sc(false);=0A=
 =0A=
+	if (resctrl_debug) {=0A=
+		resctrl_remove_debug_files();=0A=
+		resctrl_debug =3D false;=0A=
+	}=0A=
+=0A=
 	/*Put everything back to default values. */=0A=
 	for_each_alloc_capable_rdt_resource(r)=0A=
 		reset_all_ctrls(r);=0A=
=0A=