Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp4667354rwe; Mon, 17 Apr 2023 16:58:07 -0700 (PDT) X-Google-Smtp-Source: AKy350a9mQTU6z2m/L8fpVv30gqb36ifp426emuaQZ1Rez37OdaE5JiV3nqmFSaV8i6d7NLYxi67 X-Received: by 2002:a17:902:b603:b0:1a6:8ee3:4e2e with SMTP id b3-20020a170902b60300b001a68ee34e2emr294060pls.33.1681775886911; Mon, 17 Apr 2023 16:58:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681775886; cv=none; d=google.com; s=arc-20160816; b=uXb+OycMKF7mTzrbH1Khcnq+2r50N6zgvry/HLG6B7rmHQXG7yZVLwGHf1yd0NPrqF +qyhKL4cMoosQqJdArI9gnC+yOrb0IdbwTm3YqyitJ/FSHcGZqVSRkRJtMHxyAH76f0H D+yS1NV+BbDkKo59v7EbH7KqMXdOapEQZVZOPcazC5vk3Fnu75/Q/Y8zsa4RjmCHzRF8 5hhtp7b/h/2e9pSAzQ/Bu4x1NSO2qUFKKFHAmspJXE8KZGixFaWKCWsp76RmIOul9ybU L9QtiIDbyAZfwrrFrWMDNsWwA8lmNZzNW1lf/gvX39ATpvAZlapoaZwkr/h7J4KF5vGC t1xQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :organization:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:dkim-signature; bh=lWG3Qdb/aZXtMHHzC1Q6FZgfp9P80Q7W9wBJ5IDgS4I=; b=G66SQQYQ62mF0WmY2ziqdvSazXfydzsN3qzKs4qLr0ZfA6SW9mgP0Vnd0/M1hpA9qi 6DsWPOI0zfmiZmoxyZlRUah0oMv5E3tw7GSbdogD5u6n5yO3Fx6LvOyDjjrHKiBY741L 23/6qNnLzh6bBeguwGz8M8KR+g8linXo+aGuru6+M4nlQJRlBoqJq3MWYTHl8C7Q3Udk VETGvnsvGMSpzbZUKrUM90+6REdA6Gjqat9Cyjy2lYMtdW2lmOFgoNgqNUQnQdrVc0CW wLsafJxi8FOwJQwVsAvXCNw9Arx7l+UEGf3Kds68FFOmrIDBQBlthorJsREyX7+eYuOq L5Dg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="U/iWFNH+"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k21-20020a170902761500b001a511254836si12248715pll.89.2023.04.17.16.57.53; Mon, 17 Apr 2023 16:58:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="U/iWFNH+"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230049AbjDQX4h (ORCPT + 99 others); Mon, 17 Apr 2023 19:56:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229521AbjDQX4f (ORCPT ); Mon, 17 Apr 2023 19:56:35 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9125A358C; Mon, 17 Apr 2023 16:56:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2284262B2E; Mon, 17 Apr 2023 23:56:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2ED88C433D2; Mon, 17 Apr 2023 23:56:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681775793; bh=PGgTtILCYnLtdEs+1dge80PZEeOVNXxB1Mp2goVVWBU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=U/iWFNH+L08ZbmtVqtvGe3vwYUVDrmI+tTXOJr/M9nBRnClsCRrhcBQtu1pD7Nn9D 0xjHrND9YWAVXp983k6ublL//L60Aib3NsfXWPDalH1AeyS2wTSeOPKZSyziCG87HP g7ekDdlntegrEj3qTUb2WGLA2Wpb+Kmnj+83knvyGinUKzy1YXmDmU3HvZPUEI13U1 R/g/CgTmloJt0PGKcSmrAgZeKh480w2YxwYcXPIaBzimLzwgeGtiesCaneGtejzRMz v3OYBI8SC4y9J/QX6ZFQ0PPbRUCft2BueTrwCUH4ymKPAYvbp01Z7EGzUbSEIiA7VF UrnqD1lKXRRXQ== Message-ID: <473b7647-58ee-9a4c-b910-f22f778a058e@kernel.org> Date: Tue, 18 Apr 2023 08:56:29 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 09/11] PCI: rockchip: Use u32 variable to access 32-bit registers Content-Language: en-US To: Rick Wertenbroek , alberto.dassatti@heig-vd.ch Cc: xxm@rock-chips.com, stable@vger.kernel.org, Shawn Lin , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Rob Herring , Bjorn Helgaas , Krzysztof Kozlowski , Heiko Stuebner , Caleb Connolly , Johan Jonker , Brian Norris , Corentin Labbe , Arnaud Ferraris , Sascha Hauer , Judy Hsiao , Hugh Cole-Baker , linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230417092631.347976-1-rick.wertenbroek@gmail.com> <20230417092631.347976-10-rick.wertenbroek@gmail.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20230417092631.347976-10-rick.wertenbroek@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/17/23 18:26, Rick Wertenbroek wrote: > Previously u16 variables were used to access 32-bit registers, this > resulted in not all of the data being read from the registers. Also > the left shift of more than 16-bits would result in moving data out > of the variable. Use u32 variables to access 32-bit registers > > Fixes: cf590b078391 ("PCI: rockchip: Add EP driver for Rockchip PCIe controller") > Cc: stable@vger.kernel.org > Signed-off-by: Rick Wertenbroek > Tested-by: Damien Le Moal Looks good. Reviewed-by: Damien Le Moal