Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 17 Apr 2023 17:08:13 -0700
From:   "Darrick J. Wong" <djwong@kernel.org>
To:     ye.xingchen@zte.com.cn
Cc:     dchinner@redhat.com, linux-xfs@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: scrub: remove duplicate include headers
Message-ID: <20230418000813.GB360889@frogsfrogsfrogs>
References: <202304171613075788124@zte.com.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202304171613075788124@zte.com.cn>
Precedence: bulk

On Mon, Apr 17, 2023 at 04:13:07PM +0800, ye.xingchen@zte.com.cn wrote:
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
> 
> xfs_trans_resv.h and xfs_mount.h are included more than once.
> 
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
> ---
>  fs/xfs/scrub/health.c   | 2 --
>  fs/xfs/scrub/refcount.c | 2 --
>  2 files changed, 4 deletions(-)
> 
> diff --git a/fs/xfs/scrub/health.c b/fs/xfs/scrub/health.c
> index d2b2a1cb6533..66e99b0f6049 100644
> --- a/fs/xfs/scrub/health.c
> +++ b/fs/xfs/scrub/health.c
> @@ -7,8 +7,6 @@
>  #include "xfs_fs.h"
>  #include "xfs_shared.h"
>  #include "xfs_format.h"
> -#include "xfs_trans_resv.h"
> -#include "xfs_mount.h"
>  #include "xfs_btree.h"
>  #include "xfs_trans_resv.h"
>  #include "xfs_mount.h"

The convention (AFAICT) for include order is xfs_trans_resv -> xfs_mount
-> xfs_btree.h...

> diff --git a/fs/xfs/scrub/refcount.c b/fs/xfs/scrub/refcount.c
> index ed5eb367ce49..04d216261f36 100644
> --- a/fs/xfs/scrub/refcount.c
> +++ b/fs/xfs/scrub/refcount.c

Please check the list before sending duplicate diffs.

--D

> @@ -7,8 +7,6 @@
>  #include "xfs_fs.h"
>  #include "xfs_shared.h"
>  #include "xfs_format.h"
> -#include "xfs_trans_resv.h"
> -#include "xfs_mount.h"
>  #include "xfs_btree.h"
>  #include "xfs_rmap.h"
>  #include "xfs_refcount.h"
> -- 
> 2.25.1