Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 17 Apr 2023 17:08:33 -0700
From:   Alexei Starovoitov <alexei.starovoitov@gmail.com>
To:     Feng zhou <zhoufeng.zf@bytedance.com>
Cc:     martin.lau@linux.dev, ast@kernel.org, daniel@iogearbox.net,
        andrii@kernel.org, song@kernel.org, yhs@fb.com,
        john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com,
        haoluo@google.com, jolsa@kernel.org, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        mykolal@fb.com, shuah@kernel.org, bpf@vger.kernel.org,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        linux-kselftest@vger.kernel.org, yangzhenze@bytedance.com,
        wangdongdong.6@bytedance.com, zhouchengming@bytedance.com
Subject: Re: [PATCH 1/2] bpf: support access variable length array of integer
 type
Message-ID: <20230418000833.keqhb7kdpibgaodt@dhcp-172-26-102-232.dhcp.thefacebook.com>
References: <20230417080749.39074-1-zhoufeng.zf@bytedance.com>
 <20230417080749.39074-2-zhoufeng.zf@bytedance.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230417080749.39074-2-zhoufeng.zf@bytedance.com>
Precedence: bulk

On Mon, Apr 17, 2023 at 04:07:48PM +0800, Feng zhou wrote:
> From: Feng Zhou <zhoufeng.zf@bytedance.com>
> 
> After this commit:
> bpf: Support variable length array in tracing programs (9c5f8a1008a1)
> Trace programs can access variable length array, but for structure
> type. This patch adds support for integer type.
> 
> Example:
> Hook load_balance
> struct sched_domain {
> 	...
> 	unsigned long span[];
> }
> 
> The access: sd->span[0].

The use case makes sense.
Please add it as a selftest. Either combine it with patch 2 or another patch 3.
and then resubmit.
Make sure to use [PATCH bpf-next] subject, so BPF CI knows how to test it.