Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0fe42faa3b34f82cc2fb73ae61460bf2.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20230417-bolster-vitality-89d279146497@wendy>
References: <20230417074115.30786-1-hal.feng@starfivetech.com> <20230417074115.30786-2-hal.feng@starfivetech.com> <20230417-buckwheat-wilt-92a4e85a5ca0@wendy> <83c5a35a-c646-cbc7-83f9-c02fcb24e069@starfivetech.com> <20230417-bolster-vitality-89d279146497@wendy>
Subject: Re: [PATCH v1 1/2] clk: starfive: Fix RESET_STARFIVE_JH7110 can't be selected in a specified case
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     linux-clk@vger.kernel.org, oe-kbuild-all@lists.linux.dev,
        linux-mm@kvack.org, Michael Turquette <mturquette@baylibre.com>,
        Paul Gazzillo <paul@pgazz.com>,
        Necip Fazil Yildiran <fazilyildiran@gmail.com>,
        Emil Renner Berthing <emil.renner.berthing@canonical.com>,
        Xingyu Wu <xingyu.wu@starfivetech.com>,
        linux-kernel@vger.kernel.org
To:     Conor Dooley <conor.dooley@microchip.com>,
        Hal Feng <hal.feng@starfivetech.com>
Date:   Mon, 17 Apr 2023 17:22:01 -0700
User-Agent: alot/0.10
Precedence: bulk

Quoting Conor Dooley (2023-04-17 03:18:35)
> On Mon, Apr 17, 2023 at 06:06:29PM +0800, Hal Feng wrote:
> > On Mon, 17 Apr 2023 10:54:09 +0100, Conor Dooley wrote:
> > > On Mon, Apr 17, 2023 at 03:41:14PM +0800, Hal Feng wrote:
> > >> When (ARCH_STARFIVE [=3Dn] && COMPILE_TEST [=3Dy] && RESET_CONTROLLE=
R [=3Dn]),
> > >> RESET_STARFIVE_JH7110 can't be selected by CLK_STARFIVE_JH7110_SYS
> > >> and CLK_STARFIVE_JH7110_AON.
> > >>=20
> > >> Considering RESET_STARFIVE_JH7110 is not a necessary option for comp=
ilation
> > >> test, we should select it only if ARCH_STARFIVE=3Dy. Also, delete re=
dundant
> > >> selected options of CLK_STARFIVE_JH7110_AON because these options are
> > >> already selected by the dependency.
> > >>=20
> > >> Fixes: edab7204afe5 ("clk: starfive: Add StarFive JH7110 system cloc=
k driver")
> > >> Fixes: b2ab3c94f41f ("clk: starfive: Add StarFive JH7110 always-on c=
lock driver")
> > >> Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
> > >> ---
> > >>  drivers/clk/starfive/Kconfig | 5 +----
> > >>  1 file changed, 1 insertion(+), 4 deletions(-)
> > >>=20
> > >> diff --git a/drivers/clk/starfive/Kconfig b/drivers/clk/starfive/Kco=
nfig
> > >> index 71c1148ee5f6..3fad4adee841 100644
> > >> --- a/drivers/clk/starfive/Kconfig
> > >> +++ b/drivers/clk/starfive/Kconfig
> > >> @@ -26,7 +26,7 @@ config CLK_STARFIVE_JH7110_SYS
> > >>    depends on ARCH_STARFIVE || COMPILE_TEST
> > >>    select AUXILIARY_BUS
> > >>    select CLK_STARFIVE_JH71X0
> > >> -  select RESET_STARFIVE_JH7110
> > >> +  select RESET_STARFIVE_JH7110 if ARCH_STARFIVE
> > >=20
> > > Hmm, I don't really follow the logic above.
> > > Why not just make the if be `if RESET_CONTROLLER` rather than
> > > ARCH_STARFIVE?
> > > I'm probably missing some obvious reason why not.
> >=20
> > Note that RESET_CONTROLLER is selected by ARCH_STARFIVE. Thanks.
>=20
> Aye, just the explicit dependency seems like it'd be less fragile and
> more obvious in the future.

Agreed. Be explicit so we don't have to hunt down select dependencies.