Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp4699756rwe; Mon, 17 Apr 2023 17:34:13 -0700 (PDT) X-Google-Smtp-Source: AKy350Yb79qWrweU3UslpTJ2q7Bh5afqpA7utPXG91/HnuFbFcOK3F7kJ+uabBTQAcke3zkqf1v0 X-Received: by 2002:a17:902:7891:b0:1a1:bf22:2b6e with SMTP id q17-20020a170902789100b001a1bf222b6emr325822pll.43.1681778053616; Mon, 17 Apr 2023 17:34:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681778053; cv=none; d=google.com; s=arc-20160816; b=mJNXYmGl17HQG5eGbWWbk8QR4v//qaSNqrRBt7MZa5WGpQhMfffeTr2sdnzq2Ct2Cs 4Odo5Uy+0V1qU1MEYGPi3pHAXDG7K9U6dkTVUa6hnKeLMqQkRgDyGQRiUZz9w8qcYoOr Pioc8E6YXqjMhAujQQcgXWPd9/st626AGW/dZdMOhMEUu+8NALAoabtNPye1aGlr9UjD 5xQly6oKKS404u3gJh69aryn0IXbP/cYnOzq4VwCLwC8dGEcaaUa3thSH+T7V6jLG/21 6nSdwk7V5ypKqD/5kuAIy+9vUEVZt80VOVD2Ds9Y3aFyT63gsxb2wst7il57kNPkCS7t bxHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:date:to:cc:from:subject:references :in-reply-to:content-transfer-encoding:mime-version:message-id :dkim-signature; bh=ZmFwJ7m5ZLxH+t58ZzfiJLOLdybzzWisxpx1qHDzVPU=; b=XzVGbNBUap7yI/Qgkk81aMbVI31LSJRshRG6tVFtjAmE8b4GP2QwDIjFv9sKoPDA4Y MKvf4+B50+0PAxA+R881i30bYXyVBT064Y/jKHDPurVK5kEUKDIDAJBIz+V52FtpAgNn saOOZxicw6zaTNkZlAUKEuM/W22XWo7Mw3cJI5awq5CYD8dMizi6aRqab29Hzll6Us/q /zSEjSsvUPE8UHY62UbDIODNU6XSUVlSX+yLrtiP9vQ2ZOwVVLZ9nHeuWbtXZERTp7xS l1Yk1+/1Ne0kdPW/0eDOT5ylvythCGldwYblJYZk/M3KBW7BhxJ20p2lRQOohYICs7Xr U0uQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qksOjS7U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u13-20020a170902e80d00b0019e3ffa255asi172180plg.184.2023.04.17.17.34.02; Mon, 17 Apr 2023 17:34:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qksOjS7U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229521AbjDRAaY (ORCPT + 99 others); Mon, 17 Apr 2023 20:30:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229479AbjDRAaW (ORCPT ); Mon, 17 Apr 2023 20:30:22 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F243F1733; Mon, 17 Apr 2023 17:30:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8D52662B14; Tue, 18 Apr 2023 00:30:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB852C433D2; Tue, 18 Apr 2023 00:30:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681777820; bh=ZmFwJ7m5ZLxH+t58ZzfiJLOLdybzzWisxpx1qHDzVPU=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=qksOjS7UehQHQU48wzAd/nTyFi31TTsNEgEIWIKQGpsxL2pE8hf/dsvnj0/Jcqjp8 Vfineigagj/H2n+uleVsWnN8FPBxtpzGdFGz8Em4SnTJBpcV9yIcBDUNwuemcDSCYd 2WykdHQLpI2Mg02n8TPm5sysYZ0e9bGHJyUSb25fdoBg9DmXPRIeQrps4ULCRzTydQ lceiWuzffBWt2lyYjxWIgIvUGL5Odt7WXCUv/soBT/6/CEmA5xGZzpXp6qRWC+WlIE bx0RXZoxQeRvjv2Pq7g6bm1tn5cosbH1GUgPzNqjUrUvoDGhQD+93ld7ltPUX9e9VO Yfln7MbSen6Uw== Message-ID: <866ffea2459ba57328afa800a30421b4.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <2aa668e3-d065-7376-5d41-ef855afa8518@starfivetech.com> References: <20230413205528.4044216-1-sboyd@kernel.org> <2aa668e3-d065-7376-5d41-ef855afa8518@starfivetech.com> Subject: Re: [PATCH] clk: starfive: Avoid casting iomem pointers From: Stephen Boyd Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, patches@lists.linux.dev, Tommaso Merciai , Emil Renner Berthing , Conor Dooley To: Hal Feng , Michael Turquette , Xingyu Wu Date: Mon, 17 Apr 2023 17:30:18 -0700 User-Agent: alot/0.10 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Hal Feng (2023-04-14 16:31:45) >=20 > Thanks for your fix to my previous patches, and I have tested this patch > on VisionFive 2 board. As Xingyu said above, I think dev_set_drvdata() > should also be dropped in clk-starfive-jh7110-sys.c and > clk-starfive-jh7110-aon.c. >=20 Sure. I see you sent the patch. Thanks.