Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp4737454rwe; Mon, 17 Apr 2023 18:18:57 -0700 (PDT) X-Google-Smtp-Source: AKy350bxHCTGJJtbGNcXcn5Q0OcmdI4tBDjtcWwrhDZgoPp1rtkPyWeftgdydaMbRT5qbEeZl6i/ X-Received: by 2002:a05:6a21:3703:b0:f0:7b8:c77b with SMTP id yl3-20020a056a21370300b000f007b8c77bmr3458410pzb.59.1681780737400; Mon, 17 Apr 2023 18:18:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681780737; cv=none; d=google.com; s=arc-20160816; b=LYeXjZlXn6pq4VL2NgCl4ljHlzJBd0Xe/dsb7EUBgx4GlJHT9une9UrB5CwCk10CXi w8fT5bwGTqplJaI8kMC2qKVjH9fkm3NkgsFQA3no59B0QOhs6KccqpAR8znagIxapfaU Q7AAc4oHqkmtzQTWtrwKSv0pDkrbV/8gLqdsHF4fhx/w1KaHD1VXZeGR1zU3wbPHFSV0 4PCv5eisGKQvWo27GKOmB6bZlSgqbqkEHuZOtZEGv97qAhjhm41ScX5tdmmcdoudUCIG jWZ5JTn3c/7WQtjR9Yi5OWkf6W6I/Rl9Ug2/4BpVpE5PXqpG4dq4HH44Z9ecdODQkn0N Jgcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=ehjtmKUpNEJvBLVAPwVUUjiB3w/KVArKmubWpysBZUo=; b=volomthoDkkQNeW3nN8PJ8f7M0N/9AOis2gHvxp1fCM3VdOL9OAG3jchCIiPura81N o7AZRLpruy+nU5i+DRzqbhPJ9PUXH4/t0idfkTiv2WXClm0vhpxffJ68o6T1/t6ZPlan 0Wz8ZQJY4ClBKuOW8LgQ6xiAVbHN4GH5M3zh7GxpZJI2LX1zPyG4HUWAAG8/59h1GZQJ nMbNwkzAj/ACeAPakRYbrUekRdeuJF8G6z5haSx/b6gKn+tBWig3fbTThmCozBy9G+Hi AH6y5EZpzU8eQ/JVv7IHZN+Ceu4JjdXz85TcG/OEU/CJ7yyDt/9LbBsmaULJJYkIwpOO g93w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gentoo.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e127-20020a636985000000b00503016f280dsi13560776pgc.823.2023.04.17.18.18.46; Mon, 17 Apr 2023 18:18:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gentoo.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230245AbjDRBR3 (ORCPT + 99 others); Mon, 17 Apr 2023 21:17:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230037AbjDRBR1 (ORCPT ); Mon, 17 Apr 2023 21:17:27 -0400 Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F03E340E6; Mon, 17 Apr 2023 18:17:26 -0700 (PDT) From: Patrick McLean To: linux-kernel@vger.kernel.org Cc: linux-ide@vger.kernel.org, Bjorn Helgaas , linux-pci@vger.kernel.org, Dave Airlie , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: Apply ATI NCQ horkage to ASPEED as well Date: Mon, 17 Apr 2023 18:17:18 -0700 Message-Id: <20230418011720.3900090-1-chutzpah@gentoo.org> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We have some machines with ASPEED SATA controllers, and are seeing the same NCQ issues that ATI controllers (I am not sure if it's a rebranded ATI controller, or they both have some faulty implementation). This NCQ breakage is consistent across a few different types of drives. Instead of maintaining a list of drives that are broken with ASPEED controllers as well as AIT, let's just treat ASPEED controllers like ATI ones, and disable NCQ on drives that have ATA_HORKAGE_NO_NCQ_ON_ATI set on them. To do this first, we have to make move the definition of the ASPEED vendor from the ast drm driver to the PCI subsystem.