Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp4776987rwe; Mon, 17 Apr 2023 19:10:41 -0700 (PDT) X-Google-Smtp-Source: AKy350ZSVj1Cz3nHlZM1EjOBmqVd4XNKhb7SVDH5ZDvks65dT/k9cWvY0XC+l4ATNi6szqCTWSKp X-Received: by 2002:a17:90a:604e:b0:234:f77:d6d2 with SMTP id h14-20020a17090a604e00b002340f77d6d2mr402422pjm.45.1681783841572; Mon, 17 Apr 2023 19:10:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681783841; cv=none; d=google.com; s=arc-20160816; b=0oSDk+vm4pXwgBBFmCEyUFqOmbVs32r7e0IgLRiTqYXkLRHeu9kk5XdtFkdv17jqJp 4FRdhiCkK0l3UK3UHBKMWSuAzCKOj4SwY9iKTq5GX51FUpIy9b2wKm5axxjfpmTOy+0u 1bEsyuljcDs+wIBjdl1arY54sC4BS+eAXCUgMGF/tWrsIuY9AyS8bC4rW3GaUJK3oklO By/Gi8TN+1b9MPyb/pgMTTJNZDTQbort9+/lEtGO1Meh3JCCgWDyHqeNNL+bPtGvS9h1 V41e0z/HeRwiKxwdnYWLLMWL0SKoWEPGaa+eNaJtnN3H9sRHSvIBkqvQ+yr8SXtV4IpZ gbhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=ZT6T8JazTUrOY0mEHFTu/RGzheZfZZgUG7SP163oiWw=; b=Iwc/4iTRCsDWKFNRb3qW2ILTJ+//7uHU5KoN26Swl3qH8SEHrV1Ne4Jidyp7NMtnTi YeCNKz4XnbONunuPchZXXSFPoyziOp39u7F30wL78LsSLklgXUyZFhTL5OsIegF+k03s zYW1sbBvWDu8bC1BYi3MgVijfj0qaD+nC4tRzvyqGnB49U6SH53xRIIG7xherphVqjm7 UMPDZBXl4n+BXCNRpN3aMwQSr2MKoqvwgLutgB1nWxUC2MYsSny4ToMZ+LKc8CtHpiby IBOeYYHZKR93glwRRt/TYvOFHKz37MkIx8R2zj4/Zs6e/h5ZXazp7zYihRb14zOsDYWd OV5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=oIS8AdQ5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s13-20020a6550cd000000b0050bf5a43800si12591502pgp.242.2023.04.17.19.10.29; Mon, 17 Apr 2023 19:10:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=oIS8AdQ5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230492AbjDRB4H (ORCPT + 99 others); Mon, 17 Apr 2023 21:56:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230285AbjDRB4B (ORCPT ); Mon, 17 Apr 2023 21:56:01 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DFD261B4; Mon, 17 Apr 2023 18:55:24 -0700 (PDT) Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33I0IZIw018180; Tue, 18 Apr 2023 01:54:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=ZT6T8JazTUrOY0mEHFTu/RGzheZfZZgUG7SP163oiWw=; b=oIS8AdQ5k552DF8T2GFIx6H+oM74i8BJw7hoxxtudrpXrsy4fT3lzThcgfo6R6IbIgqa Eqw03+iJ22DTGHKhhjV4hB9FI0VrZOxyqQsdp+sObQvZnhxRPg2Klf/5UTBIPEqEseBE TrQ0HbMk5eauno9ukAIvG8b6WX5waqYbUzLqgIiRBRWA0p/ly0y4tK4gyc/DEKkoWVyF l98pRq3B0Fkq921nxFDS4//CfPEY/Qu45Q9peu5vRdexbUZK4s4LEcg4sE8IGek1Sneb 9sIpi7NjQK4lOXyP7sP7HECJWxE2G6q3Glj0LpNePSAayYcAbuj4BaamONMZqHvtpMiI QQ== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3q1bvkrksq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 18 Apr 2023 01:54:21 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 33I1sK5F014814 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 18 Apr 2023 01:54:20 GMT Received: from [10.110.98.241] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Mon, 17 Apr 2023 18:54:18 -0700 Message-ID: Date: Mon, 17 Apr 2023 18:54:18 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH 1/3] drm/msm/dpu: Drop unused members from HW structs Content-Language: en-US To: Marijn Suijten , Rob Clark , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter CC: <~postmarketos/upstreaming@lists.sr.ht>, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Jordan Crouse , , , , References: <20230418-dpu-drop-useless-for-lookup-v1-0-b9897ceb6f3e@somainline.org> <20230418-dpu-drop-useless-for-lookup-v1-1-b9897ceb6f3e@somainline.org> From: Abhinav Kumar In-Reply-To: <20230418-dpu-drop-useless-for-lookup-v1-1-b9897ceb6f3e@somainline.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: ws0QCnfY6to6MboIchWekFAke3Jesusg X-Proofpoint-ORIG-GUID: ws0QCnfY6to6MboIchWekFAke3Jesusg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-17_14,2023-04-17_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 mlxlogscore=623 impostorscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 suspectscore=0 clxscore=1015 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304180015 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/17/2023 4:14 PM, Marijn Suijten wrote: > Some of these members were initialized while never read, while others > were not even assigned any value at all. Drop them to save some space, > and above all confusion when looking at these members. > > Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") > Fixes: 84a33d0fd921 ("drm/msm/dpu: add dpu_hw_wb abstraction for writeback blocks") > Signed-off-by: Marijn Suijten > --- It seems like WB UBWC formats are not supported today. Because otherwise ctx->mdp would be used for writeback. I guess we can add a ubwc member similar to hw_sspp, when we do add the support for this. Hence this is, Reviewed-by: Abhinav Kumar