Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 18 Apr 2023 10:07:47 +0800
From:   Chao Gao <chao.gao@intel.com>
To:     Binbin Wu <binbin.wu@linux.intel.com>
CC:     <kvm@vger.kernel.org>, Jiaan Lu <jiaan.lu@intel.com>,
        Zhang Chen <chen.zhang@intel.com>,
        Sean Christopherson <seanjc@google.com>,
        "Paolo Bonzini" <pbonzini@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        "Ingo Molnar" <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, <x86@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v2 04/11] KVM: VMX: Add IA32_SPEC_CTRL virtualization
 support
Message-ID: <ZD37c+/9l/nbvPnr@chao-env>
References: <20230414062545.270178-1-chao.gao@intel.com>
 <20230414062545.270178-5-chao.gao@intel.com>
 <35b92d89-3eb1-368e-3804-e3ce9ad9c81f@linux.intel.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <35b92d89-3eb1-368e-3804-e3ce9ad9c81f@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?lurxUCTiFXR2VkEwW2ExxkJV7l+vAdw7yevDCeFglGxHm+SZ1NGDefu6EQ?=
 =?iso-8859-1?Q?rTapwuG0Ygxa24PxmnqvV1nvEc4BSItLg/A1FQP939H47tX4+QIxNa2R9Z?=
 =?iso-8859-1?Q?GJelfT65ecTJlrMbqgGrhm+mflbkTOFOU6dHy0A5xjZtt5hVqtXH3QhNvg?=
 =?iso-8859-1?Q?bSqAHD+mRjEdDbI/mHmlgDr0L6YySFXEtdn/docCxnjoqSMVgpeiOtNefc?=
 =?iso-8859-1?Q?wcuRRS2UgJfKr7Tyv2xtXPpLqYDTSdvP1pw5NVj+ttiV1KtDCggJ/t/+Yk?=
 =?iso-8859-1?Q?aY1Sn+WihVuc2Ki8kuiFhK0FsESoKDwIddXUMBVVjxc7kIdy7qbnGAcSzR?=
 =?iso-8859-1?Q?KJw7rQ/8cvh4ejRQSK5FYj+hi14YxW4UxfhtarNPzWRFvmF/5AZ2QEhiBu?=
 =?iso-8859-1?Q?3XrrrmgNA/B/aqiIAY8yzRpbRPBLemiPn9AU24TeIO6EWQ3wDPt8vo+i5w?=
 =?iso-8859-1?Q?02aV5CHh50f2sFKk2xyx9LrZzjH0QMNaXM9yXvXivjOUp5h6Ylqr1W1omi?=
 =?iso-8859-1?Q?uaPRIzrUoFG/63UWJchFC643doFB9RIsV7NkgaZVbnw1n8Rj4zmDHFM+5y?=
 =?iso-8859-1?Q?P1um8ne6lB0zISYWfO+8Y793YQqEx7FE9DsLJhD0ZqkI3wHw567EZx9fhM?=
 =?iso-8859-1?Q?XYlj/4nRD8ZKfebiD/W2h9KcKTWwx4rIEBWsgSHwtOHuC1K6mWnK05hraL?=
 =?iso-8859-1?Q?1gHL1a+WIIB73eCo/HPIRiMJzs2j58zQBaCMdnHjS429areYYiXsLdWhuq?=
 =?iso-8859-1?Q?lbborZMxzmL2pdZiFFm1sJ2c0vyc3yEqdIjvMPafjxzXpWDMFMqRt1t3Dc?=
 =?iso-8859-1?Q?QszK4bnTyzoPJ46obuZxhd8lgO/gS5MrFMlBVnTlrOub5pA2HfygXXUw53?=
 =?iso-8859-1?Q?slxU02syNlwdx4eKygHbwElxRXpNkk8WHTcIEflE7mU1iprLZ1SZhIiWdB?=
 =?iso-8859-1?Q?6JXVFC6OeXUz/IWlonDoz0zo0oNoMa3WYSEk8VHsI8GpNSpN8B0h0sbl/B?=
 =?iso-8859-1?Q?0e4ZlX+vf0b3H6AmDaQDwPonLYjqnfJkfLxiL3foKX/t18o3Y/0h5+e7mR?=
 =?iso-8859-1?Q?Fg3SEeagxmzbHShdV8g66UMLnDc4vZl5wkYoNQ7+98Mv7ZCe/bc2/VKMV4?=
 =?iso-8859-1?Q?4sAgmNrP5jurNnRxkfcdTWJGMgz4Uta2FnUAknFG1+5T8KoQrGL3rl6dFI?=
 =?iso-8859-1?Q?5tXFEb11XIxhD6mKoIdexsagie6+Vi1x+CNdOhVCZVbHcNDSqTX7vy9f59?=
 =?iso-8859-1?Q?x0WUTrB4W8Tes41QvNKZ2itM7wWhK5EqY3nPkXI8lwujt2WYO1tcA1+FAf?=
 =?iso-8859-1?Q?65sxyVfebJD8CUtG1bJNUOMAl9y2EYz5pTKaOJI+QQ2oOF+HyatFaoY/4c?=
 =?iso-8859-1?Q?+KagPiAR5SK76K0kOM/zvwVVvnwdJR4XSm1YNQTJ0vQTHh3rwuHU6T0hU5?=
 =?iso-8859-1?Q?82UqsjlMJkZ74QR45fDUuBw3ewP3/ea5mzGRSAY82MUf9fI/7oUT7WKMYg?=
 =?iso-8859-1?Q?ej9Fokz9CsXHxmRsfs/en5d+o4PmwthdBPsC71NB79cdA/526AGUAt/+MP?=
 =?iso-8859-1?Q?mNoJhZwXX0XHxKWzSYkH6ucWP1ekAz7lvCn0arUjauWKU3PGFZyOSm1WS0?=
 =?iso-8859-1?Q?+sOZkCivCaFOTICCFHgI1sCRn+gu5eJ7rk?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d77073dc-59f3-47df-ddc6-08db3fb1bba1
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB6780.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2023 02:07:59.6189
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: d2U3/dqB/Spx5aX+ZxyD5N9KjRlvz7tv/smA/p1IFsdUXePSvyfP4iE9kZ9XU9Ofxddg858duXBEXIHs37Obpw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6576
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Apr 17, 2023 at 11:17:36AM +0800, Binbin Wu wrote:
>
>On 4/14/2023 2:25 PM, Chao Gao wrote:
>> From: Zhang Chen <chen.zhang@intel.com>
>> 
>> Currently KVM disables interception of IA32_SPEC_CTRL after a non-0 is
>> written to IA32_SPEC_CTRL by guest. Then, guest is allowed to write any
>> value to hardware.
>> 
>> "virtualize IA32_SPEC_CTRL" is a new tertiary vm-exec control. This
>> feature allows KVM to specify that certain bits of the IA32_SPEC_CTRL
>> MSR cannot be modified by guest software.
>> 
>> Two VMCS fields are added:
>> 
>>    IA32_SPEC_CTRL_MASK:   bits that guest software cannot modify
>>    IA32_SPEC_CTRL_SHADOW: value that guest software expects to be in the
>> 			 IA32_SPEC_CTRL MSR
>> 
>> On rdmsr, the shadow value is returned. on wrmsr, EDX:EAX is written
>> to the IA32_SPEC_CTRL_SHADOW and (cur_val & mask) | (EDX:EAX & ~mask)
>> is written to the IA32_SPEC_CTRL MSR, where
>>    * cur_val is the original value of IA32_SPEC_CTRL MSR
>>    * mask is the value of IA32_SPEC_CTRL_MASK
>> 
>> Add a mask e.g.,
>
>e.g. or i.e. ?

Yes, here should be "i.e.".

>> +static inline void vmx_set_guest_spec_ctrl(struct vcpu_vmx *vmx, u64 val)
>> +{
>> +	vmx->guest_spec_ctrl = val;
>> +
>> +	/*
>> +	 * For simplicity, always keep IA32_SPEC_CTRL_SHADOW up-to-date,
>> +	 * regardless of the MSR intercept state.
>
>It is better to use "IA32_SPEC_CTRL"? explicitly instead of "the MSR" to
>avoid misunderstand.

Agreed. Will do.