Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758147AbXI0Ptg (ORCPT ); Thu, 27 Sep 2007 11:49:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755085AbXI0Pt3 (ORCPT ); Thu, 27 Sep 2007 11:49:29 -0400 Received: from www.osadl.org ([213.239.205.134]:49987 "EHLO mail.tglx.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755563AbXI0Pt2 (ORCPT ); Thu, 27 Sep 2007 11:49:28 -0400 Subject: Re: 2.6.23-rc8-mm2: problems on HP nx6325 From: Thomas Gleixner To: "Rafael J. Wysocki" Cc: Andrew Morton , linux-kernel@vger.kernel.org In-Reply-To: <200709271759.46018.rjw@sisk.pl> References: <20070927022220.c76a7a6e.akpm@linux-foundation.org> <200709271719.06937.rjw@sisk.pl> <200709271759.46018.rjw@sisk.pl> Content-Type: text/plain Date: Thu, 27 Sep 2007 17:49:26 +0200 Message-Id: <1190908166.23376.115.camel@chaos> Mime-Version: 1.0 X-Mailer: Evolution 2.12.0 (2.12.0-3.fc8) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1446 Lines: 44 On Thu, 2007-09-27 at 17:59 +0200, Rafael J. Wysocki wrote: > > 2) CPU hotplug is busted (onlining of CPU1 kills the kernel), probably due to > > the same issue that I'm having with the -hrt version of 2.6.23-rc8 (we're > > debugging it right now) > > This one is fixed by the following patch: > > --- > From: Rafael J. Wysocki > > Fix CPU hotplug breakage on HP nx6325 and similar boxes caused by a reference > to disable_apic_timer (labeled as __initdata) from the CPU initialization code. > > Signed-off-by: Rafael J. Wysocki Doh, I knew I blew it. Good catch, thanks, tglx > --- > arch/x86_64/kernel/apic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux-2.6.23-rc8-mm2/arch/x86_64/kernel/apic.c > =================================================================== > --- linux-2.6.23-rc8-mm2.orig/arch/x86_64/kernel/apic.c > +++ linux-2.6.23-rc8-mm2/arch/x86_64/kernel/apic.c > @@ -42,7 +42,7 @@ > > int apic_verbosity; > static int apic_calibrate_pmtmr __initdata; > -int disable_apic_timer __initdata; > +int disable_apic_timer __cpuinitdata; > > /* Local APIC timer works in C2? */ > int local_apic_timer_c2_ok; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/