Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230417205631.1956027-1-arnd@kernel.org>
In-Reply-To: <20230417205631.1956027-1-arnd@kernel.org>
From:   Mark Fasheh <mark@fasheh.com>
Date:   Mon, 17 Apr 2023 19:29:55 -0700
Message-ID: <CAGe7X7ntw_iZUsKbcg7PwJAeAqtFBia20rKs=Q__mtYaCMdc2w@mail.gmail.com>
Subject: Re: [PATCH] ocfs2: reduce ioctl stack usage
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     Joel Becker <jlbec@evilplan.org>,
        Joseph Qi <joseph.qi@linux.alibaba.com>,
        Arnd Bergmann <arnd@arndb.de>, David Sterba <dsterba@suse.com>,
        =?UTF-8?Q?Christoph_B=C3=B6hmwalder?= 
        <christoph.boehmwalder@linbit.com>, Jens Axboe <axboe@kernel.dk>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        =?UTF-8?B?SmFuIEjDtnBwbmVy?= <hoeppner@linux.ibm.com>,
        Christian Brauner <brauner@kernel.org>,
        ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Apr 17, 2023 at 1:56=E2=80=AFPM Arnd Bergmann <arnd@kernel.org> wro=
te:
> On 32-bit architectures with KASAN_STACK enabled, the total stack usage
> of the ocfs2_ioctl function grows beyond the warning limit:
>
> fs/ocfs2/ioctl.c: In function 'ocfs2_ioctl':
> fs/ocfs2/ioctl.c:934:1: error: the frame size of 1448 bytes is larger tha=
n 1400 bytes [-Werror=3Dframe-larger-than=3D]
>
> Move each of the variables into a basic block, and mark ocfs2_info_handle=
()
> as noinline_for_stack, in order to have the variable share stack slots.

Thanks for this,

Reviewed-by: Mark Fasheh <mark@fasheh.com>
  --Mark