Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\))
Subject: Re: [PATCH] nvme/tcp: Add support to set the tcp worker cpu affinity
From:   Li Feng <fengli@smartx.com>
In-Reply-To: <8310edb2-84cf-6211-f37d-d8f3df1e2320@nvidia.com>
Date:   Tue, 18 Apr 2023 12:21:31 +0800
Cc:     Sagi Grimberg <sagi@grimberg.me>,
        "open list:NVM EXPRESS DRIVER" <linux-nvme@lists.infradead.org>,
        Christoph Hellwig <hch@lst.de>,
        Keith Busch <kbusch@kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Jens Axboe <axboe@fb.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <C13EBEE0-787E-44CF-8531-B4C39C3E10CC@smartx.com>
References: <20230413062339.2454616-1-fengli@smartx.com>
 <20230413063317.2455680-1-fengli@smartx.com>
 <7f553d34-9ada-426c-4847-c7cd1aba64a8@grimberg.me>
 <8310edb2-84cf-6211-f37d-d8f3df1e2320@nvidia.com>
To:     Chaitanya Kulkarni <chaitanyak@nvidia.com>
Precedence: bulk


> 2023=E5=B9=B44=E6=9C=8818=E6=97=A5 =E4=B8=8A=E5=8D=8811:58=EF=BC=8CChait=
anya Kulkarni <chaitanyak@nvidia.com> =E5=86=99=E9=81=93=EF=BC=9A
>=20
>=20
>> - It is not backed by performance improvements, but more importantly
>> does not cover any potential regressions in key metrics (bw/iops/lat)
>> or lack there of.
>>=20
>=20
> I've already asked for this, without seeing performance numbers
> and any regression for general usecase it is hard to justify this.
>=20
> -ck
>=20
>=20
Hi ck,
Thanks for your comment.

In the previous mail, just paste the 256k read result(1GB/s to 1.4GB/s), =
I will add
more io pattern result asap when the machine environment is available.=