Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp4924900rwe; Mon, 17 Apr 2023 22:30:09 -0700 (PDT) X-Google-Smtp-Source: AKy350bH5gMag5ydehmB3GU7jA0M5M+rIjCMveIsN8V6/Od4x1P0wiBcNJEJOPh1BRBpS9bVrQQe X-Received: by 2002:a17:90a:b384:b0:23d:a2a:3ae4 with SMTP id e4-20020a17090ab38400b0023d0a2a3ae4mr818297pjr.44.1681795808946; Mon, 17 Apr 2023 22:30:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681795808; cv=none; d=google.com; s=arc-20160816; b=a1Or12wXql/lCgeOEL+wATy3ATbVKc/gLr4ZaBaGZu6ZCV/5tWdHXbpkOkn9m6Xzty KZA7Vv7yvB+FL3QHZrundIdQdyUl7YKyCdU3JQtGswHD3ajh/pjwskjDFdVdAx/7DV76 jZzaT6RpriSRxPXfP09ToN2kqrFd35Qn5HAlN6Z3HptTqmEjlKGivVDkMWL8+Ti6Jhwg Q8UFSFIBWxuPkb/SCHRhloCkoYpZDWloeoJyXMeVMMIiaglnBgIYDxi8FHQsGlOloZKr OavFlLzVrxUAgCpHdLgq2u8W0SHZ+ta/kj/XfcvPgeCwDjt7NLlcfH2S+5dtazHA5ygc EDzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Eh/DqUUzY2lVMjQIOADXqy4dsohFXgtxffqXhcCjk5w=; b=K6mRhyjuZcDHEoW2Wr581YabDOiEXFL95cq8HS2FR1ch28uygx7zUtiKXu9KC43prk Pl+fHkadtVX/MM8Vl85AJ0DyaqEJVjwgoF391+KAywUglzp+gEXDCr7i4bnS5QmxYbdh IZ1KXLtV9tKwJx9M5Do6j1o9BmCt9UIDYupORoYo9wKr3LDUq8oZBLHfz3fCNyA7t54D WwslknUr4VBDChUhgyWioBAEQroN1bOQfIZQuOSdDu1BkrNWOGcH+0+RcIErvCocLdAg aAwsvEKGVwHQm5y784MTKkNmDvWdKjdIelRA2ga01p9lE49p3XCMWoRZO07fUtaKuIWA P9Iw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=1kQY28uO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lk11-20020a17090b33cb00b0024750453f25si9460515pjb.185.2023.04.17.22.29.55; Mon, 17 Apr 2023 22:30:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=1kQY28uO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229980AbjDRFYV (ORCPT + 99 others); Tue, 18 Apr 2023 01:24:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229654AbjDRFYU (ORCPT ); Tue, 18 Apr 2023 01:24:20 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B94C4682; Mon, 17 Apr 2023 22:24:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Eh/DqUUzY2lVMjQIOADXqy4dsohFXgtxffqXhcCjk5w=; b=1kQY28uOFr0UvLUA8wxZYC5Ovg QUwA79p7Awun5OpxioLnsddpA2ecnLTzt78vbM2VIqszOfAPXog6IyQrGUz/XBYhQPQ+5fE1khcTC Hf7NOkNVr05+ey/0N44zCD7tbJ7WZZt/mVnWVHUtyO6qH+pRL6pAtFIfg5YFTimshqBddj9YTTznX RNqzuzzFsIHfoyQZd8V4Sxpxnx/EJAba1X2/7c9pcmf2A/8QSxE3EccmEy1iCFiCUVjjeoXbMMR5k AjhrP3SFTHwqvvPZ9WnWV0YCzY0Ji6XczHHBN2dS+BAK9fCuA0Ao6p9+wv72c0AGGfQAvqB8/L93q QOQcmhmg==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1podpD-000uNI-0t; Tue, 18 Apr 2023 05:24:19 +0000 Date: Mon, 17 Apr 2023 22:24:19 -0700 From: Christoph Hellwig To: Patrick McLean Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, Bjorn Helgaas , linux-pci@vger.kernel.org, Dave Airlie , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: Re: [PATCH 2/2] ata: libata-core: Apply ATI NCQ horkage to ASPEED as well Message-ID: References: <20230418011720.3900090-1-chutzpah@gentoo.org> <20230418011720.3900090-3-chutzpah@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230418011720.3900090-3-chutzpah@gentoo.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 17, 2023 at 06:17:20PM -0700, Patrick McLean wrote: > We have some machines with ASPEED SATA controllers, and are seeing the same NCQ > issues that ATI controllers (I am not sure if it's a rebranded ATI controller, > or they both have some faulty implementation). This NCQ breakage is consistent > across a few different types of drives. > > Instead of maintaining a list of drives that are broken with ASPEED controllers Are these ASPEED controllers all the same or a wide variety? Quirking all controllers from the same vendor seems like an overly broad approach to me.