Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 18 Apr 2023 08:01:28 +0200
Message-ID: <877cu9685j.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: hda/hdmi: Remove some dead code
In-Reply-To: <91a31341f32d493bcc6c4515178ce0755ac1aa70.1681710069.git.christophe.jaillet@wanadoo.fr>
References: <91a31341f32d493bcc6c4515178ce0755ac1aa70.1681710069.git.christophe.jaillet@wanadoo.fr>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Mon, 17 Apr 2023 07:41:48 +0200,
Christophe JAILLET wrote:
> 
> These snd_BUG_ON() can never trigger, so just remove them to save a few
> LoC.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> This patch is speculative. Maybe the other "if"s should be removed and the
> error code returned instead.
> 
> I chose to remove these ones and the corresponding error code, because it
> seems that it is already handled this way in hdmi_pcm_open().
> 
> I don't know the code enough, so it is only my guess.
> 
> Review with care :)

A sanity check is merely a sanity check, and we haven't got report
hitting this, so this should be fine.  Let's cross fingers.


thanks,

Takashi