Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230417092631.347976-1-rick.wertenbroek@gmail.com>
 <20230417092631.347976-12-rick.wertenbroek@gmail.com> <cf47e154-1a48-58a9-b139-95b51b87d356@kernel.org>
In-Reply-To: <cf47e154-1a48-58a9-b139-95b51b87d356@kernel.org>
From:   Rick Wertenbroek <rick.wertenbroek@gmail.com>
Date:   Tue, 18 Apr 2023 09:11:07 +0200
Message-ID: <CAAEEuhq0nCT0XVuEeiHxY=tAsHipJPY=Uq59B=vZAwrXXjMzcg@mail.gmail.com>
Subject: Re: [PATCH v4 11/11] PCI: rockchip: Set address alignment for
 endpoint mode
To:     Damien Le Moal <dlemoal@kernel.org>
Cc:     alberto.dassatti@heig-vd.ch, xxm@rock-chips.com,
        Shawn Lin <shawn.lin@rock-chips.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Lorenzo Pieralisi <lpieralisi@kernel.org>,
        =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= <kw@linux.com>,
        Rob Herring <robh@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Heiko Stuebner <heiko@sntech.de>,
        Johan Jonker <jbx6244@gmail.com>,
        Caleb Connolly <kc@postmarketos.org>,
        Brian Norris <briannorris@chromium.org>,
        Corentin Labbe <clabbe@baylibre.com>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Hugh Cole-Baker <sigmaris@gmail.com>,
        Judy Hsiao <judyhsiao@chromium.org>,
        Arnaud Ferraris <arnaud.ferraris@collabora.com>,
        linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Apr 18, 2023 at 1:51=E2=80=AFAM Damien Le Moal <dlemoal@kernel.org>=
 wrote:
>
> On 4/17/23 18:26, Rick Wertenbroek wrote:
> > From: Damien Le Moal <dlemoal@kernel.org>
> >
> > The address translation unit of the rockchip EP controller does not use
> > the lower 8 bits of a PCIe-space address to map local memory. Thus we
> > must set the align feature field to 256 to let the user know about this
> > constraint.
> >
> > Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
>
> I think this one also needs the tag:
>
> Fixes: cf590b078391 ("...")
> Cc: stable@vger.kernel.org
>
> And you forgot to add you Signed-off-by tag (when sending someones else p=
atch,
> you must add your own SoB tag after the author's tag).
>

Thank you for all your comments, I'll add the tags.
I reread the documentation, I missed it, it's the first
time I sent someone elses patch.

> > ---
> >  drivers/pci/controller/pcie-rockchip-ep.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/pci/controller/pcie-rockchip-ep.c b/drivers/pci/co=
ntroller/pcie-rockchip-ep.c
> > index edfced311a9f..0af0e965fb57 100644
> > --- a/drivers/pci/controller/pcie-rockchip-ep.c
> > +++ b/drivers/pci/controller/pcie-rockchip-ep.c
> > @@ -442,6 +442,7 @@ static const struct pci_epc_features rockchip_pcie_=
epc_features =3D {
> >       .linkup_notifier =3D false,
> >       .msi_capable =3D true,
> >       .msix_capable =3D false,
> > +     .align =3D 256,
> >  };
> >
> >  static const struct pci_epc_features*
>