Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758797AbXI0Qw1 (ORCPT ); Thu, 27 Sep 2007 12:52:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756774AbXI0QwV (ORCPT ); Thu, 27 Sep 2007 12:52:21 -0400 Received: from pasmtpa.tele.dk ([80.160.77.114]:36667 "EHLO pasmtpA.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753683AbXI0QwU (ORCPT ); Thu, 27 Sep 2007 12:52:20 -0400 Date: Thu, 27 Sep 2007 18:53:46 +0200 From: Sam Ravnborg To: "Rafael J. Wysocki" Cc: Andrew Morton , linux-kernel@vger.kernel.org, Thomas Gleixner Subject: Re: 2.6.23-rc8-mm2: problems on HP nx6325 Message-ID: <20070927165346.GA919@uranus.ravnborg.org> References: <20070927022220.c76a7a6e.akpm@linux-foundation.org> <200709271719.06937.rjw@sisk.pl> <200709271759.46018.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200709271759.46018.rjw@sisk.pl> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1211 Lines: 35 Hi Rafael. > > Fix CPU hotplug breakage on HP nx6325 and similar boxes caused by a reference > to disable_apic_timer (labeled as __initdata) from the CPU initialization code. > > Signed-off-by: Rafael J. Wysocki > --- > arch/x86_64/kernel/apic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux-2.6.23-rc8-mm2/arch/x86_64/kernel/apic.c > =================================================================== > --- linux-2.6.23-rc8-mm2.orig/arch/x86_64/kernel/apic.c > +++ linux-2.6.23-rc8-mm2/arch/x86_64/kernel/apic.c > @@ -42,7 +42,7 @@ > > int apic_verbosity; > static int apic_calibrate_pmtmr __initdata; > -int disable_apic_timer __initdata; > +int disable_apic_timer __cpuinitdata; > This is with your configuration a reference from a .text section to a .init.data section as I see it. So this ought to have been flagged by the section mismatch checks in modpost. I assume you did not see such warning?? Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/