Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 18 Apr 2023 10:44:57 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     William Breathitt Gray <william.gray@linaro.org>
Cc:     linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        Johannes Berg <johannes.berg@intel.com>,
        Jonathan Cameron <jic23@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>
Subject: Re: [PATCH v4 4/4] counter: 104-quad-8: Migrate to the regmap API
Message-ID: <ZD5KeYJoIZ1PFKud@smile.fi.intel.com>
References: <cover.1681753140.git.william.gray@linaro.org>
 <1f1f7920d2be94aedb6fdf49f429fe6137c8cb24.1681753140.git.william.gray@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1f1f7920d2be94aedb6fdf49f429fe6137c8cb24.1681753140.git.william.gray@linaro.org>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Mon, Apr 17, 2023 at 03:50:50PM -0400, William Breathitt Gray wrote:
> The regmap API supports IO port accessors so we can take advantage of
> regmap abstractions rather than handling access to the device registers
> directly in the driver. With regmap we get boundary checks, read-write
> permissions, operation synchronization locks, and more for free. Most
> important of all, rather than rolling our own we utilize implementations
> that are known to work and gain from any future improvements and fixes
> that come.

...

>  - Use "int ret" for regmap_* return values throughout for consistency

Looking into it I would think it might be better to have a precursor patch.
But it's up to you. It looks good now.

-- 
With Best Regards,
Andy Shevchenko