Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230417092631.347976-1-rick.wertenbroek@gmail.com> <ea29e339-6f61-5bbb-7290-03df629d5b11@kernel.org>
In-Reply-To: <ea29e339-6f61-5bbb-7290-03df629d5b11@kernel.org>
From:   Rick Wertenbroek <rick.wertenbroek@gmail.com>
Date:   Tue, 18 Apr 2023 09:51:21 +0200
Message-ID: <CAAEEuhpj4TZNrPEPn7LuGOHHoYt1FbCEGH1d9g+8iKMeoBA+=Q@mail.gmail.com>
Subject: Re: [PATCH v4 00/11] PCI: rockchip: Fix RK3399 PCIe endpoint
 controller driver
To:     Damien Le Moal <dlemoal@kernel.org>
Cc:     alberto.dassatti@heig-vd.ch, xxm@rock-chips.com,
        Shawn Lin <shawn.lin@rock-chips.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Lorenzo Pieralisi <lpieralisi@kernel.org>,
        =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= <kw@linux.com>,
        Rob Herring <robh@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Heiko Stuebner <heiko@sntech.de>,
        Brian Norris <briannorris@chromium.org>,
        Johan Jonker <jbx6244@gmail.com>,
        Caleb Connolly <kc@postmarketos.org>,
        Corentin Labbe <clabbe@baylibre.com>,
        Judy Hsiao <judyhsiao@chromium.org>,
        Arnaud Ferraris <arnaud.ferraris@collabora.com>,
        Hugh Cole-Baker <sigmaris@gmail.com>,
        linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Apr 18, 2023 at 2:09=E2=80=AFAM Damien Le Moal <dlemoal@kernel.org>=
 wrote:
>
> On 4/17/23 18:26, Rick Wertenbroek wrote:
> > This is a series of patches that fixes the PCIe endpoint controller dri=
ver
> > for the Rockchip RK3399 SoC. The driver was introduced in commit
> > cf590b078391 ("PCI: rockchip: Add EP driver for Rockchip PCIe controlle=
r")
> > The original driver had issues and would not allow for the RK3399 to
> > operate in PCIe endpoint mode correctly. This patch series fixes that s=
o
> > that the PCIe core controller of the RK3399 SoC can now act as a PCIe
> > endpoint. This is v4 of the patch series and addresses the comments rec=
eived
> > during the review of the v3 [1]. The changes to the v3 are minor and no=
ne of
> > them change the logic of the driver.
> >
> > Thank you in advance for reviewing this patch series and hopefully
> > getting this merged. Having a functional PCIe endpoint controller
> > driver for the RK3399 would allow to develop further PCIe endpoint
> > functions through the Linux PCIe endpoint framework using this SoC.
> >
> > [1] https://lore.kernel.org/linux-pci/20230404082426.3880812-1-rick.wer=
tenbroek@gmail.com/
> >
> > Summary of changes to V3 :
> >
> > * Set the fields in the standard order in the dtsi and removed unnecess=
ary
> >   change in associated documentation, thanks to Krzysztof for pointing =
this out.
> > * Added comment to explain how MSI-X capabilities advertisement was rem=
oved.
> > * Changed Damien Le Moal <damien.lemoal@opensource.wdc.com> address to =
his
> >   kernel.org address Damien Le Moal <dlemoal@kernel.org> in tags.
> > * [minor] Simplified code where a power of 2 was applied followed by a =
ilog2
> >   operation.
> > * [minor] Small code changes, replaced constant variable by macro, spli=
t
> >   remaining long lines.
>
> I retested this series, all good. So my Tested-by tag stands.
>
> Lorenzo, Krzysztof, Bjorn,
>
> Let's please get this series queued for 6.4 ASAP as otherwise the rockchi=
p EP
> controller is unusable.
>
> Also please note that working with Rick off-list, we found out that more =
fixes
> are in fact needed for the PCI address mapping (ATU programming) on top o=
f this
> series. But the problems detected are subtle and harder to trigger. The f=
ixes
> needed involve changes to the EPC core API so we are still working on the=
 best
> way to do that. We'll work on another series on top of this one for addre=
ssing
> these issues.
>
>

Thank you Damien for taking the time testing and reviewing this, it is
highly appreciated.
I just sent a v5 [1] addressing your comments and added the tags.

Best regards,
Rick

[1] https://lore.kernel.org/linux-pci/20230418074700.1083505-1-rick.wertenb=
roek@gmail.com/