Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp5051030rwe; Tue, 18 Apr 2023 01:03:24 -0700 (PDT) X-Google-Smtp-Source: AKy350arCLHZA7E8T8Co2L5QbdaLvOc9GBCOxRqBHFIGtN0EvCgG7Nr2pIfTaUOSHdXPit9jenih X-Received: by 2002:a17:90a:bd85:b0:246:c3e1:c931 with SMTP id z5-20020a17090abd8500b00246c3e1c931mr1148956pjr.23.1681805004198; Tue, 18 Apr 2023 01:03:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681805004; cv=none; d=google.com; s=arc-20160816; b=wXgkxDsdmYToXtCUetae2yrp7FDmRfIUh1vpOiDUjJbfMdBjpBekNZVF5bhCBUyaIi E3DsUbEaaXYVi5pYCJuBdEbcan/mUkwvP+viHfBnNu+hBYM1iCo0fkzCaBMJX2Wl3a37 FUuNAmgeTY0X6eXMW4VGEMReEBd03W65EvrcjBQQ5SUqHTSC8Ybp6M3xXGlNsLoMme/E f474h/IhYpAIBdlSErhsbuG8S/wnw9jV37Lnbp7/mmbSrJypvKrYNNbdyxa9+f8dKctp VG69GMkqkzECJRO34TVH/9WXp5VQoi9PUaAL/cEdZfaPXlC7MV8f+kn7FhFsFXAaHYHj lEaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :organization:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:dkim-signature; bh=2aFLPz/uwpebrnPfTqUAJRgN4HbZkQaQB8mK4/OD3/c=; b=dlYQmBKFB3WC9dZkqD8KGqY735MFAJzIlR37Epjd05fphG3X3rFlGdmNkm7UbRTP1l PB6e4JNoGiaJRE6YIJ2h6DOnBDPGf8NNLvau8NwmVSA2HYONJ+p7zeJR20LbDHhgztGP e80tmhHRfpuGSODF9C8JzjD+piwsTZCa9JAV/uvW9wodQNb0h0ns5jJT/KaWVNWhV17g rxaZCtngkthAUFizMWXv44hYJ6tTIrcazuXVdK1XVmhGce+h++oqClmo7UQia2o0zAWQ kXZulvrZlCZN1e+fVLo3avWF9U5bwbVwK6hxo6KtALnTYukUmUHZGzwJ1qpQK7PbcQu0 Jd7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nLTflCHD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l71-20020a63884a000000b0051fbe2e438csi215456pgd.293.2023.04.18.01.03.11; Tue, 18 Apr 2023 01:03:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nLTflCHD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231299AbjDRIBE (ORCPT + 99 others); Tue, 18 Apr 2023 04:01:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229962AbjDRIBC (ORCPT ); Tue, 18 Apr 2023 04:01:02 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A07EDE44; Tue, 18 Apr 2023 01:01:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 37DB962D87; Tue, 18 Apr 2023 08:01:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B5ADC4339B; Tue, 18 Apr 2023 08:00:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681804860; bh=nMlwZvx07/xNUjaxnaVPeCIohut3J38u8ZLXebDqb+A=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=nLTflCHDIrlW/mcy0pJ4qyVWNUk34Ys8hjKCa+EvmGXC8OXA+KBhw/sJOYrI8SSo4 yhU0xZwSY4DoRO5fYTNva30jOqG+AapFA3kRobms+8uYkQITQyJwzuKsyUfpYzhKSt CqzqMAddTvNLPstCLY3LUgHJiGjlF6zHrfnD30lpADqMC8150s8kXq4HEuyom9UsIJ AP9MVGD+xvrx5hjMXO/QSvrXuhxt1ojRIv80i2OPGdg8IGjmWbf7XqyqYOZPgyNUB/ T/OZ4PrhBUAyG2M7GjpHy5D2bF9sQY/OpH7Vu0baLCEB7QASxbq6/ubOiubhSnaY2U H/dlg7kNjLWKA== Message-ID: <402e9a89-61fb-0ff1-fd82-e5327458c028@kernel.org> Date: Tue, 18 Apr 2023 17:00:56 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 00/11] PCI: rockchip: Fix RK3399 PCIe endpoint controller driver Content-Language: en-US To: Rick Wertenbroek Cc: alberto.dassatti@heig-vd.ch, xxm@rock-chips.com, Shawn Lin , Bjorn Helgaas , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Brian Norris , Johan Jonker , Caleb Connolly , Corentin Labbe , Judy Hsiao , Arnaud Ferraris , Hugh Cole-Baker , linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230417092631.347976-1-rick.wertenbroek@gmail.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/18/23 16:51, Rick Wertenbroek wrote: > On Tue, Apr 18, 2023 at 2:09 AM Damien Le Moal wrote: >> >> On 4/17/23 18:26, Rick Wertenbroek wrote: >>> This is a series of patches that fixes the PCIe endpoint controller driver >>> for the Rockchip RK3399 SoC. The driver was introduced in commit >>> cf590b078391 ("PCI: rockchip: Add EP driver for Rockchip PCIe controller") >>> The original driver had issues and would not allow for the RK3399 to >>> operate in PCIe endpoint mode correctly. This patch series fixes that so >>> that the PCIe core controller of the RK3399 SoC can now act as a PCIe >>> endpoint. This is v4 of the patch series and addresses the comments received >>> during the review of the v3 [1]. The changes to the v3 are minor and none of >>> them change the logic of the driver. >>> >>> Thank you in advance for reviewing this patch series and hopefully >>> getting this merged. Having a functional PCIe endpoint controller >>> driver for the RK3399 would allow to develop further PCIe endpoint >>> functions through the Linux PCIe endpoint framework using this SoC. >>> >>> [1] https://lore.kernel.org/linux-pci/20230404082426.3880812-1-rick.wertenbroek@gmail.com/ >>> >>> Summary of changes to V3 : >>> >>> * Set the fields in the standard order in the dtsi and removed unnecessary >>> change in associated documentation, thanks to Krzysztof for pointing this out. >>> * Added comment to explain how MSI-X capabilities advertisement was removed. >>> * Changed Damien Le Moal address to his >>> kernel.org address Damien Le Moal in tags. >>> * [minor] Simplified code where a power of 2 was applied followed by a ilog2 >>> operation. >>> * [minor] Small code changes, replaced constant variable by macro, split >>> remaining long lines. >> >> I retested this series, all good. So my Tested-by tag stands. >> >> Lorenzo, Krzysztof, Bjorn, >> >> Let's please get this series queued for 6.4 ASAP as otherwise the rockchip EP >> controller is unusable. >> >> Also please note that working with Rick off-list, we found out that more fixes >> are in fact needed for the PCI address mapping (ATU programming) on top of this >> series. But the problems detected are subtle and harder to trigger. The fixes >> needed involve changes to the EPC core API so we are still working on the best >> way to do that. We'll work on another series on top of this one for addressing >> these issues. >> >> > > Thank you Damien for taking the time testing and reviewing this, it is > highly appreciated. > I just sent a v5 [1] addressing your comments and added the tags. Just checked and look all OK to me. Nothing to add. Thanks for fixing this driver. > > Best regards, > Rick > > [1] https://lore.kernel.org/linux-pci/20230418074700.1083505-1-rick.wertenbroek@gmail.com/