Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp5051210rwe; Tue, 18 Apr 2023 01:03:33 -0700 (PDT) X-Google-Smtp-Source: AKy350ZiRWRZ9ULZh0wpNCUw+TRJUkBvQY6KGItCPYVVKMU69uG1ddIi9U+m+Xr2Nmj+MYBnaN0g X-Received: by 2002:a05:6a20:9389:b0:ef:cb4c:c23e with SMTP id x9-20020a056a20938900b000efcb4cc23emr8775994pzh.29.1681805013445; Tue, 18 Apr 2023 01:03:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681805013; cv=none; d=google.com; s=arc-20160816; b=zhiXDeGwor6sA/8htxz2yBpgl8EPaRGDYQccJ8tLKdJqUXWA+48CQLnoXyv2DI1lp2 siEb/kjB6vhcpkMxJuofosUbj+zBUZo44SR29kSBd7M8nv5uLcpnOIyj2xldjlTrv+6D /YGqYw793EiQbVrt/a6xfjegh0l/TDCq06O9ZrByPPDTz9j0p28KyD6pR1OHNoNaH+SS vGLw4jOByY9HkK+IFKywo6fqk9WoxJ6/jw2yN3krGNLcQFlSGjg9mKACesrJgiX62mSW rOgnQKiKBHJw8iXdoNFrTlqHJjaqsbhP6PP/xL65saX39BJUMs91BtWSkJT9PXxhfDpb uKoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :organization:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:dkim-signature; bh=WO8kNPpJwMhx0ncrjO4BkoaLMfvtt67m7v2+DMWUgU4=; b=07p1vzyXvICQiHXSqoWgfQpo4ujcLglIcpSleRFwUsAlXH0kiTl6AAclDys4DQ5c4R 4iNbF2y0F7tfGMOIIQglnP6SZW1Ig/5TMTckkEaeNN1a2SzncDwMf4/63KI51UfNrVQi KtIH0+erkdv1qPRYM2t5KVn6GS2e3vaTVXFiBXAx85hji4WKslSz7DyR53kCsuHOCUzx Gr/nxpftQQd419I8RwlldsVi81OL9py/lbACJaVBTED4PewyhdzoUvOKEQvfHuEl6x/D gWhz1drrAFhNSwBsLtfC7VUFfodSwpkzlhNSq7bmuUmB7q7YkZf5MWlGkMqPDwYWE7/i 4JyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SOzUZ4nk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t31-20020a63445f000000b005139191c0casi13367133pgk.660.2023.04.18.01.03.05; Tue, 18 Apr 2023 01:03:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SOzUZ4nk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231293AbjDRIAI (ORCPT + 99 others); Tue, 18 Apr 2023 04:00:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229962AbjDRIAG (ORCPT ); Tue, 18 Apr 2023 04:00:06 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66D4BC5; Tue, 18 Apr 2023 01:00:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 05900628D9; Tue, 18 Apr 2023 08:00:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A44DC433D2; Tue, 18 Apr 2023 08:00:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681804804; bh=s60CVmIII2Y0/UiFhD2Gk75AqSi4Ndp6RwEByH1gFpc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=SOzUZ4nk0TBp9MMijNlh6Pbw55PQVlaLmg8Bg+4JlUXrqtNE7D8WceZkiP6RMXwpp HysXBOvRm6VLgLv9OCK4+m6XYX5bVZeXG5vB6QVADoswsOzhjsdApsPSjWOhSbtZf4 2T3o2C10uyGZt1VpWV0yuDqQIR/jLRQoUEwGGu+vSFTjapVMt2uKRCE3wNXzqjmYmL iXQFE0F0MlVZNcZS83Puc41mNJVOtHon8/c70Q6U4aO5TcX2malrU/OdQzpZXKrqdG +y3SupcJFs7zWKwd+60uwjHYv7oEuA/I0H3DmO85CvygO3Mh6eltx7+cdkDFJDTLg8 w3sYs1fhdgHmQ== Message-ID: Date: Tue, 18 Apr 2023 17:00:01 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 2/2] ata: libata-core: Apply ATI NCQ horkage to ASPEED as well Content-Language: en-US To: Christoph Hellwig , Patrick McLean Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, Bjorn Helgaas , linux-pci@vger.kernel.org, Dave Airlie , Thomas Zimmermann , dri-devel@lists.freedesktop.org References: <20230418011720.3900090-1-chutzpah@gentoo.org> <20230418011720.3900090-3-chutzpah@gentoo.org> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/18/23 14:24, Christoph Hellwig wrote: > On Mon, Apr 17, 2023 at 06:17:20PM -0700, Patrick McLean wrote: >> We have some machines with ASPEED SATA controllers, and are seeing the same NCQ >> issues that ATI controllers (I am not sure if it's a rebranded ATI controller, >> or they both have some faulty implementation). This NCQ breakage is consistent >> across a few different types of drives. >> >> Instead of maintaining a list of drives that are broken with ASPEED controllers > > Are these ASPEED controllers all the same or a wide variety? > Quirking all controllers from the same vendor seems like an overly > broad approach to me. Indeed. If you checked only one adapter model from ASPEED, then all that is needed is define it with "board_ahci_noncq" in drivers/ata/ahci.c (see ahci_pci_tbl array). NCQ support will be turned off for that particular adapter with that.