Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759271AbXI0RUX (ORCPT ); Thu, 27 Sep 2007 13:20:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759017AbXI0RUJ (ORCPT ); Thu, 27 Sep 2007 13:20:09 -0400 Received: from smtp2.linux-foundation.org ([207.189.120.14]:50950 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759014AbXI0RUH (ORCPT ); Thu, 27 Sep 2007 13:20:07 -0400 Date: Thu, 27 Sep 2007 10:13:42 -0700 From: Andrew Morton To: Jiri Kosina Cc: Andy Whitcroft , Franck Bui-Huu , linux-kernel@vger.kernel.org, Kamalesh Babulal Subject: Re: 2.6.23-rc8-mm1 -- powerpc link failure Message-Id: <20070927101342.92422296.akpm@linux-foundation.org> In-Reply-To: References: <20070925014625.3cd5f896.akpm@linux-foundation.org> <20070925134653.GB8447@shadowen.org> <20070927120308.GJ2213@shadowen.org> X-Mailer: Sylpheed 2.4.1 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1372 Lines: 36 On Thu, 27 Sep 2007 14:13:21 +0200 (CEST) Jiri Kosina wrote: > On Thu, 27 Sep 2007, Andy Whitcroft wrote: > > > Ok, this problem seems to still persist in 2.6.23-rc8-mm2. It seems we > > have three options from here: > > 1) update the compiler support list to exclude these compilers, or > > 2) back this change out, or > > 3) switch to the version not using __weak. > > The latter seems to be the least intrusive change. As no-one closer to > > the problem is stepping up to make the decision I will propose we go > > with the third option here. > > Andrew, > > if you agree with Andy that we should support compilers that don't work > with __weak, please drop i386-and-x86_64-randomize-brk.patch and replace > it with the one below instead (this has been already posted at > http://lkml.org/lkml/2007/8/31/113). Thanks. > We have quite a few instances of __weak in there. What is special about this one? > > From: Jiri Kosina > > i386 and x86_64: randomize brk() That's a better patch anyway. We often use __weak because people can't be bothered doing all that editing. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/