Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Date:   Tue, 18 Apr 2023 11:00:18 +0200
From:   Michael Walle <michael@walle.cc>
To:     VaibhaavRam.TL@microchip.com
Cc:     gregkh@linuxfoundation.org, linux-gpio@vger.kernel.org,
        linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com,
        arnd@arndb.de
Subject: Re: [PATCH v9 char-misc-next 1/2] misc: microchip: pci1xxxx: Add
 support to read and write into PCI1XXXX OTP via NVMEM sysfs
In-Reply-To: <49405ea2bb0bee16a41ce88b7d679ff714823585.camel@microchip.com>
References: <20230413105318.6070-1-vaibhaavram.tl@microchip.com>
 <20230413105318.6070-2-vaibhaavram.tl@microchip.com>
 <51847629489852d493af928580c5a2de@walle.cc>
 <49405ea2bb0bee16a41ce88b7d679ff714823585.camel@microchip.com>
User-Agent: Roundcube Webmail/1.4.13
Message-ID: <8b7b98e60fd871cc7aafda6f9b4e146a@walle.cc>
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Am 2023-04-17 14:47, schrieb VaibhaavRam.TL@microchip.com:
>> > +#include <linux/auxiliary_bus.h>
>> > +#include <linux/bio.h>
>> > +#include <linux/device.h>
>> > +#include <linux/iopoll.h>
>> > +#include <linux/kthread.h>
>> 
>> Is this needed? I don't see any threads. Also bio.h. Please double
>> check
>> your includes.
> Ok, Will remove in next version of patch
>> > +     if (priv != NULL)
>> > +             rb = priv->reg_base;
>> > +     else
>> > +             return -ENODEV;
>> 
>> Unneeded check, priv cannot be NULL, right?
> Ok, I think this can be removed
>> > +
>> > +             data = readl(rb +
>> > MMAP_OTP_OFFSET(OTP_PASS_FAIL_OFFSET));
>> > +             if (ret < 0 || data & OTP_FAIL_BIT)
>> > +                     break;
>> 
>> No error handling?
> We have implemented short read which returns count of successful bytes
> read and therefore userspace will recognise the situation when the
> requested count is not obtained.

I'll leave that up to Greg, but I'd prefer a proper error to userspace.
I'm not sure if you'd need to differentiate between a short read/write
and an error.

Maybe a short read or write is a valid situation where an access which
leads to the OTP_FAIL_BIT is for sure an error situation.

-michael