Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-372-g43825cb665-fm-20230411.003-g43825cb6
Mime-Version: 1.0
Message-Id: <52721c32-1cb7-4c00-accf-314ffbc32a76@app.fastmail.com>
In-Reply-To: <20230418081959.GB30837@pendragon.ideasonboard.com>
References: <20230418071605.2971866-1-arnd@kernel.org>
 <695e9f88-5a79-7ca4-645f-047b78495a80@xs4all.nl>
 <20230418081959.GB30837@pendragon.ideasonboard.com>
Date:   Tue, 18 Apr 2023 11:20:49 +0200
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "laurent.pinchart" <laurent.pinchart@ideasonboard.com>,
        "Hans Verkuil" <hverkuil@xs4all.nl>
Cc:     "Arnd Bergmann" <arnd@kernel.org>,
        "Mauro Carvalho Chehab" <mchehab@kernel.org>,
        "Shawn Guo" <shawnguo@kernel.org>,
        "Sascha Hauer" <s.hauer@pengutronix.de>,
        "Dong Aisheng" <aisheng.dong@nxp.com>,
        "Guoniu Zhou" <guoniu.zhou@nxp.com>,
        "Stefan Riedmueller" <s.riedmueller@phytec.de>,
        "Pengutronix Kernel Team" <kernel@pengutronix.de>,
        "Fabio Estevam" <festevam@gmail.com>,
        "NXP Linux Team" <linux-imx@nxp.com>,
        "Christian Hemp" <c.hemp@phytec.de>,
        "Jacopo Mondi" <jacopo@jmondi.org>, linux-media@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: nxp: ignore unused suspend operations
Content-Type: text/plain
Precedence: bulk

On Tue, Apr 18, 2023, at 10:19, Laurent Pinchart wrote:
> On Tue, Apr 18, 2023 at 10:04:13AM +0200, Hans Verkuil wrote:
>> Hi Arnd,
>> 
>> On 18/04/2023 09:15, Arnd Bergmann wrote:
>> > From: Arnd Bergmann <arnd@arndb.de>
>> > 
>> > gcc warns about some functions being unused when CONFIG_PM is
>> > disabled:
>> 
>> ???
>> 
>> The Kconfig has a:
>> 
>>         depends on HAS_DMA && PM
>> 
>> So how can this be compiled with CONFIG_PM not set?
>> 
>> Am I missing something?
>
> The warning appears when CONFIG_PM_SLEEP is disabled. The pm_ptr()
> change is thus not useful, but the switch to SYSTEM_SLEEP_PM_OPS() and
> RUNTIME_PM_OPS() make a difference.

I sent a v3 now. I ended up leaving the pm_ptr() in here, based on
the recommended usage of the new macros.

    Arnd