Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <530b12f1-b0d2-1183-c9a9-0f5f9d6e178d@gmail.com>
Date:   Tue, 18 Apr 2023 11:14:20 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH] kselftest: vDSO: Fix accumulation of uninitialized ret
 when CLOCK_REALTIME is undefined
Content-Language: en-US
To:     Vincenzo Frascino <vincenzo.frascino@arm.com>,
        Shuah Khan <shuah@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        linux-kselftest@vger.kernel.org
Cc:     kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230417104743.30018-1-colin.i.king@gmail.com>
 <20487c94-7f81-cbf5-7136-c7f266eaf60d@arm.com>
From:   "Colin King (gmail)" <colin.i.king@gmail.com>
In-Reply-To: <20487c94-7f81-cbf5-7136-c7f266eaf60d@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 18/04/2023 11:10, Vincenzo Frascino wrote:
> Hi Colin,
> 
> On 4/17/23 11:47, Colin Ian King wrote:
>> In the unlikely case that CLOCK_REALTIME is not defined, variable ret is
>> not initialized and further accumulation of return values to ret can leave
>> ret in an undefined state. Fix this by initialized ret to zero and changing
>> the assignment of ret to an accumulation for the CLOCK_REALTIME case.
>>
> 
> I was wondering how did you find this.

I used cppcheck --force --enable=all, this examines the #if defined() paths.

> 
> Apart that:
> 
> Reviewed-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
> 
>> Fixes: 03f55c7952c9 ("kselftest: Extend vDSO selftest to clock_getres")
>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>> ---
>>   tools/testing/selftests/vDSO/vdso_test_clock_getres.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/testing/selftests/vDSO/vdso_test_clock_getres.c b/tools/testing/selftests/vDSO/vdso_test_clock_getres.c
>> index 15dcee16ff72..38d46a8bf7cb 100644
>> --- a/tools/testing/selftests/vDSO/vdso_test_clock_getres.c
>> +++ b/tools/testing/selftests/vDSO/vdso_test_clock_getres.c
>> @@ -84,12 +84,12 @@ static inline int vdso_test_clock(unsigned int clock_id)
>>   
>>   int main(int argc, char **argv)
>>   {
>> -	int ret;
>> +	int ret = 0;
>>   
>>   #if _POSIX_TIMERS > 0
>>   
>>   #ifdef CLOCK_REALTIME
>> -	ret = vdso_test_clock(CLOCK_REALTIME);
>> +	ret += vdso_test_clock(CLOCK_REALTIME);
>>   #endif
>>   
>>   #ifdef CLOCK_BOOTTIME
>