Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 18 Apr 2023 14:32:16 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Angus Chen <angus.chen@jaguarmicro.com>
Cc:     rafael@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] driver core: auxiliary bus: No need to get auxdev->dev
 again
Message-ID: <2023041816-magma-shortly-dfdd@gregkh>
References: <20230418122406.1338-1-angus.chen@jaguarmicro.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230418122406.1338-1-angus.chen@jaguarmicro.com>
Precedence: bulk

On Tue, Apr 18, 2023 at 08:24:06PM +0800, Angus Chen wrote:
> Use dev variable directly.
> No functional change intended.

Not intended, but is it really intended?  What does this line mean?

> 
> Signed-off-by: Angus Chen <angus.chen@jaguarmicro.com>
> ---
>  drivers/base/auxiliary.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/base/auxiliary.c b/drivers/base/auxiliary.c
> index 4d4c2c8d26c4..ca1d044ff738 100644
> --- a/drivers/base/auxiliary.c
> +++ b/drivers/base/auxiliary.c
> @@ -286,7 +286,7 @@ int auxiliary_device_init(struct auxiliary_device *auxdev)
>  	}
>  
>  	dev->bus = &auxiliary_bus_type;
> -	device_initialize(&auxdev->dev);
> +	device_initialize(dev);

While an interesting change, is it needed?  Why make it?

thanks,

greg k-h