Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cdd90ba1-e9bd-e622-d7f3-de5d762cc2c6@kontron.de>
Date:   Tue, 18 Apr 2023 15:16:53 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [RFC PATCH 3/3] drm: bridge: samsung-dsim: Remove init quirk for
 Exynos
Content-Language: en-US, de-DE
To:     Marek Szyprowski <m.szyprowski@samsung.com>,
        Frieder Schrempf <frieder@fris.de>,
        Andrzej Hajda <andrzej.hajda@intel.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        David Airlie <airlied@gmail.com>,
        dri-devel@lists.freedesktop.org, Inki Dae <inki.dae@samsung.com>,
        Jagan Teki <jagan@amarulasolutions.com>,
        linux-kernel@vger.kernel.org,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Robert Foss <rfoss@kernel.org>
Cc:     Jernej Skrabec <jernej.skrabec@gmail.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Marek Vasut <marex@denx.de>
References: <CGME20230418104305eucas1p145a8fa1560520ebe430590abdeabb66e@eucas1p1.samsung.com>
 <20230418104256.878017-1-frieder@fris.de>
 <0c4f2703-8810-fe0f-76aa-cc6250aea74a@samsung.com>
From:   Frieder Schrempf <frieder.schrempf@kontron.de>
In-Reply-To: <0c4f2703-8810-fe0f-76aa-cc6250aea74a@samsung.com>
Content-Type: text/plain; charset=UTF-8
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzd0THJEbEpxRHl2TU5TSlhUU3N4N2VLNHc0ZEc0SGFNdU1VKzNCRmZXWFpt?=
 =?utf-8?B?Y2Z2anpxM2dYZlROMGhQNW1CU20xZUdFWndaa1dPSlZjTFdBai8vK0hyQ0tE?=
 =?utf-8?B?ZzZuY1VONEw2Rkg4blFtUTBieXFWQ1pLSktodmY0RjFyTFkrQkZFd3licG9p?=
 =?utf-8?B?dkI2WTRTcW04bkJaSnNsK3lLanRpWUNBR3UyMVRhL1NRRUQxdzB1UWI4OUxs?=
 =?utf-8?B?SEtINEl3VmZpNGtQbHEyVERhd3d0V2E4emo4cHdJUmN0ZHQvQnJBYTFFck5t?=
 =?utf-8?B?ajMwTjQyaGlwZ3B0U0gyRE9rMTE1dlJ3aE9xQWo1bDg4bGNPQS9tNEtQaUFx?=
 =?utf-8?B?eGpnYjJuOHI4TU1kRktHRUUydHQrcjlEdEs4b0RCU05TY2dCQ0pMYzJVTXRn?=
 =?utf-8?B?Y2JBNXlhQTJDRGcreG5CeFNPYUFQK2Q2Vlp0MjFRc0J1Rm1wZ3hnRnp2OFBO?=
 =?utf-8?B?TFBQR2dycUZtc1NKQXhFc0d4MkYvejI5Si9QZ1pyNnEwdlkzTElzT1cwQUxN?=
 =?utf-8?B?ZlFsWWVkZVE1QWNSN2pYMTAzVFdibnhtZ21CRVlKYjRiME5iL0QrNkliYUtL?=
 =?utf-8?B?QnpRUldkbXhQZjhNdXhIelNiVjI2bUJNTStKQkZwWVRuSnhKeDdSOE90Q3Nn?=
 =?utf-8?B?Q0tuYnptUkF1SVMwcU1jVUpHZFJBeGU2ZjZwSlR1U1VZbjBtcGsxK0h0akxt?=
 =?utf-8?B?TGZhTlRoN0JlcEczVk5BMVk1aitoSVRGOXhnVUhUdGIvTCs3djZaWXFERWJJ?=
 =?utf-8?B?SjJKczlxcEVuUXBKNDF2bWtIVjVGa2diSXBna0hLalYycXVsZXh2akMxRUVX?=
 =?utf-8?B?bG84d2dvZ1U3djB5c0hObm50MG1sV1dmZ3NJZHd5aHhudTJ0L0JJYVE4NkQ2?=
 =?utf-8?B?empuTmpwZEk0RzdXUVozTDdCMEx3blZuUGoyVGRhZGdBSzQrQmJMNm9ENXJC?=
 =?utf-8?B?YnpMUE00cUZUZnFTVFhKMnRWMzRzdGdVNWJoRURaMjZ0VnVra0hjTGxCVGdt?=
 =?utf-8?B?eHJxd282bjBFcHlRaXg1NkI1LzBEYThTVWZxSE16V0lUd1plQUJjSWVyeTcx?=
 =?utf-8?B?ODAraW1yRHRGU05mOWcxcGdROE4zR0ZxUlVWdHdlT3dZNkIxN2pYd0ZPZXk0?=
 =?utf-8?B?NzVaK0hZVVcrWS8xWklVRy9MejRScjVGdjlrMDVFelhOMGpNMFpNZ0pQNklJ?=
 =?utf-8?B?b2Nucy9WeFNkdjRqZUVFQlBFY1cwM3NwWUM0alZ6bkE0a1BpUExZNU1CUmE4?=
 =?utf-8?B?b2dHRW5qS2FxclBUckwvV0h0YjdaTDNTRTgrTktHcHpPVDRpYys4eVBYT0pE?=
 =?utf-8?B?cTJVbnEzd3YxL1FibFB1N3ZDK3lMRGFXSFdJNkN5UHJ0QlNzNkVmd0pqTmE0?=
 =?utf-8?B?YjE2UURqeVdLMTBIT05sTkk4U1R3OTN1amtkbDRTOFdYS2F4emNoc2hpeDZ2?=
 =?utf-8?B?Z0tIZHZsNG9BbEdXTFROV2NNOFdTM2VYS3pIVDVzNVRSQTNaYVNyS3hSWDdD?=
 =?utf-8?B?ZndYcFpmRFJocU43SGpLODlpU2pDeHIyNWxUY0FFYjVrTzJvZUNRWVRrR2li?=
 =?utf-8?B?SFl1SmhHakJNMHh1bWFWWW5GRE1GVDE1RFBqZ0tpSXdoVWsyWkZEc2x3VjlC?=
 =?utf-8?B?L3d0eUwydFBQNEpDOUNBbk9XRjMraUtWV0NPWFlVNHAyWUw0eGdodzFuTkw5?=
 =?utf-8?B?bTk5NTBqSFlPK1poR3BTNEVUU0I5VjlyekNWRDJMNHQ2NE0yN3JDZ0J1Umgx?=
 =?utf-8?B?OTJldU9wd2w5TVhxRUJWM21XRFhkVVkyenhVUVo3OUc5eDFka05ZY3NOaFBV?=
 =?utf-8?B?RDFGeXQ3NDgvNDFpN1hCREV1YnAzM2JpOFd1K0lWZ2NsQVN3M0IwZStBMmp1?=
 =?utf-8?B?M2p1RW1HejhmRDdjRG5VS2VTMXFQTTRpM252dmdzVkllSGpnenF4aHdZT1JF?=
 =?utf-8?B?cVhzL25NZmYvMi95Zlp0L2h6WlBHOXVoT2t0Rzh4MlRoanRnVzlKU080SFBQ?=
 =?utf-8?B?cWtBRVpyY0tQdTRzL0hhMUE4UkM2d1BlZmlaQVBKWWJLOEFUSUV0QTJGQUps?=
 =?utf-8?B?NGhycThmWFAvdzExalJ4enRUN0swcmE0d3F1VldXSlFIREpuQk1UU2pwTzZJ?=
 =?utf-8?B?SGRwUTFMNC9VQkZNVWI5QVNhOHVZVTRQUG41M2lua0YrckpwTmlpOWV5WWsw?=
 =?utf-8?B?V1E9PQ==?=
X-OriginatorOrg: kontron.de
X-MS-Exchange-CrossTenant-Network-Message-Id: af4ed314-4b93-49c7-b031-08db400f2fa6
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2023 13:16:57.3021
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EZ9LrpXXZU4ntfIuKUDjVmxteCDEu2m0o9+YMP+yftXFaybllzI/Yk8so6WATXjlX0XMuL+ctPjvpNa4SB+NgiyeOxme1gpfeVFNZav990Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR10MB5613
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 18.04.23 15:12, Marek Szyprowski wrote:
> On 18.04.2023 12:42, Frieder Schrempf wrote:
>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>>
>> Assuming that with the init flow fixed to meet the documentation at
>> [1] and the pre_enable_prev_first flag set in downstream bridge/panel
>> drivers which require it, we can use the default flow for Exynos as
>> already done for i.MX8M.
>>
>> [1] https://docs.kernel.org/gpu/drm-kms-helpers.html#mipi-dsi-bridge-operation
>>
>> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
>> ---
>> I have no idea if my assumptions are correct and if this works at all.
>> There's a very good chance it doesn't...
> 
> Unfortunately this change breaks all Exynos boards with DSI panels. I've 
> check all 4 panels that are in mainline and none worked.

Ok, thanks for testing anyway!

As already mentioned this was rather a shot in the dark, as I didn't
even bother trying to fully understand what's going on on the Exynos side.

For now I will just remove this patch from the series in the next iteration.