Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230418110919.221578-1-eiichi.tsukata@nutanix.com> <20230418110919.221578-2-eiichi.tsukata@nutanix.com>
In-Reply-To: <20230418110919.221578-2-eiichi.tsukata@nutanix.com>
From:   Paul Moore <paul@paul-moore.com>
Date:   Tue, 18 Apr 2023 09:19:36 -0400
Message-ID: <CAHC9VhQO8bSdbFYszvjWNT1GCCBr8yusDEq1f52akJApXq8kGA@mail.gmail.com>
Subject: Re: [PATCH v2 1/2] audit: add global auditd_pid to make
 auditd_test_task() faster
To:     Eiichi Tsukata <eiichi.tsukata@nutanix.com>
Cc:     eparis@redhat.com, linux-kernel@vger.kernel.org,
        audit@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Apr 18, 2023 at 7:10=E2=80=AFAM Eiichi Tsukata
<eiichi.tsukata@nutanix.com> wrote:
>
> auditd_test_task() is a hot path of system call auditing. This patch
> introduces a global auditd_pid pid struct which can be used for faster
> check of registered audit daemon.
>
> Benchmarks
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>
> Run the following micro benchmarks:
>
>   (1) dd:
>     dd if=3D/dev/zero of=3D/dev/null bs=3D1 count=3D5M
>
>   (2) UnixBench syscall:
>     ./Run syscall -i 10 -c 1
>
> With rule:
>
>   -a never,exit -F arch=3Db64 -S uname
>
> Results:
>
>   (1) dd
>     Base line    : 2.572 sec
>     /w this patch: 2.418 sec (6.3% faster)
>
>   (2) UnixBench syscall Index Score
>     Base line    : 860
>     /w this patch: 953 (10.8% faster)
>
> Signed-off-by: Eiichi Tsukata <eiichi.tsukata@nutanix.com>
> ---
>  kernel/audit.c | 39 +++++++++++----------------------------
>  kernel/audit.h |  4 +++-
>  2 files changed, 14 insertions(+), 29 deletions(-)
>
> diff --git a/kernel/audit.c b/kernel/audit.c
> index 9bc0b0301198..9426980368e4 100644
> --- a/kernel/audit.c
> +++ b/kernel/audit.c
> @@ -71,6 +71,7 @@ static int    audit_initialized =3D AUDIT_UNINITIALIZED=
;
>
>  u32            audit_enabled =3D AUDIT_OFF;
>  bool           audit_ever_enabled =3D !!AUDIT_OFF;
> +struct pid      *auditd_pid;

As discussed previously, I want to keep the auditd tracking PID in the
auditd_connection struct.

--=20
paul-moore.com