Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759460AbXI0Tqy (ORCPT ); Thu, 27 Sep 2007 15:46:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754939AbXI0Tqr (ORCPT ); Thu, 27 Sep 2007 15:46:47 -0400 Received: from ogre.sisk.pl ([217.79.144.158]:44129 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754783AbXI0Tqq (ORCPT ); Thu, 27 Sep 2007 15:46:46 -0400 From: "Rafael J. Wysocki" To: Randy Dunlap Subject: Re: 2.6.23-rc8-mm2: problems on HP nx6325 Date: Thu, 27 Sep 2007 22:01:13 +0200 User-Agent: KMail/1.9.5 Cc: Sam Ravnborg , Andrew Morton , linux-kernel@vger.kernel.org, Thomas Gleixner References: <20070927022220.c76a7a6e.akpm@linux-foundation.org> <200709272149.00195.rjw@sisk.pl> <20070927123715.ebc22761.randy.dunlap@oracle.com> In-Reply-To: <20070927123715.ebc22761.randy.dunlap@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200709272201.14085.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2107 Lines: 53 On Thursday, 27 September 2007 21:37, Randy Dunlap wrote: > On Thu, 27 Sep 2007 21:48:59 +0200 Rafael J. Wysocki wrote: > > > On Thursday, 27 September 2007 21:19, Sam Ravnborg wrote: > > > On Thu, Sep 27, 2007 at 10:33:51AM -0700, Randy Dunlap wrote: > > > > On Thu, 27 Sep 2007 18:53:46 +0200 Sam Ravnborg wrote: > > > > > > > > > Hi Rafael. > > > > > > > > > > > > Fix CPU hotplug breakage on HP nx6325 and similar boxes caused by a reference > > > > > > to disable_apic_timer (labeled as __initdata) from the CPU initialization code. > > > > > > > > > > > > Signed-off-by: Rafael J. Wysocki > > > > > > --- > > > > > > arch/x86_64/kernel/apic.c | 2 +- > > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > > > Index: linux-2.6.23-rc8-mm2/arch/x86_64/kernel/apic.c > > > > > > =================================================================== > > > > > > --- linux-2.6.23-rc8-mm2.orig/arch/x86_64/kernel/apic.c > > > > > > +++ linux-2.6.23-rc8-mm2/arch/x86_64/kernel/apic.c > > > > > > @@ -42,7 +42,7 @@ > > > > > > > > > > > > int apic_verbosity; > > > > > > static int apic_calibrate_pmtmr __initdata; > > > > > > -int disable_apic_timer __initdata; > > > > > > +int disable_apic_timer __cpuinitdata; > > > > > > > > > > > This is with your configuration a reference from a .text section > > > > > to a .init.data section as I see it. > > > > > > > > > > So this ought to have been flagged by the section mismatch > > > > > checks in modpost. > > > > > > > > > > I assume you did not see such warning?? > > > > > > > > I did: > > > > But I didn't. I'm not sure why. > > I did only on one build machine (multiple times). I tried > to reproduce it on another machine and could not. I blame > different build tools. That's possible. I use the default openSUSE 10.2 toolchain. Greetings, Rafael - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/