Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <tencent_D7FC79B0CA961A24A8651221FD8439C5EF05@qq.com>
Date:   Tue, 18 Apr 2023 22:12:14 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.9.1
Subject: Re: [PATCH] eventfd: support delayed wakeup for non-semaphore eventfd
 to reduce cpu utilization
To:     Hillf Danton <hdanton@sina.com>
Cc:     Christoph Hellwig <hch@lst.de>, Fu Wei <wefu@redhat.com>,
        linux-kernel@vger.kernel.org
References: <20230417000711.1100-1-hdanton@sina.com>
From:   Wen Yang <wenyang.linux@foxmail.com>
In-Reply-To: <20230417000711.1100-1-hdanton@sina.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2023/4/17 08:07, Hillf Danton 写道:
> On 16 Apr 2023 19:31:55 +0800 Wen Yang <wenyang.linux@foxmail.com>
>> For the NON SEMAPHORE eventfd, if it's counter has a nonzero value,
>> then a read(2) returns 8 bytes containing that value, and the counter's
>> value is reset to zero. Therefore, in the NON SEMAPHORE scenario,
>> N event_writes vs ONE event_read is possible.
>>
>> However, the current implementation wakes up the read thread immediately
>> in eventfd_write so that the cpu utilization increases unnecessarily.
>>
>> By adding a configurable delay after eventfd_write, these unnecessary
>> wakeup operations are avoided, thereby reducing cpu utilization.
> If the EPOLLOUT wakeup in eventfd_read() breaks, feel free to specify it
> in the commit message after updating the comment below.
> 	/*
> 	 * Every time that a write(2) is performed on an eventfd, the
> 	 * value of the __u64 being written is added to "count" and a
> 	 * wakeup is performed on "wqh". A read(2) will return the "count"
> 	 * value to userspace, and will reset "count" to zero. The kernel
> 	 * side eventfd_signal() also, adds to the "count" counter and
> 	 * issue a wakeup.
> 	 */

Thanks

We will modify it according to your suggestion and then send v2 later.

--

Best wishes,

Wen